keyboard autorepeat in Xmir apps & GTK-on-Mir does not work

Bug #1591356 reported by Albert Astals Cid on 2016-06-10
36
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Stephen M. Webb
GTK+
Fix Released
Medium
gtk+3.0 (Ubuntu)
High
Andreas Pokorny
Trusty
Undecided
Unassigned
Xenial
Undecided
Unassigned
libertine (Ubuntu)
Trusty
Undecided
Unassigned
Xenial
Undecided
Unassigned
xorg-server (Ubuntu)
High
Daniel van Vugt
Trusty
Undecided
Unassigned
Xenial
Undecided
Unassigned
xorg-server-lts-xenial (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Unassigned
Xenial
Undecided
Unassigned

Bug Description

[Impact]

Auto key repeating does not work in Libertine X apps which is very frustrating to users.

[Test Case]

1. Install xterm in libertine
2. Start xterm from the "Xapps" scope
3. Wait for xterm to appear
4. Press and hold a key

See how it only appears once and not multiple times as it should.

[Regression Potential]

Non observed.

--------------------------------------------
Original Description:

How to reproduce:
 * Install xterm in libertine
 * Start xterm from the "Xapps" scope
 * Wait for xterm to appear
 * Press and hold a key
 * See how it only appears once and not multiple times as it should

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity8 (Ubuntu):
status: New → Confirmed
Stephen M. Webb (bregma) on 2016-06-13
Changed in libertine (Ubuntu):
status: New → Confirmed
Changed in unity8 (Ubuntu):
importance: Undecided → Medium
Changed in libertine (Ubuntu):
importance: Undecided → Medium

xmir treats repeat events like key up ... which probably also explains why keys frequently get stuck in xmir..

tags: added: xmir
Changed in unity8 (Ubuntu):
status: Confirmed → Invalid
kevin gunn (kgunn72) wrote :

this is really annoying trying to use unity8 as a daily driver

Changed in libertine (Ubuntu):
importance: Medium → High
no longer affects: unity8 (Ubuntu)
Changed in xorg-server (Ubuntu):
importance: Undecided → High
kevin gunn (kgunn72) wrote :

fwiw, i just tried gedit not in libertine but with gtk-mir and got the same bug. so could it be an issue in something other than xmir?

summary: - keyboard autorepeat in libertine apps does not work
+ keyboard autorepeat in libertine apps & gtk-mir does not work
kevin gunn (kgunn72) on 2016-06-24
tags: added: unity8-desktop

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xorg-server (Ubuntu):
status: New → Confirmed
tags: added: gtk-mir
Changed in gtk+3.0 (Ubuntu):
status: New → Confirmed
Changed in xorg-server:
status: New → Invalid
affects: xorg-server → mir
no longer affects: mir
Daniel van Vugt (vanvugt) wrote :

Fixed in Xmir. Although I'm still confused as to why it always worked for Xmir on Mir's demo servers and not Unity8.

https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/commit/?id=a64d38bae4f8a27126575299d15896d98e16d3f2

Another caveat: I've been working in the wrong branch lately. This does not affect patch contents for distro but I should switch to 1.18 properly.

Changed in xorg-server (Ubuntu):
status: Confirmed → Fix Committed
summary: - keyboard autorepeat in libertine apps & gtk-mir does not work
+ keyboard autorepeat in Xmir apps & GTK-on-Mir does not work
Changed in xorg-server (Ubuntu):
assignee: nobody → Daniel van Vugt (vanvugt)
kevin gunn (kgunn72) on 2016-07-21
Changed in canonical-devices-system-image:
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:1.18.4-1ubuntu3

---------------
xorg-server (2:1.18.4-1ubuntu3) yakkety; urgency=medium

  * debian/patches/xmir.patch:
    - Fix bottom/right edge corruption. (LP: #1510849)
    - Fix key repeat. (LP: #1591356)
    - Don't delete outputs without replacing them. (LP: #1504422) (LP: #1602561)
    - Xmir -debug: Log WM types by name and number.
    - Implement fake GLX frame notification/timing.
    - Improve focus tracking.

 -- Robert Ancell <email address hidden> Thu, 21 Jul 2016 11:42:03 +0200

Changed in xorg-server (Ubuntu):
status: Fix Committed → Fix Released
Changed in libertine (Ubuntu):
status: Confirmed → Invalid
Changed in gtk+3.0 (Ubuntu):
assignee: nobody → Andreas Pokorny (andreas-pokorny)
description: updated
Changed in canonical-devices-system-image:
assignee: nobody → Stephen M. Webb (bregma)
importance: Undecided → High
milestone: none → 13
status: Fix Committed → Confirmed
Pat McGowan (pat-mcgowan) wrote :

needs to land in vivid overlay

Daniel van Vugt (vanvugt) wrote :

A second more correct fix landed later in:
https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/commit/?id=f704937aa59132b612a1c4802018b86c98e620ca

But that should be included automatically in the next update too.

Changed in gtk+3.0 (Ubuntu):
importance: Undecided → High
status: Confirmed → Triaged
Changed in gtk:
importance: Unknown → Medium
status: Unknown → Fix Released

Hello Albert, or anyone else affected,

Accepted xorg-server into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:1.18.4-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in xorg-server (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed

I have enabled xenial-proposed and installed xmir. I can confirm this bug is fixed.

tags: added: verification-done
removed: verification-needed
Changed in canonical-devices-system-image:
milestone: 13 → backlog
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xorg-server - 2:1.18.4-0ubuntu0.1

---------------
xorg-server (2:1.18.4-0ubuntu0.1) xenial; urgency=medium

  * New upstream bugfix release. (LP: #1619142)
  * randr-adjust-masters-last-set-time.diff,
    randr-do-not-check-the-screen-size.diff:
    Fix issues changing display mode on prime setups. (LP: #1586260)
  * os-treat-ssh-as-a-non-local-client.diff: Dropped, upstream.
  * drm_device_keep_trying.patch: Dropped, shouldn't be needed anymore,
    and causes issues on non-x86 archs. (LP: #1581076)
  * debian/patches/xmir.patch: backport XMir fixes from Ubuntu "Yakkety Yak"
    - fix button/menu focus failures (lp: #1590553)
    - ignore 'unnkown 11 event' (lp: #1617925)
    - don't call epoxy every frame (lp: #1617932)
    - fix unclickable parts of the screen after rotation (lp: #1613708)
    - fix key repeat issues (lp: #1591356)

 -- Timo Aaltonen <email address hidden> Thu, 01 Sep 2016 10:28:26 +0300

Changed in xorg-server (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for xorg-server has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Hello Albert, or anyone else affected,

Accepted xorg-server-lts-xenial into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server-lts-xenial/2:1.18.4-0ubuntu0.2~trusty1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Albert Astals Cid (aacid) wrote :

Unfortunately I don't run a xenial machine anymore (i'm on zesty now) so I'd appreciate if someone else could do the testing.

Daniel van Vugt (vanvugt) wrote :

The fix is already in xenial (see above). Chris is asking for trusty testing. Similarly I don't run trusty :)

Surely whoever requested this for trusty should be able to test it? Is there such a person?

Brian Murray (brian-murray) wrote :

Hello Albert, or anyone else affected,

Accepted xorg-server-lts-xenial into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server-lts-xenial/2:1.18.4-0ubuntu0.2~trusty2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in xorg-server-lts-xenial (Ubuntu):
status: New → Invalid
Changed in xorg-server-lts-xenial (Ubuntu Xenial):
status: New → Invalid
Changed in xorg-server-lts-xenial (Ubuntu Trusty):
status: New → Fix Committed
Changed in xorg-server (Ubuntu Trusty):
status: New → Invalid
kevin gunn (kgunn72) on 2017-03-06
Changed in canonical-devices-system-image:
milestone: backlog → u8c-1
Daniel van Vugt (vanvugt) wrote :

Fix Released surely...? Andreas' upstream fix was completed 7 months or so ago.

Changed in canonical-devices-system-image:
status: Confirmed → Incomplete
kevin gunn (kgunn72) wrote :

definitely - just tested, it's fixed.

Changed in canonical-devices-system-image:
status: Incomplete → Fix Released
no longer affects: xorg-server (Ubuntu RTM)
no longer affects: libertine (Ubuntu)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.