keyboard autorepeat in Xmir apps & GTK-on-Mir does not work

[Albert Astals Cid]

[Impact]

Auto key repeating does not work in Libertine X apps which is very frustrating to users.

[Test Case]

1. Install xterm in libertine
2. Start xterm from the "Xapps" scope
3. Wait for xterm to appear
4. Press and hold a key

See how it only appears once and not multiple times as it should.

[Regression Potential]

Non observed.

--------------------------------------------
Original Description:

How to reproduce:
 * Install xterm in libertine
 * Start xterm from the "Xapps" scope
 * Wait for xterm to appear
 * Press and hold a key
 * See how it only appears once and not multiple times as it should

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Andreas Pokorny (andreas-pokorny)]

xmir treats repeat events like key up ... which probably also explains why keys frequently get stuck in xmir..

[Andreas Pokorny (andreas-pokorny)]

https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/tree/hw/xmir/xmir-input.c?h=xmir-1.18#n386 needs fixing.

[kevin gunn (kgunn72)]

this is really annoying trying to use unity8 as a daily driver

[kevin gunn (kgunn72)]

fwiw, i just tried gedit not in libertine but with gtk-mir and got the same bug. so could it be an issue in something other than xmir?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Daniel van Vugt (vanvugt)]

Fixed in Xmir. Although I'm still confused as to why it always worked for Xmir on Mir's demo servers and not Unity8.

https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/commit/?id=a64d38bae4f8a27126575299d15896d98e16d3f2

Another caveat: I've been working in the wrong branch lately. This does not affect patch contents for distro but I should switch to 1.18 properly.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server - 2:1.18.4-1ubuntu3

---------------
xorg-server (2:1.18.4-1ubuntu3) yakkety; urgency=medium

  * debian/patches/xmir.patch:
    - Fix bottom/right edge corruption. (LP: #1510849)
    - Fix key repeat. (LP: #1591356)
    - Don't delete outputs without replacing them. (LP: #1504422) (LP: #1602561)
    - Xmir -debug: Log WM types by name and number.
    - Implement fake GLX frame notification/timing.
    - Improve focus tracking.

 -- Robert Ancell <email address hidden> Thu, 21 Jul 2016 11:42:03 +0200

[Pat McGowan (pat-mcgowan)]

needs to land in vivid overlay

[Daniel van Vugt (vanvugt)]

A second more correct fix landed later in:
https://git.launchpad.net/~xmir-team/xorg-server/+git/xmir/commit/?id=f704937aa59132b612a1c4802018b86c98e620ca

But that should be included automatically in the next update too.

[Andy Whitcroft (apw)]

Hello Albert, or anyone else affected,

Accepted xorg-server into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server/2:1.18.4-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Christopher Townsend (townsend)]

I have enabled xenial-proposed and installed xmir. I can confirm this bug is fixed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xorg-server - 2:1.18.4-0ubuntu0.1

---------------
xorg-server (2:1.18.4-0ubuntu0.1) xenial; urgency=medium

  * New upstream bugfix release. (LP: #1619142)
  * randr-adjust-masters-last-set-time.diff,
    randr-do-not-check-the-screen-size.diff:
    Fix issues changing display mode on prime setups. (LP: #1586260)
  * os-treat-ssh-as-a-non-local-client.diff: Dropped, upstream.
  * drm_device_keep_trying.patch: Dropped, shouldn't be needed anymore,
    and causes issues on non-x86 archs. (LP: #1581076)
  * debian/patches/xmir.patch: backport XMir fixes from Ubuntu "Yakkety Yak"
    - fix button/menu focus failures (lp: #1590553)
    - ignore 'unnkown 11 event' (lp: #1617925)
    - don't call epoxy every frame (lp: #1617932)
    - fix unclickable parts of the screen after rotation (lp: #1613708)
    - fix key repeat issues (lp: #1591356)

 -- Timo Aaltonen <email address hidden> Thu, 01 Sep 2016 10:28:26 +0300

[Martin Pitt (pitti)]

The verification of the Stable Release Update for xorg-server has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Chris Halse Rogers (raof)]

Hello Albert, or anyone else affected,

Accepted xorg-server-lts-xenial into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server-lts-xenial/2:1.18.4-0ubuntu0.2~trusty1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Albert Astals Cid (aacid)]

Unfortunately I don't run a xenial machine anymore (i'm on zesty now) so I'd appreciate if someone else could do the testing.

[Daniel van Vugt (vanvugt)]

The fix is already in xenial (see above). Chris is asking for trusty testing. Similarly I don't run trusty :)

Surely whoever requested this for trusty should be able to test it? Is there such a person?

[Brian Murray (brian-murray)]

Hello Albert, or anyone else affected,

Accepted xorg-server-lts-xenial into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xorg-server-lts-xenial/2:1.18.4-0ubuntu0.2~trusty2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Daniel van Vugt (vanvugt)]

Fix Released surely...? Andreas' upstream fix was completed 7 months or so ago.

[kevin gunn (kgunn72)]

definitely - just tested, it's fixed.