[PATCH] Some memory leaks fixed from upstream

Bug #105692 reported by Marco Trevisan (Treviño)
4
Affects Status Importance Assigned to Milestone
xorg-server (Ubuntu)
Fix Released
High
Unassigned

Bug Description

I've found some memory leaks fixed recently on git and that are still present on ubuntu xorg build, so I've applied the upstream patches to the ubuntu (3ubuntu8) sources...

Those are the commits I've added:
 - http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=4771fa8747791498e504d73afccfb5833499a38b
 - http://gitweb.freedesktop.org/?p=xorg/xserver.git;a=commit;h=cf7ca9d09cba14d107152a5179de38e5ef7bd784

On next message I'll attach the patchfile to upgrade to xorg version 3ubuntu9 ;)

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Attached the patch file, it includes:
 - 132_plug_memory_leak_in_doLoadModule.diff
 - 133_xfree86_fix_memory_leak_in_option_parsing.diff

Changelog:

xorg-server (2:1.2.0-3ubuntu9) edgy; urgency=low

  * debian/patches/132_plug_memory_leak_in_doLoadModule.diff
    - upstream patch to fix option parsing functions and callers
      thereof to not leak memory.
       see git commit: 4771fa8747791498e504d73afccfb5833499a38b
  * debian/patches/133_xfree86_fix_memory_leak_in_option_parsing.diff
    - upstream patch to plug memory leak in doLoadModule()
       see git commit: cf7ca9d09cba14d107152a5179de38e5ef7bd784

 -- Trevi - 3v1n0 <email address hidden> Wed, 11 Apr 2007 23:15:59 +0200

This will be applied to my edgy packages from version 2:1.2.0-3edgy8~3v1ubuntu1

Changed in xorg-server:
status: Unconfirmed → Fix Committed
Revision history for this message
Bryce Harrington (bryce) wrote :

With xserver 1.3 in Gutsy, it looks like one of the patches is already incorporated, but the other isn't. Is 132_plug_memory_leak_in_doLoadModule.diff still needed?

Changed in xorg-server:
importance: Undecided → High
status: Fix Committed → Needs Info
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I think they are since I've taken the patch from git on 2007-04-11, and they were there since some time; however just check if the patch applies...

PS: there are also some leaks that have been found just on xserver 1.3, maybe should be fixed; when I can find time I'll look for them too ;)

Bye!

Revision history for this message
Bryce Harrington (bryce) wrote :

Yep, looks like 132 is applied already as well in xserver 1.3. Thanks for posting the patches!

Changed in xorg-server:
status: Needs Info → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.