[MIR] xmlstarlet

[Mathieu Trudel-Lapierre]

[Availability]
xmlstartlet is already available in Universe; built for all supported architectures

[Rationale]
xmlstarlet is a new build-dependency for a core package (libnl3); which implements the netlink user-land libraries used by packages which handle network connections (build-depends of network-manager, iw, wpasupplicant, libvirt, ipvsadm, etc.)

[Security]
CVE entries - CVE-2004-2159 (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-2159), CVE-2004-2160 (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2004-2160); appear to have been promptly fixed at that time.
Secunia history - none
Binaries running as root or suid/sgid: none
Daemons: none
Network activity: no ports opened
Does not handle incoming network data

[Quality assurance]
Package works out of the box without configuration
The package does not ask any debconf questions
Debian bugs: some (3) minor bugs involving missing useful information in error messages.
Hardware: does not deal with hardware

[Standards compliance]
FHS, Debian Policy compliant
Packaging system (debhelper/cdbs/dbs) is debhelper
Patch system is quilt (format 3.0 (quilt) package)
No packaging oddities

[Dependencies]
Runtime: libc6 (>= 2.4), libxml2 (>= 2.7.4), libxslt1.1 (>= 1.1.25)
Build: debhelper (>= 8), dh-autoreconf, autotools-dev, libxml2-dev, libxslt1-dev (>=1.1.9), automake (>=1.11)

Are these all in main? - yes

[Background information]
The general purpose and context of the package is clear from the package's debian/control file:
Description-en: command line XML toolkit
 XMLStarlet is a set of command line utilities (tools) which can be used to
 transform, query, validate, and edit XML documents and files using simple set
 of shell commands in similar way it is done for plain text files using
 UNIX grep, sed, awk, diff, patch, join, etc commands.
 .
 This set of command line utilities can be used by those who deal with many XML
 documents on UNIX shell command prompt as well as for automated XML processing
 with shell scripts.
 .
 The toolkit's feature set includes options to:
  Check or validate XML files (simple well-formedness check, DTD, XSD, RelaxNG)
  Calculate values of XPath expressions on XML files (such as running sums, etc)
  Search XML files for matches to given XPath expressions
  Apply XSLT stylesheets to XML documents (including EXSLT support, and passing
 parameters to stylesheets)
  Query XML documents (ex. query for value of some elements of attributes,
 sorting, etc)
  Modify or edit XML documents (ex. delete some elements)
  Format or "beautify" XML documents (as changing indentation, etc)
  Fetch XML documents using http:// or ftp:// URLs
  Browse tree structure of XML documents (in similar way to 'ls' command for
 directories)
  Include one XML document into another using XInclude
  XML c14n canonicalization
  Escape/unescape special XML characters in input text
  Print directory as XML document
  Convert XML into PYX format (based on ESIS - ISO 8879), and vice versa

[Jamie Strandboge (jdstrand)]

Confirmed the security history and other bits. lintian clean, no suid, initscripts, dbus, or sudo fragments. Has a test suite ('All 73 tests behaved as expected (2 expected failures)'). Uses modern Debian packaging including a watch file. Has one compiler warning:

src/xml_ls.c: In function 'xml_print_dir':
src/xml_ls.c:151:9: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]

While there is a race between the opendir(dir) and the chdir(dir), it doesn't matter-- the chdir() isn't used for anything. I see no reason why this can't be in main.

[Jamie Strandboge (jdstrand)]

2011-12-20 20:13:12 INFO Override Component to: 'main'
2011-12-20 20:13:13 INFO 'xmlstarlet - 1.3.0-1/universe/text' source overridden
2011-12-20 20:13:13 INFO 'xmlstarlet-1.3.0-1/universe/text/OPTIONAL' binary overridden in precise/amd64
2011-12-20 20:13:13 INFO 'xmlstarlet-1.3.0-1/universe/text/OPTIONAL' binary overridden in precise/armel
2011-12-20 20:13:13 INFO 'xmlstarlet-1.3.0-1/universe/text/OPTIONAL' binary overridden in precise/armhf
2011-12-20 20:13:13 INFO 'xmlstarlet-1.3.0-1/universe/text/OPTIONAL' binary overridden in precise/i386
2011-12-20 20:13:13 INFO 'xmlstarlet-1.3.0-1/universe/text/OPTIONAL' binary overridden in precise/powerpc
Confirm this transaction? [yes, no] yes
2011-12-20 20:13:24 INFO Transaction committed.
2011-12-20 20:13:24 INFO Done.