Xfwm4's 'dialog' window has an unused maximise-button

[Jackson Doak]

The maximise button in ubiquity does nothing, this happenes both in a live session and the ubiquity stand-alone.
A screenshot is attached

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: ubiquity 2.15.1
ProcVersionSignature: Ubuntu 3.9.0-0.4-generic 3.9.0
Uname: Linux 3.9.0-0-generic i686
ApportVersion: 2.10-0ubuntu1
Architecture: i386
CasperVersion: 1.332
Date: Mon May 6 22:08:28 2013
InstallCmdLine: file=/cdrom/preseed/xubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash -- maybe-ubiquity
LiveMediaBuild: Xubuntu 13.10 "Saucy Salamander" - Alpha i386 (20130506)
MarkForUpload: True
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: ubiquity
UpgradeStatus: No upgrade log present (probably fresh install)

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1177116

[Colin Watson (cjwatson)]

There isn't supposed to be a maximise button, I think. We don't have one when Ubiquity is running on Ubuntu desktop images.

[Jackson Doak (noskcaj)]

the this is a bug in the themes of the various flavours, not ubiquity.

On Fri, Jun 7, 2013 at 10:12 PM, Colin Watson <email address hidden>wrote:

> There isn't supposed to be a maximise button, I think. We don't have
> one when Ubiquity is running on Ubuntu desktop images.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1177116
>
> Title:
> maximise button does nothing in Ubiquity
>
> Status in One Hundred Paper Cuts:
> New
> Status in “ubiquity” package in Ubuntu:
> Confirmed
>
> Bug description:
> The maximise button in ubiquity does nothing, this happenes both in a
> live session and the ubiquity stand-alone.
> A screenshot is attached
>
> ProblemType: Bug
> DistroRelease: Ubuntu 13.10
> Package: ubiquity 2.15.1
> ProcVersionSignature: Ubuntu 3.9.0-0.4-generic 3.9.0
> Uname: Linux 3.9.0-0-generic i686
> ApportVersion: 2.10-0ubuntu1
> Architecture: i386
> CasperVersion: 1.332
> Date: Mon May 6 22:08:28 2013
> InstallCmdLine: file=/cdrom/preseed/xubuntu.seed boot=casper
> initrd=/casper/initrd.lz quiet splash -- maybe-ubiquity
> LiveMediaBuild: Xubuntu 13.10 "Saucy Salamander" - Alpha i386 (20130506)
> MarkForUpload: True
> ProcEnviron:
> TERM=xterm
> PATH=(custom, no user)
> XDG_RUNTIME_DIR=<set>
> LANG=en_US.UTF-8
> SHELL=/bin/bash
> SourcePackage: ubiquity
> UpgradeStatus: No upgrade log present (probably fresh install)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/hundredpapercuts/+bug/1177116/+subscriptions
>

[Pasi Lallinaho (knome)]

I believe this is a bug in the window managers, or in the way the window is called rather than the themes.

[Dimitri John Ledkov (xnox)]

From screenshot it's hard to tell if ubiquity is running from the live session (e.g. Try $distro -> then launch ubiquity) or from ubiquity-dm (e.g. Install $distro straight away). Potentially window decorators can be wrong/different in one or both cases and possibly it needs to be fixed in multiple places.

As far as I remember we should not have maximize,resize,minimize buttons anywhere.

[Simon Steinbeiß (ochosi)]

This issue could be addressed by setting a different window-type in Ubiquity (http://www.gtk.org/api/2.6/gtk/GtkWindow.html#gtk-window-set-type-hint), certain types (e.g. menu) hide the maximize and minimize button.

[Pasi Lallinaho (knome)]

I can confirm the Maximize button is shown both when running via "Install now" and when running via the Live session. It doesn't work in either mode.

In the "Install now" -mode, only the maximize and the menu button are shown. When running via the Live session, also minimize and close-buttons are shown.

[Simon Steinbeiß (ochosi)]

From reading through ubiquity's code, it seems that it sets the window-type-hint to dialog, which seems fine.
Xfwm4 however shows maximize-buttons in all dialog windows, sometimes non-functional ones. I assume that this is a design decision in Xfwm4, but it can also be considered a bug.

[Pasi Lallinaho (knome)]

Lubuntu folks, if you still can confirm the same bug in Lubuntu, please file a new bug; it is different from this one.

[Dimitri John Ledkov (xnox)]

If there is a window type hint that does not show maximize button under: xfwm4, compiz, metacity; it'd be happy to change the window type hint to a better one.

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

The patch can be tested by installing xfwm4 from my Testing PPA.

https://launchpad.net/~thad-fisch/+archive/test

[Launchpad Janitor (janitor)]

This bug was fixed in the package xfwm4 - 4.11.1-2ubuntu2

---------------
xfwm4 (4.11.1-2ubuntu2) trusty; urgency=medium

  * Don't have a maximise button if it won't work. LP: #1177116
 -- Jackson Doak <email address hidden> Sat, 05 Apr 2014 07:34:09 +1100

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Windows with a fixed size (about dialogs,..) have an unnecessary maximize button.

xfwm4 4.11.1

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Created attachment 5495
Remove unused maximize button

[Landry-o (landry-o)]

*** Bug 11309 has been marked as a duplicate of this bug. ***

[Simon Steinbeiß (ochosi)]

Tested the patch and it works as it should. Pushed to master:
http://git.xfce.org/xfce/xfwm4/commit/?id=78b5c3c48a187ae54d97369a738b8a18e31e459a

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Not completely fixed yet. Some ubiquity windows still have a maximize button and are not resizable.

http://www.zimagez.com/zimage/screenshot-081214-170915.php