Mistake in xfsprogs string - 'prefered'

[Malcolm Parsons]

'preferred' should be spelt with two 'r's

It is spelt incorrectly in these strings:

" report or modify prefered extent size (in bytes) for the current path\n"

"get/set prefered extent size (in bytes) for the open file"

See patch for details

[Sebastian Rode (sebastian-ro-deactivatedaccount)]

If this is still a issue then to get your fix included in Ubuntu, it would help if you tried transforming it into a debdiff (http://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff) and submit it for review (http://wiki.ubuntu.com/SponsorshipProcess). If you prefer somebody else to do that, that's fine - please just indicate if you're available to do that.

[Malcolm Parsons (malcolm-parsons)]

wouldn't it be better to send the path upstream?

[Malcolm Parsons (malcolm-parsons)]

*patch

[PaulSchulz (paulschulz)]

Spelling of 'prefered' still in xfsprogs-2.9.4

Patch applies with the following result:
$ patch -p1 < ../xfsprogs-strings.patch
patching file include/xfs_ag.h
Hunk #1 succeeded at 181 (offset 2 lines).
patching file io/open.c
patching file libxfs/xfs_alloc.c
Hunk #1 succeeded at 1751 (offset 1 line).
patching file libxfs/xfs_mount.c
patching file mkfs/xfs_mkfs.c
Hunk #1 succeeded at 409 with fuzz 1 (offset 2 lines).

[Josh Holland (jshholland)]

Debdiff attached

[Hew McLachlan (hew)]

Thanks for your debdiff. I have subscribed ubuntu-main-sponsors as per https://wiki.ubuntu.com/SponsorshipProcess to review the patch (it looks good to me).

Fix Committed status is used once a fix is available from an official software repository (such as -proposed), and is not used for patches in Launchpad. I have set the status back to Triaged. Thanks again for your help!

[Bryce Harrington (bryce)]

Thanks, I've reviewed the patch.

There is one problem with the debdiff, which is that code changes need to be done as patches in debian/patches/ using a patch system. xfsprogs lacks a patch system so the debdiff would need to add this. If you fix this, we can sponsor it.

I would also echo comment #3 that this probably should just go upstream. If that's done, then we can continue to auto-sync the xfsprogs package in the future. If we carry this patch, we'll have to do merges.

[Malcolm Parsons (malcolm-parsons)]

https://wiki.ubuntu.com/UbuntuDevelopment/CodeReviews

If the patch was deemed not to be good enough yet, the bug will be re-assigned to the patch author and set to In Progress.

[Malcolm Parsons (malcolm-parsons)]

> I would also echo comment #3 that this probably should just go upstream.

You'd think that after 2 years, somebody would have been able to report this upstream.

[Malcolm Parsons (malcolm-parsons)]

> There is one problem with the debdiff, which is that code changes need
> to be done as patches in debian/patches/ using a patch system. xfsprogs
> lacks a patch system so the debdiff would need to add this. If you fix
> this, we can sponsor it.

https://wiki.ubuntu.com/PackagingGuide/PatchSystems#Patching%20other%20people's%20packages

The most important thing to keep in mind when patching packages maintained by other people is to keep the patch system (or lack thereof) that the maintainer has set up. This will ensure consistency and make the package maintainer more likely to accept your patch.

[Martin Pitt (pitti)]

Josh, thanks for the patch! Bryce, thank you for forwarding this upstream!

I decline this for sponsoring, though, for the following reasons:

 * Changing the user-visible string breaks translations, thus it should be done upstream together with an update of the .po files.
 * Changing the code comments doesn't fix any user-visible issue, isn't so bad that people can't read the code any more, and introducing a delta against debian just for this imposes an unreasonable maintenance overhead.

Thus this will just trickle through once upstream fixes this.

[Josh Holland (jshholland)]

Having it assigned to me was annoying, and as we are allowing the fix to trickle down from upstream, unnecessary.

[David Futcher (bobbo)]

Adding 'patch-accepted-upstream' tag. Has this trickled down to Ubuntu yet, could anyone (preferably in Maverick) please check this for us?

Thanks!

[Malcolm Parsons (malcolm-parsons)]

It's fixed in karmic.