Editing XFCE keyboard settings requires unnecessary input

[Yuv]

* Xubuntu 14.04 LTS amd64 installed from scratch.
* I want to edit a keyboard application shortcut.
To reproduce:
* Enter the Keyboard Settings, Application Shortcuts tab
* Select shortcut to edit
* Click Edit
* Click Open
* Browse to the command and select it
* click OK
Observed Result:
* A Command Shortcut window requires a click on the keyboard combination to proceed
Expected Result:
* Close the window and the change in Command takes effect (I do not want to change the Shortcut itself)
Workaround:
* Double-click on shortcut to edit (instead of selecting it and clicking the Edit button)

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/Xfce. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

[Xfce14 (xfce14)]

* Xubuntu 14.04 LTS amd64 installed from scratch.
* I want to edit a keyboard application shortcut.
To reproduce:
* Enter the Keyboard Settings, Application Shortcuts tab
* Select shortcut to edit
* Click Edit
* Click Open
* Browse to the command and select it
* click OK
Observed Result:
* A Command Shortcut window requires a click on the keyboard combination to proceed
Expected Result:
* Close the window and the change in Command takes effect (I do not want to change the Shortcut itself)
Workaround:
* Double-click on shortcut to edit (instead of selecting it and clicking the Edit button)

[Yuv (yuv)]

Thanks for the hint. Done: https://bugzilla.xfce.org/show_bug.cgi?id=11157

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Thanks for taking the time to report this bug in the upstream bug tracking system this is a tremendous help. Launchpad has the ability to watch lots of upstream bug trackers and this can be done by following the procedure documented at https://wiki.ubuntu.com/Bugs/Watches. I've added the bug watch for this bug report.

[Simon Steinbeiß (ochosi)]

This is the expected behavior, I'm not sure how this could be improved. How should the edit-button know what aspect you want to edit?

Double-clicking the corresponding column is not a workaround, it's a feature if you only want to modify one aspect.

[Xfce14 (xfce14)]

To make this behaviour more intuitive, add an OK button on the window to enter the Shortcut. Pressing "OK" accepts the Command change while leaving the Shortcut unchanged.

[Simon Steinbeiß (ochosi)]

There already is an "OK" button in the window after the "open" dialog closes. (Note: you cannot add a custom button to the open dialog as it is part of Gtk2.)

[Xfce14 (xfce14)]

There is indeed an OK button on adding/editing the Command. There is no OK button on adding/editing the Shortcut. If I press a Shortcut, the window closes automatically (which is nice and time saving), but if I do not want to enter a Shortcut I want an option to click OK and leave the Shortcut unchanged while retaining the changed Command. Right now the only thing I can do is either click Cancel (and lose the changes to the command) or press the Shortcut (which is unelegant because it forces me to remember what the Shortcut was in the first place). An OK button on that last window would make it like the previous one, more intuitive.