xfce4-session fallback path is broken

[apport hater]

The XFSM_SHUTDOWN_SHUTDOWN case is broken in the fallback path.

[Mikhefr (mikhefr)]

Created attachment 6101
Fix 'shutdown' action in the fallback mode

The bug can be easily fixed in this way:
- if (type == XFSM_SHUTDOWN_RESTART)
+ else if (type == XFSM_SHUTDOWN_RESTART)

but I think it would be better to use switch instead of multiple if..else.

[Eric Koegel (eric-koegel)]

Awesome, thanks! Pushed to master in:
commit 83fd4fee8697fc5da8411c99b18900d211b72d68
Author: Mikhail Efremov <email address hidden>
Date: Fri Mar 20 20:54:38 2015 +0300

    Fix 'shutdown' action in the fallback mode

    Use switch instead of multiple if..else.

    Signed-off-by: Eric Koegel <email address hidden>
http://git.xfce.org/xfce/xfce4-session/commit/?id=83fd4fee8697fc5da8411c99b18900d211b72d68

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "xfce-4.12_1_fix-fallback-shutdown.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Theo Linkspfeifer (lastonestanding)]

Please forward this patch to the Xfce bug tracker. Thanks.

https://bugzilla.xfce.org/

[Theo Linkspfeifer (lastonestanding)]

Looks like this was fixed long ago, but not in the xfce-4.12 branch.

https://git.xfce.org/xfce/xfce4-session/commit/xfce4-session/xfsm-shutdown-fallback.c?id=83fd4fee8697fc5da8411c99b18900d211b72d68

[Sean Davis (bluesabre)]

Fixed in 4.14 and newer.