Please merge xen 4.1.2-7

Bug #1013088 reported by Stefan Bader on 2012-06-14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xen (Ubuntu)
Stefan Bader

Bug Description

I have done a merge from current Debian unstable with the last version in Ubuntu (4.1.2-2ubuntu2). This is build tested only right now and I will update the bug report when I had a chance to do some quick runtime tests. But I wanted to start the review early on. There are also a few open question I have:

- The changes to add conflicts and replaces for the version 3 library. Are those actually still needed? I would think that those were for transitions from a system running Xen 3.x which neither the last LTS (now 12.04/Precise) nor the previous release (happens to be the same) do. Or am I wrong?

- I dropped the LDFLAGS change because, at least right now, the toolchain does not seem to pass any options in LDFLAGS by itself. So the compile works without that change. Would it be better to just comment the line out so someone would find it again or just drop it completely as I did?

- Beside of some security related patches I pulled in from upstream Xen, I also backported one change from their staging/unstable to remove all asmlinkage annotations. A mimimal required fix would have been to make three places be consistent between function declarations or otherwise the i386 build would break with gcc 4.7 as it checks harder. Though it seemed more appropriate to backport the upstream change even though it is bigger.

- The build dependency on ipxe-qemu does not work as we do not have that package split. I fixed it by reverting back to depend on ipxe but we could instead depend on kvm-ipxe but then needed an additional change to the build system to adapt rom names and location. Not sure which path is better.

Stefan Bader (smb) wrote :
Changed in xen (Ubuntu):
status: New → In Progress
assignee: nobody → Stefan Bader (stefan-bader-canonical)
importance: Undecided → Wishlist
Stefan Bader (smb) wrote :
tags: added: patch
Stefan Bader (smb) wrote :

Limited testing completed: still using the old stack (xm) though. Boot, login, shutdown of HV and PV guest. Save and restore of PV guest. No obvious problems seen.

Stefan Bader (smb) wrote :

Note about testing: host 64bit only.

Stefan Bader (smb) wrote :

Looking again into the debdiff, I saw two small glitches which I leave for reviewers as a little challenge to find... ;)

Stefan Bader (smb) wrote :

By now we could actually merge the latest Debian unstable (4.1.3~rc1+hg-20120614.a9c0a89c08f2-2) which incidentally adds all of the security related changes and fixes the i386 compile breakage (by fixing the discrepancies instead of going the way of dropping the whole asmlinkage annotations).

Stefan Bader (smb) wrote :
g9ahwkcm (g9ahwkcm) wrote :

Is this due anytime soon?

Does it fix the PV privilege escalation from 64 bit guests?

Stefan Bader (smb) wrote :

Actually it is already done and out. Unfortunately there had been newer upstream versions merged but this tracking bug was not referred to. So basically before quantal there were individual releases for those issues like:

but for quantal it was included in the following merge from upstream without mentioning the details:

Changed in xen (Ubuntu):
status: In Progress → Fix Released
g9ahwkcm (g9ahwkcm) wrote :

cool thanks

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers