Thunderbird doesn't accept URI attachments anymore

[Nathan Teodosio]

The desktop portal constructs an mailto: url with an attachment= but thunderbird upstream explicitly decided to not allow adding files from an URL for security reasons.

One can still use the -compose option though, as this patch does.

Test case
---------

* Install the proposed package.
* Log out and back in.
* Set Thunberbird as default client in Gnome Control Panel.
* Open Nautilus and try to attach two files to the same email. They can be creatively named, it should not break on weird characters.
* Thunderbird should open with the corresponding files attached.
* [For regression testing] Set Evolution as the default.
* Open Nautilus and try to attach two files to the same email. They can be creatively named, it should not break on weird characters. It only attaches one file, this is however not a regression.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "xdg-deskop-portal-gtk.diff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Nathan Teodosio (nteodosio)]

The last patch wouldn't build in Jammy due to older Glib, this one
builds there too (attached build log in Jammy).

[Lucas Kanashiro (lucaskanashiro)]

Hi Nathan,

Just to understand a bit better, is this bug affecting just Jammy? Any other Ubuntu series? Please target the correct series in the bug.

Looking at your debdiff, the version string tells me that the target should be Mantic and Lunar, since they have version 1.14.1-1. However you mentioned Jammy, if that's the case, you need to apply your changes on top of version 1.14.0-1build1.

Apart from that, the packaging changes LGTM. I see there is an ongoing discussion in your upstream PR, maybe it is a good idea to wait a bit to see if the patch requires some changes.

Another thing is that you need to update your bug description if you want to SRU the proposed changes. Please, follow the template provided here:

https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

[Nathan Teodosio (nteodosio)]

Hi Lucas, thanks for having a look.

 > Just to understand a bit better, is this bug affecting just Jammy? Any
 > other Ubuntu series? Please target the correct series in the bug.

No, it goes all the way to Focal. The mention to Jammy was because in
the upstream pull request the first version of the patch failed to build
in Jammy. Sorry for the lack of clarity.

I'm used to first having the patch to the development release uploaded
and only then composing the SRU. Is that not the recommended procedure?

 > Apart from that, the packaging changes LGTM. I see there is an ongoing
 > discussion in your upstream PR, maybe it is a good idea to wait a bit to
 > see if the patch requires some changes.

Sure, makes sense.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the reply Nathan.

Right, so I am targeting all the supported Ubuntu series now.

You are right, it should go to the development release first, before SRUing the changes. I asked because it was not clear to me what series are affected.

[Andreas Hasenack (ahasenack)]

Hi Nathan,

I see that the discussion on the upstream PR[1] is still ongoing, and there isn't consensus yet.

I think it's best to put this on hold until a conclusion is reached, and then this can move forward. I'll therefore unsubscribe sponsors for now. Please subscribe again once a decision has been reached on how to proceed.

1. https://github.com/flatpak/xdg-desktop-portal-gtk/pull/447