Users on highlight ignore are completely ignored

Bug #735656 reported by Sandeep Kamath on 2011-03-15
72
This bug affects 13 people
Affects Status Importance Assigned to Milestone
xchat (Ubuntu)
Undecided
Unassigned

Bug Description

Binary package hint: xchat

the nicknames entered in 'Nicknames not to highlight' seem to get completely ignored.

This is happening on natty. Was working fine in maverick

I'm using a 64bit system, a fully up-to-date natty
package is xchat

summary: - Users on highlight ignore and completely ignored
+ Users on highlight ignore are completely ignored
Ondergetekende (kvdveer) wrote :

I think this is caused by 71_fix_nick_not_to_highlight.patch

On line 442, inbound_chanmsg:
 if (alert_match_word (from, prefs.irc_no_hilight))
  return; // <<<--- returning, without delivering the message

 if (is_hilight (from, text, sess, serv))
  hilight = TRUE;

I think this should be:
 if (!alert_match_word (from, prefs.irc_no_hilight) && is_hilight (from, text, sess, serv))
  hilight = TRUE;

Same is true for in inbound_privmsg

Ondergetekende (kvdveer) wrote :

My proposed change above is wrong.
Line 442-443 are entirely unneeded. Checking whether we should highlight for from nick is already performed in is_hilight, there is no need to do that in inbound_chanmsg. The same is true for the tail of inbound_privmsg.

I'll fix it, test it, and submit a substitution for patch 71.

Ondergetekende (kvdveer) wrote :

Simply undoing patch 71 fixes the bug; it does more harm than good. It doesn't do any good anyway.

Properly reimplementing patch 71 is not a triviality; it would require new text events, and the infrastructure to propagate those.

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in xchat (Ubuntu):
status: New → Confirmed

Problem still exists in oneiric. Please fix!

Rainer Müller (raimue) wrote :

This broken behavior is caused by the patch added as a result from LP #669046. As this makes the situation worse than before, please revert this patch.

Sandeep Kamath (sandeepkamath) wrote :

Its still happening in precise.

I rebuilt the package after removing patch 71 with some help from google. not sure if theres an easier way to do it, but this is how I did it:
*might be best if you made a separate dir and cd to it*
sudo apt-get install build-essential
sudo apt-get build-dep xchat
sudo apt-get source xchat
sudo patch -p0 -R -i xchat-2.8.8/debian/patches/71_fix_nick_not_to_highlight.patch
cd xchat-2.8.8/
sudo dpkg-buildpackage -us -uc -nc
sudo apt-get remove xchat xchat-common
sudo dpkg -i ../xchat*.deb

Hi,

12.04.2012 20:33, Sandeep Kamath kirjoitti:
> Its still happening in precise.
>
> I rebuilt the package after removing patch 71 with some help from google. not sure if theres an easier way to do it, but this is how I did it:
> *might be best if you made a separate dir and cd to it*
> sudo apt-get install build-essential
> sudo apt-get build-dep xchat
> sudo apt-get source xchat
> sudo patch -p0 -R -i xchat-2.8.8/debian/patches/71_fix_nick_not_to_highlight.patch
> cd xchat-2.8.8/
> sudo dpkg-buildpackage -us -uc -nc
> sudo apt-get remove xchat xchat-common
> sudo dpkg -i ../xchat*.deb
>

When I was on Ubuntu, I compiled XChat from svn source.

1. sudo apt-get install subversion
2. sudo apt-get build-dep xchat
3. svn co https://xchat.svn.sourceforge.net/svnroot/xchat xchat
4. cd svn
5. ./autogen.sh
6. ./configure
7. make
8. sudo make install
And then XChat is installed to /usr/local/bin. You might want to remove
the XChat, which is installed from Ubuntu repositories before doing this.

--
Mika Suomalainen
gpg --keyserver pool.sks-keyservers.net --recv-keys 4DB53CFE82A46728
Key fingerprint = 24BC 1573 B8EE D666 D10A AA65 4DB5 3CFE 82A4 6728

knivey (knives-dev) wrote :

this bug was reported in 2011 and it still isn't fixed in 2013? It would be nice if I didn't have to compile xchat..

Rubin (rubin) wrote :

Just a "me too" comment. Nicks listed in irc_no_hilight do not produce output when PRIVMSG a channel. (But show in the raw log).

This bug is very old. Could someone please git rm 71_fix_nick_not_to_highlight.patch so this can be resolved? No point in ubuntu making xchat worse than stock. Or state why not if there is a reason this hasn't been reverted?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers