Xchat and Xchat gnome lack plugin events for window close

Bug #722739 reported by Jeremy Nickurak on 2011-02-21
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
XChat-GNOME
Won't Fix
Wishlist
xchat (Ubuntu)
Wishlist
Unassigned
xchat-gnome (Ubuntu)
Wishlist
Unassigned

Bug Description

Binary package hint: xchat-gnome

Xchat and Xchat gnome lack plugin events for windows close. It would be nice if plugins (say, the indicator plugin) could catch the event and do something else (like minimize to the indicator).

Patch for xchat-gnome attached.

Jeremy Nickurak (nickurak) wrote :
description: updated
summary: - Xchat and Xchat gnome lack plugin events for client quit
+ Xchat and Xchat gnome lack plugin events for window close
description: updated
Changed in xchat-gnome:
importance: Unknown → Medium
status: Unknown → New
tags: added: patch
Changed in xchat-gnome:
importance: Medium → Wishlist
Changed in xchat (Ubuntu):
importance: Undecided → Wishlist
Changed in xchat-gnome (Ubuntu):
importance: Undecided → Wishlist
Jeremy Nickurak (nickurak) wrote :

So it doesn't get lost...

This bug is blocking https://bugs.launchpad.net/null/+bug/474906 , which is intended to make xchat-gnome and xchat behave more like empathy, "closing" to the messaging menu.

The attached patch for this and the attached patch for 474906 makes the problem go away in xchat-gnome.

Dustin Kirkland  (kirkland) wrote :

Hi Jeremy,

Is there an equivalent patch for xchat as well?

Changed in xchat (Ubuntu):
status: New → Incomplete
Changed in xchat-gnome (Ubuntu):
status: New → Triaged
Dustin Kirkland  (kirkland) wrote :

So I created a debdiff for Jeremy's patch, adding it to debian/patches and creating the changelog entry.

I declined to upload it, though, as I suspect that this is new functionality and probably requires a Feature Freeze Exception.

Jeremy Nickurak (nickurak) wrote :

Nothing for xchat-gtk currently. I spent a few minutes looking for the right place to hook into the window-close process, but didn't see an obvious spot.

Michael Terry (mterry) wrote :

Given Dustin's assessment, removing the sponsors team until a FFe is granted. (Jeremy, to do that, subscribe ~ubuntu-release and explain the case for an exception. If granted, re-subscribe ~ubuntu-sponsors.)

Bryce Harrington (bryce) wrote :

Hm. Looks like this slipped through the cracks and did not get into natty. I think instead of unsubbing sponsors pending a FFe it would have been better to just leave it in the queue until oneiric opened and then sponsor it in at that point.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xchat-gnome - 1:0.26.1+git20101206.557c940-0ubuntu6

---------------
xchat-gnome (1:0.26.1+git20101206.557c940-0ubuntu6) oneiric; urgency=low

  [ Jeremy Nickurak ]
  * debian/patches/10_xchat-gnome-close-event.patch: add events for window
    close, LP: #722739
 -- Dustin Kirkland <email address hidden> Mon, 14 Mar 2011 12:22:59 -0500

Changed in xchat-gnome (Ubuntu):
status: Triaged → Fix Released
Changed in xchat-gnome:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.