Create autopkgtests that test the daemon functionality

[Alessandro Astone]

We already have an autopkgtest that performs a few known regression tests, but are missing an actual test of the functionality that wsdd provides.

[Alessandro Astone (aleasto)]

This test verifies that the wsdd daemon in discovery mode is able
to discover WebService hosts announced on the local network.

One implementation detail to discuss is that I am using WSDD in "host" or "server" mode inside a container to announce another host on the local network; in the real world instead this would typically be a Windows machine on the same LAN.
We don't necessarily need to use the same WSDD version for that, nor the same Ubuntu version, nor it has to be an Ubuntu container; but perhaps it might be interesting to use the same WSDD package that is being tested in the autopkgtest. However I don't quite know how to do that, so if you think that this would be useful and have suggestions on how to get the .deb file of the package currently being tested let me know in the review!

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "wsdd-discovery-autopkgtest.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Paride Legovini (paride)]

As https://bugs.launchpad.net/ubuntu/+source/wsdd/+bug/2071692, I imagine this will all be submitted upstream?

[Alessandro Astone (aleasto)]

Indeed (assuming upstream wants it)

[Alessandro Astone (aleasto)]

Actually, this test currently relies on launching an `ubuntu-daily:$(lsb_release -cs)` lxc container, so wouldn't work on debian :/

[Sebastien Bacher (seb128)]

Indeed, that's likely that this test will not be something Debian wants to take...

I've pushed to a ppa for testing on the infra (since proxy and other factors can lead to differences with local testing) and it's failing

https://autopkgtest.ubuntu.com/results/autopkgtest-oracular-ubuntu-desktop-testing/oracular/amd64/w/wsdd/20240702_211344_9843c@/log.gz

Unsure why but https://wiki.ubuntu.com/ProposedMigration#autopkgtests has some debugging tips.

Could you perhaps also look at increasing the debug verbosity in the log?

[Alessandro Astone (aleasto)]

The current progress is that I got verbose output and can reproduce the failure in a local qemu by setting up an http proxy as described in the "I'm seeing a squid proxy? My tests behave differently there!" section of https://wiki.ubuntu.com/ProposedMigration#autopkgtests

Attaching the current debdiff for this test failure: https://autopkgtest.ubuntu.com/results/autopkgtest-oracular-aleasto-tests/oracular/amd64/w/wsdd/20240703_151256_a54f9@/log.gz

[Alessandro Astone (aleasto)]

Success!
The autopkgtest now passes in ppa too: https://autopkgtest.ubuntu.com/results/autopkgtest-oracular-aleasto-tests/oracular/amd64/w/wsdd/20240717_160225_dd052@/log.gz

[Benjamin Drung (bdrung)]

The autopkgtest shell script is quite readable. Before sponsoring, I have some small questions/remarks:
* You install wsdd in the container. Wouldn't it be safer to also specify the exact version (wsdd=<version>) of the package installed in the autopkgtest?
* Instead of using lsb-release, you can use VERSION_CODENAME from /etc/os-release.
* shellcheck has two complains that could be addressed

[Alessandro Astone (aleasto)]

seb already sponsored the upload, it's currently in oracular-proposed.

The wsdd version installed in the container should already be the one being tested, because we share the apt configuration with the host. But yea specifying the version wouldn't hurt :)

I'll take a look at shellcheck!

[Sebastien Bacher (seb128)]

Sorry, I forgot to update the bug when I uploaded that earlier. We will address the review feedback in the next upload