Revert " debian/presets.xml: Drop "w=" and "h=" from -vf scale." changes

[Doug McMahon]

Should have been done in 14.10 & wasn't. So please do so for 15.04

ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: winff 1.5.3-4ubuntu1
ProcVersionSignature: Ubuntu 3.16.0-24.32-generic 3.16.4
Uname: Linux 3.16.0-24-generic x86_64
ApportVersion: 2.15-0ubuntu2
Architecture: amd64
CurrentDesktop: Unity
Date: Sat Dec 6 10:11:13 2014
InstallationDate: Installed on 2014-11-16 (20 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Alpha amd64 (20141114)
PackageArchitecture: all
SourcePackage: winff
UpgradeStatus: No upgrade log present (probably fresh install)

[Paul Gevers (paul-climbing)]

Can you please explain why?

The automatic tests included in Winff don't show it is wrong, so you believe it is better to not have them?

[Doug McMahon (mc3man)]

They've done so in Debian (Sid
To remove this warning -
[scale @ 0x255a8e0] The <w>:<h>:flags=<flags> option syntax is deprecated. Use either <w>:<h>:<flags> or w=<w>:h=<h>:flags=<flags>.
At the end of the day probably doesn't matter? (vids are encoded anyway.

[Doug McMahon (mc3man)]

Just to note -
Both Debian & Ubuntu provide 'their' own presets file & mv upstreams to a .orig

[Paul Gevers (paul-climbing)]

On 06-12-14 16:53, Doug McMahon wrote:
> Both Debian & Ubuntu provide 'their' own presets file & mv upstreams to a .orig

Yes, I forgot that Ubuntu had reverted my changes for the last libav
change in one of the last uploads. Seems nobody cared to revert the
revert when libav was afterwards updated in Ubuntu. But, as you say, it
doesn't really harm. And with the next upload of Winff to Debian, I will
fix it in Ubuntu by a straight sync.

Paul

[Doug McMahon (mc3man)]

Thanks Paul, it does seem that at times lately the cracks have widened for stuff to fall through.

[Paul Gevers (paul-climbing)]

On 06-12-14 20:48, Doug McMahon wrote:
> Thanks Paul, it does seem that at times lately the cracks have widened
> for stuff to fall through.

Well, libav is quite large, so no wonder that sometimes Debian and
Ubuntu are deviating on that track for a (short) while. As I added an
autotester to Winff, Ubuntu had to change the package to let my latest
upload of Winff to be accepted in Ubuntu. Maybe the better choice would
have been to wait with syncing until libav was updated, because than it
would have been correct from that moment in time. (Asking the Debian
maintainer (me) would not have hurt).

Paul

[Doug McMahon (mc3man)]

While I wouldn't call it a flaw I did notice that winff creates a ~/.winff/presets.xml on first run. That file doesn't get updated when a user updates. So any fixes & or improvements to the presets never gets to the user unless they delete ~/.winff/presets.xml. Then a new one is copied from the install..

So *if this is the case* then maybe the Description or changelog(s) should mention

[Doug McMahon (mc3man)]

Though it would be useful I guess if there was some first run routine on installs or upgrades that causes an overwrite of presets.xml

[Paul Gevers (paul-climbing)]

On 08-12-14 00:35, Doug McMahon wrote:
> While I wouldn't call it a flaw I did notice that winff creates a
> ~/.winff/presets.xml on first run. That file doesn't get updated when a
> user updates. So any fixes & or improvements to the presets never gets
> to the user unless they delete ~/.winff/presets.xml. Then a new one is
> copied from the install..
>
> So *if this is the case* then maybe the Description or changelog(s)
> should mention

There is the "Restore Defaults" entry in the "edit" menu that copies the
new "defaults" to the user dir. It is nearly impossible to do this
automatically (and forbidden to do during upgrade). It could be done
ugly in Winff itself, but there was never much interest upstream.

Paul

[Paul Gevers (paul-climbing)]

Fixed when 1.5.3-6 was synced on 2015-09-06.