Comment 14 for bug 560795

Revision history for this message
In , Mrobinson-d (mrobinson-d) wrote :

Comment on attachment 77796
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77796&action=review

> WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:67
> + PangoFontDescription* pangoDescription = pango_font_description_from_string(face->family_name);
> + if (!pangoDescription)
> + return false;
> +

I'm pretty sure this won't work with custom fonts, since IIUC Pango just does a Fontconfig lookup. It makes more sense to bail out for fonts with no FcPattern.