Missing autopilot tests for javascript dialogs
Bug #1633040 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Andrew Hayzen |
Bug Description
webbrowser-app and webapp-container currently don’t have any automated tests for javascript dialogs.
The corresponding oxide APIs are:
- WebView.alertDialog
- WebView.
- WebView.
- WebView.
Related branches
lp:~ahayzen/webbrowser-app/fix-1633040-add-js-dialog-ap-tests
- Olivier Tilloy: Approve
- system-apps-ci-bot: Pending (continuous-integration) requested
-
Diff: 694 lines (+525/-6)10 files modifiedsrc/app/AlertDialog.qml (+2/-0)
src/app/BeforeUnloadDialog.qml (+3/-0)
src/app/ConfirmDialog.qml (+3/-0)
src/app/PromptDialog.qml (+4/-0)
tests/autopilot/webapp_container/tests/__init__.py (+9/-6)
tests/autopilot/webapp_container/tests/fake_servers.py (+34/-0)
tests/autopilot/webapp_container/tests/test_js_dialogs.py (+216/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+62/-0)
tests/autopilot/webbrowser_app/tests/http_server.py (+34/-0)
tests/autopilot/webbrowser_app/tests/test_js_dialogs.py (+158/-0)
Superseded
for merging
into
lp:webbrowser-app
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 5186 lines (+2471/-1203)51 files modified.bzrignore (+1/-0)
CMakeLists.txt (+3/-6)
debian/control (+1/-2)
make-snap.sh (+4/-0)
po/webbrowser-app.pot (+49/-43)
setup/gui/webbrowser-app.desktop.in (+27/-0)
snap/webbrowser-app.launcher (+10/-0)
snapcraft.yaml (+66/-0)
src/Ubuntu/CMakeLists.txt (+0/-8)
src/Ubuntu/Web/UbuntuWebContext.qml (+7/-1)
src/Ubuntu/Web/ua-overrides-desktop.js.in (+9/-9)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+11/-11)
src/app/AlertDialog.qml (+2/-0)
src/app/BeforeUnloadDialog.qml (+3/-0)
src/app/ChromeBase.qml (+5/-3)
src/app/ConfirmDialog.qml (+3/-0)
src/app/Downloader.qml (+3/-11)
src/app/PromptDialog.qml (+4/-0)
src/app/ThinProgressBar.qml (+3/-6)
src/app/WebViewImpl.qml (+2/-2)
src/app/config.h.in (+3/-2)
src/app/webbrowser/BookmarkOptions.qml (+25/-4)
src/app/webbrowser/Browser.qml (+112/-596)
src/app/webbrowser/BrowserTab.qml (+4/-3)
src/app/webbrowser/Chrome.qml (+30/-5)
src/app/webbrowser/DownloadDelegate.qml (+151/-149)
src/app/webbrowser/DownloadsPage.qml (+10/-2)
src/app/webbrowser/HistoryViewWithExpansion.qml (+67/-0)
src/app/webbrowser/NavigationBar.qml (+3/-11)
src/app/webbrowser/TabComponent.qml (+436/-0)
src/app/webbrowser/TabItem.qml (+16/-4)
src/app/webbrowser/TabsBar.qml (+51/-6)
src/app/webbrowser/downloads-model.cpp (+139/-80)
src/app/webbrowser/downloads-model.h (+7/-9)
src/app/webbrowser/history-model.cpp (+251/-152)
src/app/webbrowser/history-model.h (+64/-7)
src/app/webbrowser/webbrowser-app.qml (+28/-9)
src/app/webcontainer/Chrome.qml (+1/-0)
src/app/webcontainer/WebApp.qml (+2/-1)
tests/autopilot/webapp_container/tests/__init__.py (+9/-6)
tests/autopilot/webapp_container/tests/fake_servers.py (+34/-0)
tests/autopilot/webapp_container/tests/test_js_dialogs.py (+214/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+64/-2)
tests/autopilot/webbrowser_app/tests/http_server.py (+48/-0)
tests/autopilot/webbrowser_app/tests/test_history.py (+35/-0)
tests/autopilot/webbrowser_app/tests/test_js_dialogs.py (+156/-0)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+1/-8)
tests/unittests/downloads-model/tst_DownloadsModelTests.cpp (+262/-43)
tests/unittests/history-model/tst_HistoryModelTests.cpp (+3/-2)
tests/unittests/qml/CMakeLists.txt (+6/-0)
tests/unittests/qml/tst_TabsBar.qml (+26/-0)
Changed in webbrowser-app (Ubuntu): | |
status: | New → Triaged |
assignee: | nobody → Andrew Hayzen (ahayzen) |
importance: | Undecided → Medium |
Changed in webbrowser-app (Ubuntu): | |
status: | Triaged → In Progress |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+17. 04.20161024. 1-0ubuntu1
--------------- 04.20161024. 1-0ubuntu1) zesty; urgency=medium
webbrowser-app (0.23+17.
[ Andrew Hayzen ] container - alertDialog, beforeUnloadDialog, confirmDialog and
* Fix for issue where many tabs causes close button to overlap other
tabs (LP: #1473630)
* When page has started, stopped, redirected or errored clear cache for
history update - which prevents incorrect titles in being set
(LP: #1603835)
* Add autopilot tests javascript dialogs to webbrowser and
webapp-
promptDialog (LP: #1633040)
* Add user-agent override to display the new twitter mobile interface
(LP: #1577834)
[ Florian Boucault ]
* Improved startup time by 800ms by delaying QML compilation and making
it asynchronous
[ Olivier Tilloy ]
* Replace chromium version in UA overrides at runtime, not at build
time (LP: #1599695)
* Initial support for generating a snap package for webbrowser-app
(LP: #1629009)
* Do not persist references to incognito downloads on disk
(LP: #1625519)
* Increase test coverage (to 97.5%) for DownloadsModel (LP: #1534102)
* Various performance optimizations linked to load events
(LP: #1611680)
* Ensure a tab is loaded when re-opened (LP: #1632246)
* Fix drag'n'drop of bookmarks within the new tab view (LP: #1584868)
* Work around a limitation in the sound and microphone policy groups
to "fix" sound in yakkety an zesty (LP: #1632620)
-- Olivier Tilloy <email address hidden> Mon, 24 Oct 2016 13:51:59 +0000