Ubuntu
webbrowser-app package

Update the chromium version in the user agent

Bug #1565063 reported by Pat McGowan
108
This bug affects 21 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Bill Filler
Canonical System Image 12 "OTA12"
Oxide
Fix Released
Medium
Olivier Tilloy
Oxide branch-1.15
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy
Ubuntu ubuntu-16.10
Xenial
Fix Released
Undecided
Unassigned

Bug Description

We have never updated the version, which is 35, and now we are based on 49
While this may not have any impact it does reflect the core support we have, and its possible some sites may check it.

Ideally we would query oxide for this dynamically.

[Manual test case]
Open the browser and browse to http://whatsmyua.com.
Verify that the chromium version number in the UA string is a recent one (> 50), and not the previously hardcoded value of "35.0.1870.2".

See original description

Related branches

lp:~osomon/oxide/versions
Chris Coulson: Approve
Diff: 204 lines (+85/-5)
8 files modified
qt/core/api/oxideqglobal.cc (+13/-1)
qt/core/api/oxideqglobal.h (+5/-2)
qt/core/common/oxide_version.h.in (+23/-0)
qt/core/core.gyp (+18/-0)
qt/qmlplugin/oxide.qmltypes (+2/-0)
qt/quick/api/oxideqquickglobal.cc (+9/-1)
qt/quick/api/oxideqquickglobal_p.h (+7/-1)
qt/tests/qmltests/api/tst_OxideGlobal.qml (+8/-0)
lp:~osomon/webbrowser-app/ua-chromium-version-from-oxide
PS Jenkins bot: Needs Fixing (continuous-integration)
system-apps-ci-bot: Needs Fixing (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 43 lines (+4/-7)
2 files modified
debian/control (+1/-1)
src/Ubuntu/Web/UserAgent02.qml (+3/-6)
lp:~oxide-developers/oxide/packaging.xenial.next
lp:~oxide-developers/oxide/packaging.trusty.next
lp:~oxide-developers/oxide/packaging.xenial
lp:~oxide-developers/oxide/packaging.wily
lp:~oxide-developers/oxide/packaging.trusty
lp:~oxide-developers/oxide/packaging.xenial.overlay
lp:~oxide-developers/oxide/packaging.vivid.overlay
lp:~oxide-developers/oxide/packaging.yakkety
lp:~osomon/webbrowser-app/use-oxide-1.15-apis
system-apps-ci-bot: Needs Fixing (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 295 lines (+126/-21)
6 files modified
debian/control (+2/-2)
src/Ubuntu/Web/UbuntuWebView02.qml (+22/-4)
src/Ubuntu/Web/UserAgent02.qml (+2/-5)
src/app/webbrowser/Browser.qml (+36/-1)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+49/-1)
tests/autopilot/webbrowser_app/tests/test_touchselection.py (+15/-8)
lp:~osomon/webbrowser-app/xenial-sru-1
Ubuntu Phablet Team: Pending requested
Diff: 905 lines (+274/-86)
27 files modified
debian/changelog (+15/-0)
debian/control (+2/-1)
src/Ubuntu/CMakeLists.txt (+4/-0)
src/Ubuntu/Web/UserAgent02.qml (+4/-10)
src/Ubuntu/Web/plugin.cpp (+7/-0)
src/Ubuntu/Web/ua-overrides-desktop.js (+5/-0)
src/Ubuntu/Web/ua-overrides-mobile.js (+6/-1)
src/app/browserapplication.cpp (+32/-24)
src/app/browserapplication.h (+1/-2)
src/app/config.h.in (+0/-1)
src/app/single-instance-manager.cpp (+39/-3)
src/app/single-instance-manager.h (+1/-1)
src/app/webbrowser/Browser.qml (+21/-15)
src/app/webbrowser/BrowserTab.qml (+3/-2)
src/app/webbrowser/NavigationBar.qml (+1/-2)
src/app/webbrowser/webbrowser-app.cpp (+1/-1)
src/app/webcontainer/WebApp.qml (+1/-0)
src/app/webcontainer/WebViewImplOxide.qml (+28/-14)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+32/-1)
src/app/webcontainer/webapp-container.h (+1/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webapp_container/tests/__init__.py (+4/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+29/-0)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+19/-0)
tests/autopilot/webapp_container/tests/test_saml_url_patterns.py (+9/-3)
tests/unittests/single-instance-manager/tst_SingleInstanceManagerTests.cpp (+4/-4)
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Olivier Tilloy (osomon) wrote :

In oxide, the CHROME_VERSION_STRING token contains the chromium version that it’s built against, so we could possibly expose that to the QML API as a readonly property of OxideQQuickGlobal.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Related: bug #1466427.

tags: added: ua-string
Olivier Tilloy (osomon)
Changed in oxide:
status: New → Confirmed
assignee: nobody → Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
Changed in oxide:
importance: Undecided → Medium
Olivier Tilloy (osomon)
Changed in oxide:
milestone: none → branch-1.15
status: Confirmed → In Progress
Olivier Tilloy (osomon)
Changed in oxide:
status: In Progress → Fix Released
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Olivier Tilloy (osomon)
Changed in canonical-devices-system-image:
status: New → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
importance: Undecided → Medium
assignee: nobody → Bill Filler (bfiller)
milestone: none → 12
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
milestone: none → ubuntu-16.10
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Olivier Tilloy (osomon)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Pat, or anyone else affected,

Accepted webbrowser-app into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/webbrowser-app/0.23+16.04.20161028-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in webbrowser-app (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Tested and verified in an up-to-date xenial amd64 VM, with webbrowser-app 0.23+16.04.20161028-0ubuntu1.

I browsed to whatsmyua.com, and the chromium version advertised in the UA string was 54.0.2840.71.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Pat, or anyone else affected,

Accepted webbrowser-app into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/webbrowser-app/0.23+16.04.20161028-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Olivier Tilloy (osomon) wrote :

Tested and verified in an up-to-date xenial amd64 VM, with webbrowser-app 0.23+16.04.20161028-0ubuntu2.

I browsed to whatsmyua.com, and the chromium version advertised in the UA string was 55.0.2883.75.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20161028-0ubuntu2

---------------
webbrowser-app (0.23+16.04.20161028-0ubuntu2) xenial; urgency=medium

  * SRU for selected bug fixes:
    - LP: #1565055: support for google hangouts
    - LP: #1573017: SAML detection logic broken in webapp container
    - LP: #1572673: invalid variable access error in webapp container
    - LP: #1466427: dynamic Ubuntu version in default UA string
    - LP: #1576639: fine-tune the custom memory-pressure handler
    - LP: #1581025: secure connection icon not showing
    - LP: #1580290: only load the current tab when the session is restored
    - LP: #1577806: browser and container open under the same instance
    - LP: #1565063: dynamic Chromium version in default UA string

 -- Olivier Tilloy <email address hidden> Fri, 28 Oct 2016 09:17:33 +0000

Changed in webbrowser-app (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for webbrowser-app has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.