4 autopilot test failures (related to ESC key) on desktop
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
I just upgraded my desktop machine from wily to xenial, and 4 autopilot tests are now consistently failing:
webbrowser_
webbrowser_
webbrowser_
webbrowser_
All of them involve pressing the ESC key and expecting something to happen, which is where they fail. I suspect something changed in the UITK (it might have gained default handling of ESC for various components, which overrides our custom implementation?). Needs further investigation.
Related branches
- ubuntu-sdk-build-bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 106 lines (+47/-4)3 files modifiedsrc/Ubuntu/Components/1.3/TextArea.qml (+8/-2)
src/Ubuntu/Components/1.3/TextField.qml (+7/-1)
tests/unit_x11/tst_components/tst_textinput_common13.qml (+32/-1)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 76 lines (+17/-12)2 files modifiedsrc/app/webbrowser/BookmarkOptions.qml (+2/-2)
src/app/webbrowser/Browser.qml (+15/-10)
Changed in webbrowser-app (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → Zoltan Balogh (bzoltan) |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
At least 3 of the 4 failures appear to be caused by a recent change in the UITK (the fix for bug #1523828). Keys.onEscapePr essed accepts the event by default, so it’s not bubbled up, whereas it should if there is no popover to close.