Get rid of the formFactor context property
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
The Ubuntu.Web plugin exposes a 'formFactor' context property, whose value is either "mobile" or "desktop".
It relies on QGuiApplication
Form factor is not even a concept that should be used for dynamic layout of the application.
This property is not (and has never been) publicly documented, so it should be fine to remove it.
In most cases, where the value of that property was used, we can use one of the following:
- wide VS narrow mode
- presence of a mouse/touchpad/
- can a given QML plugin be dynamically loaded
Related branches
- Alexandre Abreu (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 1105 lines (+475/-141)22 files modifiedREADME (+0/-5)
debian/control (+1/-0)
src/Ubuntu/Web/UbuntuWebView02.qml (+2/-2)
src/Ubuntu/Web/plugin.cpp (+1/-38)
src/app/BrowserView.qml (+2/-0)
src/app/CMakeLists.txt (+7/-1)
src/app/browserapplication.cpp (+42/-14)
src/app/meminfo.cpp (+137/-0)
src/app/meminfo.h (+65/-0)
src/app/webbrowser/Browser.qml (+69/-31)
src/app/webbrowser/BrowserTab.qml (+3/-0)
src/app/webbrowser/Chrome.qml (+3/-1)
src/app/webbrowser/SettingsPage.qml (+1/-20)
src/app/webbrowser/TabItem.qml (+9/-8)
src/app/webbrowser/TabsBar.qml (+4/-1)
src/app/webbrowser/webbrowser-app.cpp (+2/-0)
src/app/webcontainer/WebApp.qml (+3/-2)
src/app/webcontainer/WebViewImplOxide.qml (+6/-11)
tests/autopilot/webbrowser_app/tests/__init__.py (+2/-7)
tests/unittests/CMakeLists.txt (+1/-0)
tests/unittests/meminfo/CMakeLists.txt (+15/-0)
tests/unittests/meminfo/tst_MemInfoTests.cpp (+100/-0)
- David Barth (community): Approve
-
Diff: 83 lines (+15/-19)2 files modifiedwebapp-googleplus/lib/WebViewImpl.qml (+9/-3)
webapp-googleplus/webview-override.qml (+6/-16)
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww08-2016 |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → High |
| status: | New → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Released |
| status: | Fix Released → Fix Committed |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Fix Released → New |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → New |
| Changed in canonical-devices-system-image: | |
| status: | New → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Penk Chen (penk) wrote | #2 |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
[ CI Train Bot ]
* Resync trunk.
[ Olivier Tilloy ]
* Remove the 'formFactor' context property, and replace all its uses
by more meaningful conditions. (LP: #1446904, #1542375)
* Update translation template.
* Work around a bug in the UITK that prevents touch scrolling to the
left of the address bar by ensuring that the x coordinate of the
text field is an integer. (LP: #1546346)
* Work around bug #1546677 (UITK), by destroying the bookmark options
popover instead of hiding it. (LP: #1546627, #1546677)
-- Olivier Tilloy <email address hidden> Tue, 23 Feb 2016 11:24:49 +0000