Shortcuts still active in settings page

Bug #1524353 reported by Michael Sheldon on 2015-12-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Medium
Bill Filler
webbrowser-app (Ubuntu)
Medium
Olivier Tilloy

Bug Description

Steps to reproduce

1) Open a couple of new tabs

2) Go to the settings page

3) Press Ctrl-W

4) Close the settings page

Expected result

All the tabs you opened should still be there

Actual result

A tab was closed in the background when you pressed Ctrl-W

Related branches

Olivier Tilloy (osomon) on 2015-12-09
Changed in webbrowser-app (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Olivier Tilloy (osomon) wrote :

I think this is a regression introduced by https://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/revision/1280.

The Chrome instance used to be parented to a FocusScope which wasn’t visible when the settings page was, but it was moved out of that focus scope. The relevant keyboard shortcuts are disabled when the chrome isn’t visible, but that condition is not valid any longer, it needs to be updated.

Olivier Tilloy (osomon) on 2015-12-09
Changed in webbrowser-app (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Olivier Tilloy (osomon)
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Bill Filler (bfiller)
milestone: none → ww02-2016
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151222.1-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151222.1-0ubuntu1) xenial; urgency=medium

  * Add keyboard shorcuts for 'next' (Ctrl+G) and 'previous'
    (Ctrl+Shift+G) while in find-in-page mode. (LP: #1522152)
  * Do not allow interacting with tabs and the chrome while the settings
    page is shown. (LP: #1524353)
  * Fix a crash when clearing the navigation history while the new tab
    view is open. (LP: #1525937)
  * Fix deleting multiple domains from the history view. Add unit tests
    for the HistoryView component. (LP: #1527144)
  * Fix some obvious issues in PreviewManager. (LP: #1519019)
  * Fix the tab preview sometimes covering the tab chrome, in the tabs
    view. Offset tab previews by 1px to cover the semi-transparent
    horizontal line at the bottom of the tab chrome asset. (LP:
    #1520624)
  * Recognize openoffice and MS-office file formats as documents, now
    that the document viewer app knows how to render them. (LP:
    #1523452)
  * Update translation template.
  * Use the screen size (diagonal in millimeters) to determine which
    default UA string and which UA overrides to use. An empirical
    threshold of 19cm is being used, it is subject to further
    adjustments. (LP: #1504084)

 -- Olivier Tilloy <email address hidden> Tue, 22 Dec 2015 18:15:54 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers