Tab previews are deleted while still in active list
Bug #1519019 reported by
Pat McGowan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy |
Bug Description
v174 on mx4
I was watching the contents of the .cache/
Select a tab from the list (happened to be blank)
The web page is loaded
The file containing preview for the previously active tab, top in the list, is deleted from the disk.
The tab is still shown in the active list but now its blank.
I cannot reproduce this every time.
Adding a new tab subsequently crashed the browser
Related branches
lp:~osomon/webbrowser-app/tab-preview-fixes
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 33 lines (+5/-4)2 files modifiedsrc/app/webbrowser/Browser.qml (+3/-3)
src/app/webbrowser/BrowserTab.qml (+2/-1)
description: | updated |
description: | updated |
Changed in canonical-devices-system-image: | |
milestone: | none → ww02-2016 |
assignee: | nobody → Bill Filler (bfiller) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in webbrowser-app (Ubuntu): | |
importance: | Undecided → High |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | New → Confirmed |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
> The file containing preview for the previously active tab, top in the
> list, is deleted from the disk.
There should never be a preview for the current tab (unless it’s also a top site). In the tabs list view, the first tab is a special case, it shows the live webview, not a cached capture. When selecting a different tab, a capture is taken for the tab that was current (so the opposite of what you’re describing should be happening).
I found some obvious issues with the handling of previews, and fixed them in the linked branch.
I’m not sure how to reproduce the issue you’re describing though, so I can’t guarantee it’s fixed by my branch (which, regardless, improves the current situation).