Use the new UITK’s PageHeader component
Bug #1511137 reported by
Olivier Tilloy
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy | ||
Bug Description
Since version 1.3.1688+
Using this will allow us to get rid of some custom code in webbrowser-app.
Related branches
lp:~osomon/webbrowser-app/browserpage
- Olivier Tilloy: Approve
- system-apps-ci-bot: Needs Fixing (continuous-integration)
-
Diff: 2190 lines (+688/-845)17 files modifiedsrc/app/webbrowser/BookmarksView.qml (+5/-48)
src/app/webbrowser/BookmarksViewWide.qml (+6/-49)
src/app/webbrowser/Browser.qml (+12/-21)
src/app/webbrowser/BrowserPage.qml (+79/-0)
src/app/webbrowser/BrowserPageHeader.qml (+0/-119)
src/app/webbrowser/DownloadsPage.qml (+99/-101)
src/app/webbrowser/HistoryView.qml (+52/-105)
src/app/webbrowser/HistoryViewWide.qml (+94/-167)
src/app/webbrowser/SettingsPage.qml (+102/-162)
tests/autopilot/webbrowser_app/emulators/browser.py (+16/-14)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+1/-1)
tests/autopilot/webbrowser_app/tests/test_settings.py (+2/-2)
tests/unittests/qml/tst_BookmarksView.qml (+6/-6)
tests/unittests/qml/tst_BookmarksViewWide.qml (+7/-7)
tests/unittests/qml/tst_BrowserPage.qml (+151/-0)
tests/unittests/qml/tst_HistoryView.qml (+11/-11)
tests/unittests/qml/tst_HistoryViewWide.qml (+45/-32)
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → Medium |
| milestone: | none → 12 |
| status: | New → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
* Display the currently hovered hyperlink’s target URL in an overlay.
(LP: #1499775)
* Introduce a BrowserPage type for consistency between all pages, and
use the UITK Page and PageHeader types. (LP: #1511137)
* Keep the securityStatus property of the address bar always in sync
with the current webview. (LP: #1581025)
* Minor packaging updates.
* Only load the current tab when the session is restored. (LP:
#1580290)
* Set a minimum width and height on the browser window. (LP: #1581259)
* Use QStringLiteral instead of QString in config.h.in.
-- Olivier Tilloy <email address hidden> Thu, 19 May 2016 18:39:35 +0000