'find in page' fails to focus address bar every second time

Bug #1508130 reported by Brendan Donegan on 2015-10-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Bill Filler
webbrowser-app (Ubuntu)
High
Ugo Riboni

Bug Description

Steps to reproduce:

1. Open the Web Browser
2. Open the Drawer widget on the top right corner
3. Select Find In Page
4. Confirm the address bar is focused (in find in page mode) and the keyboard appears
5. Press Back to return to normal browsing view
6. Open the Drawer widget again
7. Select Find In Page again

Expected result:

The address bar (in find in page mode) is focused and the keyboard appears

Actual result:

Find in page mode is active but the address bar is not focused and the keyboard does not appear

current build number: 152
device name: krillin
channel: ubuntu-touch/rc-proposed/bq-aquaris.en
last update: 2015-10-18 22:11:48
version version: 152
version ubuntu: 20151016
version device: 20150821-736d127
version custom: 20150925-901-35-40-vivid

Related branches

Olivier Tilloy (osomon) on 2015-10-20
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Ugo Riboni (uriboni)
Olivier Tilloy (osomon) on 2015-10-23
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Olivier Tilloy (osomon) wrote :

After a bit of investigation, I understand what’s going on: the Chrome instance is a focus scope that proxies focus requests to the address bar, and it’s itself contained in a FocusScope. Setting focus to true on chrome doesn’t imply that the active focus will change, it only guarantees that the next time the active focus is set on the enclosing focus scope, chrome will receive it.

So the current code that does "chrome.focus = true" in the onTriggered handler of the "find in page" action should really do "chrome.forceActiveFocus()".

Changed in canonical-devices-system-image:
importance: Undecided → High
status: New → Confirmed
status: Confirmed → In Progress
assignee: nobody → Bill Filler (bfiller)
milestone: none → ww46-2015
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151103-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151103-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Update translation template.

  [ Ugo Riboni ]
  * Fix a bug preventing in some cases the address bar from getting
    focus when entering find in page mode. Also correctly hide the left
    hand side icons when in find in page mode. (LP: #1508130)
  * Focus the page when opening links with target="_blank". (LP:
    #1505724)
  * Prevent the address bar from being cleared when the actual url
    changes and the user has already started typing. (LP: #1487713)
  * Update the user script to remove the Facebook app banner. (LP:
    #1352783)
  * Use AbstractButton to handle some tab interactions so that haptics
    are used on touch. (LP: #1505725)

 -- Olivier Tilloy <email address hidden> Tue, 03 Nov 2015 11:56:19 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers