In history view, pressing delete key should remove current date/history entry
Bug #1484562 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Arthur Mello | ||
Bug Description
[DESKTOP ONLY]
In the new wide history view layout, pressing the Delete key doesn’t have any effect.
For consistency with the new wide new tab view (where pressing delete either hides the currently selected top site or removes the currently selected bookmark), pressing delete should remove the currently selected history entry if active focus is on the right panel, and it should remove all entries for the currently selected date if active focus is on the left panel.
Related branches
lp:~artmello/webbrowser-app/webbrowser-app-fix_1484562
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 359 lines (+148/-53)6 files modifiedsrc/app/webbrowser/Browser.qml (+0/-1)
src/app/webbrowser/HistoryViewWide.qml (+60/-36)
src/app/webbrowser/history-model.cpp (+31/-0)
src/app/webbrowser/history-model.h (+2/-0)
tests/unittests/history-model/tst_HistoryModelTests.cpp (+11/-0)
tests/unittests/qml/tst_HistoryViewWide.qml (+44/-16)
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → Invalid |
| status: | Invalid → In Progress |
| description: | updated |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #1 |
| Changed in canonical-devices-system-image: | |
| status: | New → Fix Committed |
| milestone: | none → ww40-2015 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Medium |
| assignee: | nobody → Bill Filler (bfiller) |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
webbrowser-app (0.23+15.
[ Alexandre Abreu ]
* Fix webapp name logic (LP: #1473472)
[ Arthur Mello ]
* Add support for removing history entries with delete key in
HistoryViewWide (LP: #1484562)
[ CI Train Bot ]
* New rebuild forced.
[ Olivier Tilloy ]
* Remove an old workaround for an issue that was fixed since then in
the content hub and that caused the file picker to accept the
selected file twice.
[ Ugo Riboni ]
* Merge two url utility files into one, since they had no reason for
being separate. Add unit tests for some of the functions that had
none.