Ubuntu
webbrowser-app package

Support for <meta name="theme-color" ... tag

Bug #1477674 reported by zubozrout
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Wishlist
David Barth
Canonical System Image ww02-2016 "ota9"
Ubuntu UX
Fix Released
Low
Jouni Helminen
webapps-sprint
Fix Released
Medium
Alexandre Abreu
webapps-sprint sprint-17
webbrowser-app (Ubuntu)
Fix Released
Wishlist
Alexandre Abreu

Bug Description

Hi,
Google Chrome on Android introduced this nice colour feature some time ago and I see all sites all over the world slowly adopting it, including ubuntu.com.

I already asked a question about this some time ago and I was recommended to report a bug: https://answers.launchpad.net/ubuntu/+source/webbrowser-app/+question/267783

So the thing is to support this meta tag <meta name="theme-color" content="#DD4814"> and change header colour accordingly. It would be a great addition to Ubuntu and what's more, it is simple to implement.

What do you think about the idea?
Thank you very much for your opinions.

Related branches

lp:~abreu-alexandre/webbrowser-app/theme-color-meta-detection
Alberto Mardegan (community): Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 322 lines (+211/-2)
8 files modified
src/app/ChromeBase.qml (+2/-0)
src/app/webcontainer/CMakeLists.txt (+1/-1)
src/app/webcontainer/WebApp.qml (+5/-0)
src/app/webcontainer/WebViewImplOxide.qml (+43/-1)
src/app/webcontainer/WebappContainerWebview.qml (+8/-0)
src/app/webcontainer/webapp-specific-page-metadata-collector.js (+56/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+47/-0)
tests/autopilot/webapp_container/tests/test_page_meta_collector.py (+49/-0)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Related documentation: https://github.com/whatwg/meta-theme-color.

Changed in webbrowser-app (Ubuntu):
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

This is very much related (infrastructure wise) to some work that is being done to support installable webapps & "webapp-capable" meta tags.

https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1411726

Changed in webbrowser-app (Ubuntu):
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Chromium version 46 beta improves on the support for the color meta tag and allows the color-theme bit to be listed in the webapp manifest json file.

http://blog.chromium.org/2015/09/chrome-46-beta-flexible-animations-and.html

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Adding ubuntu-ux to the bug to have their feedback on that

Magdalena Mirowicz (magdalena-mirowicz)
Changed in ubuntu-ux:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Jouni Helminen (jounihelminen)
Revision history for this message
Jouni Helminen (jounihelminen) wrote :

Discussed this, it would be nice for the mobile browser but once we have tabs on the UI it might be weird. Can we do it just when the viewport is small enough for not showing tabs?

Changed in ubuntu-ux:
status: Triaged → In Progress
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

@Jouni: well this is not really associated w/ the browser, and imo would be weird when switching tabs (the flickering). The context is more static with a webapp installed for a website that advertises those capabilities, and would only affect the webapp ui,

The trick is: affect in which way? it could be as simple as affecting the background of the address bar is any is shown,

Alexandre Abreu (abreu-alexandre)
Changed in webapps-sprint:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Alexandre Abreu (abreu-alexandre)
milestone: none → sprint-17
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → In Progress
importance: Undecided → Wishlist
assignee: nobody → David Barth (dbarth)
milestone: none → ww02-2016
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20160108.1-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20160108.1-0ubuntu1) xenial; urgency=medium

  * Handle theme_color page metainformation. (LP: #1477674)

 -- Alexandre Abreu <email address hidden> Fri, 08 Jan 2016 19:33:34 +0000

Changed in webbrowser-app (Ubuntu):
status: Triaged → Fix Released
Alexandre Abreu (abreu-alexandre)
Changed in webapps-sprint:
status: In Progress → Fix Released
Changed in ubuntu-ux:
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.