[browser] Bookmark Link action from popup menu should invoke bookmark folder UI or provide some sort of feedback that action succeeded

Bug #1477314 reported by Bill Filler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Released
Medium
James Mulholland
webbrowser-app (Ubuntu)
Fix Released
Medium
Ugo Riboni

Bug Description

Now that we have a UI for creating bookmark folders, this should be invoked when pressing "bookmark link" from context menu. Currently no ui is shown and there is no feedback that the action succeeded.

--- --- --- ---
UX Comment:

I agree with Bill's suggestion:
"...we should basically use the same UI components that provides a field for name, save in, and new folder and just not display it beneath the star or light up the star."

We should also position the components to appear in the same place as the contextual options menu that allows links to be bookmarked.

Additionally;
- Once a link has been bookmarked (either through the contextual options or address bar), the option to 'Bookmark link' should no longer be present in the contextual options menu associated with that link.
- Upon visiting a link bookmarked via contextual options, the star within the address-bar should appear 'lit' (which doesn't appear to currently be the case).

Tags: convergence

Related branches

Revision history for this message
Olivier Tilloy (osomon) wrote :

Need some guidance from design on this. I don’t think we can re-use the same popup that shows up when bookmarking the current page, that would be misleading as this popup points to the star in the address bar, which shouldn’t turn orange when bookmarking a different page.

summary: - Bookmark Link action from popup menu should invoke bookmark folder UI or
- provide some sort of feedback that action succeeded
+ [browser] Bookmark Link action from popup menu should invoke bookmark
+ folder UI or provide some sort of feedback that action succeeded
Changed in ubuntu-ux:
status: New → Triaged
assignee: nobody → James Mulholland (jamesjosephmulholland)
importance: Undecided → Medium
Revision history for this message
Bill Filler (bfiller) wrote :

right we shouldn't do that, but we should basically use the same UI components that provide a field for name, save in, and new folder and just not display it beneath the star or light up the star. So it might not be exactly the same popup but we should be able to refactor the code such that it can be invoked from popup and address bar, or from a link and it will do the right thing.

Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
description: updated
Changed in ubuntu-ux:
status: Triaged → Fix Committed
Ugo Riboni (uriboni)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Ugo Riboni (uriboni)
Ugo Riboni (uriboni)
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150903.1-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150903.1-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Michael Terry ]
  * Use the Ubuntu/Canonical search tag when searching with DuckDuckGo.
    (LP: #1490283)

  [ Olivier Tilloy ]
  * Display a friendly message when the renderer process crashes or is
    killed. This adds a runtime dependency for webbrowser-app-autopilot
    on python3-psutil. (LP: #1375272)
  * Do not display the bottom edge hint on tablets in wide mode. (LP:
    #1488995)
  * Update translation template.

  [ Riccardo Padovani ]
  * Don't store urls with status different from 2xx in the history. (LP:
    #1244335)
  * Don't store urls with status different from 2xx in the history. (LP:
    #1244335)

  [ Ugo Riboni ]
  * Allow choosing the bookmark folder when bookmarking a link from the
    context menu. Disable the bookmark option when the link is already
    bookmarked. Ensure the bookmark star state in the chrome is always
    consistent with the bookmarked state of the current webview URL.
    (LP: #1477314)
  * Properly reset focus when the current tab changes (including as a
    result of closing tabs). (LP: #1488470)

 -- CI Train Bot <email address hidden> Thu, 03 Sep 2015 09:46:35 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers