[browser] Should add a popup menu on the tab itself to open a new tab to the right of it (like chrome)
Bug #1477312 reported by
Bill Filler
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Ugo Riboni | ||
Bug Description
There is no way currently to open a tab to the right of an existing tab. Pressing the "+" button always adds it at the end. It's desirable to be able to add next to the current tab. Chrome solves that by putting a context menu on the tab itself with "New Tab" option on it. We should consider the same.
--- --- --- --- ---
UX Comment:
I agree that Bill's suggested subset is the minimum we'd require for this useful feature. I have added a page to the spec accordingly:
Related branches
lp:~uriboni/webbrowser-app/tab-context-menu
- Olivier Tilloy: Disapprove
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Riccardo Padovani (community): Needs Fixing
-
Diff: 842 lines (+455/-96)8 files modifiedsrc/app/webbrowser/Browser.qml (+6/-5)
src/app/webbrowser/Chrome.qml (+2/-2)
src/app/webbrowser/TabsBar.qml (+42/-3)
src/app/webbrowser/tabs-model.cpp (+53/-21)
src/app/webbrowser/tabs-model.h (+2/-0)
tests/unittests/qml/qml_tree_helpers.js (+43/-0)
tests/unittests/qml/tst_TabsBar.qml (+137/-8)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+170/-57)
lp:~osomon/webbrowser-app/uriboni-tab-context-menu
- Ugo Riboni (community): Approve
- Riccardo Padovani (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 1057 lines (+527/-130)12 files modifiedsrc/app/webbrowser/Browser.qml (+6/-5)
src/app/webbrowser/BrowserTab.qml (+8/-0)
src/app/webbrowser/Chrome.qml (+2/-2)
src/app/webbrowser/TabItem.qml (+28/-14)
src/app/webbrowser/TabsBar.qml (+62/-28)
src/app/webbrowser/tabs-model.cpp (+42/-12)
src/app/webbrowser/tabs-model.h (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-3)
tests/unittests/qml/qml_tree_helpers.js (+42/-0)
tests/unittests/qml/tst_BrowserTab.qml (+17/-0)
tests/unittests/qml/tst_TabsBar.qml (+146/-8)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+169/-58)
| summary: |
- [convergence] Should add a popup menu on the tab itself to open a new - tab to the right of it (like chrome) + [browser] Should add a popup menu on the tab itself to open a new tab to + the right of it (like chrome) |
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → James Mulholland (jamesjosephmulholland) |
Revision history for this message
| Bill Filler (bfiller) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in ubuntu-ux: | |
| importance: | Medium → High |
| description: | updated |
| Changed in ubuntu-ux: | |
| status: | Triaged → Fix Committed |
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Ugo Riboni (uriboni) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ux: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ux: | |
| importance: | High → Medium |
To post a comment you must log in.
@james
Could you provide some feedback about this? My vote is to basically support a subset of what Chrome displays on it's right click menu on tabs. I think the following are the most important:
New tab
Reload
Close tab