Bracketed paste should be per-terminal [PATCH]

[Yury V. Zaytsev]

[Impact]

Bracketed paste mode (\e[?2004h) should be per-terminal (as it is for xterm), not per-screen. This was fixed upstream for vte3 0.36.2, however Trusty ships vte3 0.34.2 and it didn't make it:

https://bugzilla.gnome.org/show_bug.cgi?id=729533

This bug is causing annoying garbage appended to every paste in mc:

https://www.midnight-commander.org/ticket/3207

I have backported the fix to Trusty, tested it in my PPA and would appreciate if someone could sponsor an upload in updates, since Trusty is LTS after all.

[Test Case]

Select some text ("test") and copy it into the clipboard buffer. After that, install mc if you don't have it already and start it:

    sudo apt-get install mc
    mc

Press CTRL+O to swap the panels, right click with the mouse button and pick "Paste" from the context menu. You will see that "~0test~1" is pasted into the console instead of "test" as it should be.

For more details, see the bug report on mc bug tracker referenced above.

[Regression Potential]

The patch is taken from the vte3 bug tracker; it has been in trunk for more than a year and is contained in vte3 0.36.2+ releases. Nobody has reported any problems caused by this change so far...

[Iain Lane (laney)]

I uploaded this, thanks!

[Egmont Koblinger (egmont-gmail)]

@zyv, @laney: On one hand I'm glad you released a fix; on the other hand there are several other important patches that would be safe and easy to cherry-pick, e.g. see lp bug 1433206, but there were other fixes for segfaults and such.

Let me know if you're interested in coming up with another vte release, I'm happy to help locating about a dozen of the most important changes that are also safe to apply.

[Yury V. Zaytsev (zyv)]

Hi Egmont,

In this case I was simply scratching my personal itch: this bug is making mc unusable for me at work, where I'm running Ubuntu Trusty. I haven't run in any issues quite as bad as this one.

Having this said, if 1) Iain will be willing to make another upload and 2) you will be willing to post vetted patches, I can try to come up with a tested debdiff...

--Yury.

[Chris J Arges (arges)]

Hello Yury, or anyone else affected,

Accepted vte3 into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vte3/1:0.34.9-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris J Arges (arges)]

Accepted this into trusty-proposed. Let's verify this first, and get those other patches in for the next update.
Thanks!

[Yury V. Zaytsev (zyv)]

Hi,

I've been running the package from trusty-proposed for about a week and can confirm that it fixes the problem for me; I also didn't encounter any regressions in that time.

Many thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package vte3 - 1:0.34.9-1ubuntu2

---------------
vte3 (1:0.34.9-1ubuntu2) trusty; urgency=medium

  * Add 95_bracketed_paste.patch (LP: #1506166)

 -- <email address hidden> (Yury V. Zaytsev) Tue, 13 Oct 2015 14:41:42 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for vte3 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Yury V. Zaytsev (zyv)]

Excellent!

So, Egmont, if you are still interested in support for Trusty, then you can create a new bug and list the most important bugfixes to be backported there. If you subscribe me to it, I will try to have a look and prepare a debdiff, and then we can again see if it can land into updates.

Otherwise, I'm a happy camper now :-)

[Markus Birth (mbirth)]

I have this problem in Ubuntu 15.10 and Guake Terminal 0.8.4 (from the WebUpd8 PPA, as recommended on their homepage).

[Egmont Koblinger (egmont-gmail)]

Guake uses the ancient and unmaintained gtk2-based vte. Ideally they should rewrite their code against gtk3 and hence a much newer vte.

[Alexander Drozdov (adrozdoff)]

Vte that uses for GTK+ 2.0 based terminals also affected. XFCE termianl, Mate Terminal uses libvte9 and affected too. Both Trusty and Xenials still ships vte 0.28.2.

Note, upstream bug report contains patch based on 0.28.2, so it can be simple adopted for current package.

[Alexander Drozdov (adrozdoff)]

Patch from Gnome bug tracker for 0.28.2 adopted to use with exists patches in `vte` source. It should be applied last in patches sequence.

[Alexander Drozdov (adrozdoff)]

Adopted patch for Xenial VTE package. Works with existing patches.

I also create PPA with patched VTE:
https://launchpad.net/~adrozdoff/+archive/ubuntu/vte

[Iain Lane (laney)]

(subscribed sponsors to take care of #14 and #15 - thanks, Alexander)

Egmont, if you're still reading this, I'm happy to help with uploading backports of fixes to vte in older releases if you're willing to help identify the commits.

I get a lot of bug mail and there's a good chance I'd miss it if you post it here or on another bug - so if you do take this up then please either subscribe me to the bug or email me (address in LP profile). Cheers.

[bjrke (bjrke)]

the patch of adrozdoff is still needed for yakketi

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Robie Basak (racb)]

Thank you for the patch and sorry for the delay. We're making an effort to clear out languishing items in the sponsorship queue today.

vte needs fixing in Zesty before we can fix it in older releases. Please see https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

We also need a working test case for the vte (as opposed to vte3) case.

But I'm trying to get an initial response to as many outstanding requests today as I can, so I'll move on for now. Please try to follow the SRU procedure if you can, provide a test case for this fix, provide debdiffs for all of Zesty, Yakkety, Xenial and if you wish Trusty, and then resubscribe ~ubuntu-sponsors to the bug when done.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.