Update gnome-terminal to 3.28 (vte 0.52)

Bug #1744711 reported by Egmont Koblinger on 2018-01-22
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-terminal (Ubuntu)
Wishlist
Unassigned
vte2.91 (Ubuntu)
Wishlist
Unassigned

Bug Description

Followup of lp:1721412

18.04 LTS should ship gnome-terminal 3.28, libvte2.91 0.52 (assuming that it ships GNOME 3.28).

This requires updating the PCRE2 patch.

Egmont Koblinger (egmont-gmail) wrote :

For porting the PCRE2 patches to test releases vte-0.51.3 and gnome-terminal-3.27.4, see the patch and instructions at lp:1721412 comment 9.

Egmont Koblinger (egmont-gmail) wrote :

Here's an updated patch against current VTE master.

https://git.gnome.org/browse/vte/commit/?id=b274318f2e is a conflicting upstream change. (By the way, I discovered the bug while porting the patch to the previous version.)

The easy way to do the merging was, again, (at least for me), to
- revert the conflicting upstream change
- apply the existing pcre2 patch
- manually re-apply the upstream change
- squash these to a single commit

Jeremy Bicha (jbicha) on 2018-01-22
Changed in vte2.91 (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
Changed in gnome-terminal (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged

The attachment "vte post-0.51.3 revert pcre2" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Egmont Koblinger (egmont-gmail) wrote :

FYI: Forthcoming gnome-terminal 3.27.90 will no longer have an --enable-distro-packaging config option. Just drop it.

Egmont Koblinger (egmont-gmail) wrote :

As per bug 1745825, I've dropped the code that decides whether to show/hide the "Use transparency from system theme" checkbox, it is now always shown.

It shouldn't be that hard to bring it back. It'd need to be done manually; methods that received an extra parameter by this part of the patch now take different parameters in upstream, so the patch doesn't apply automatically.

As this part of the code might cause a crash, I'm personally not motivated at all to bring back that crash, I vote for this patch which eliminates it. And as per that bug, bringing back this feature and fixing the bug in the same time is really nontrivial.

Jeremy Bicha (jbicha) wrote :
Changed in vte2.91 (Ubuntu):
status: Triaged → Fix Committed
Changed in gnome-terminal (Ubuntu):
status: Triaged → Fix Committed
Egmont Koblinger (egmont-gmail) wrote :

So glib 2.54 -> 2.55 upgrade has problems, and as a consequence, vte upgrade (which requires glib >= 2.40) is held back?? I don't understand it :D Nevermind, I'm sure it'll all be polished out for the final 18.04 + 3.28, so it's okay.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-terminal - 3.27.90-1ubuntu1

---------------
gnome-terminal (3.27.90-1ubuntu1) bionic; urgency=medium

  [ Jeremy Bicha ]
  * Merge with Debian (LP: #1744711). Remaining changes:
    + debian/rules:
      - Install compatibility version of gnome-terminal.desktop
    + gnome-terminal.wrap, debian/rules:
      - Add a wrapper script to restore command line compatibility.
    + debian/control.in:
      - gnome-terminal depends on python3, python3-gi and gir1.2-glib-2.0 for
        the wrapper script.
      - Don't Build-Depend on PCRE2
    + Add 0001-Restore-transparency.patch:
      - Restore transparency support
    + Add 0001-Add-style-classes-and-CSS-names-to-some-of-our-widge.patch:
      - Add CSS names and style classes so we can theme things more easily.
    + Add 0001-screen-window-Extra-padding-around-transparent-termi.patch:
      - Fix transparency on Wayland. Patch by Owen Taylor, via Debarshi Ray @
        Fedora (LP: #1650395)
    + Add 50_add_unity_quicklist.patch:
      - Add Unity quicklist menu item.
    + Add 52_support_apturl.patch:
      - Support apt: urls.
    + Add 60_add_lp_handler.patch:
      - Add a handler for launchpad bug URLs.
    + Add scrollbar-background-theming.patch:
      - Draw background under the scrollbar that matches the actual terminal
        background color. This allows proper theming.
    + Add debian/patches/revert-pcre2.patch:
      - Revert changes that require PCRE2 since it's not in main
        (see MIR #163666)

  [ Egmont Koblinger ]
  * Update patches to apply against new version
  * Always show "Use transparency from system theme" checkbox (LP: #1745825)

gnome-terminal (3.27.90-1) experimental; urgency=medium

  * New upstream development release
    - Unified preferences dialog
  * Bump minimum libvte-2.91-dev to 2.51.3
  * Drop obsolete vala build-dependency

 -- Egmont Koblinger <email address hidden> Fri, 16 Feb 2018 13:09:20 -0500

Changed in gnome-terminal (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vte2.91 - 0.51.90-1ubuntu1

---------------
vte2.91 (0.51.90-1ubuntu1) bionic; urgency=medium

  [ Jeremy Bicha ]
  * Merge with Debian (LP: #1744711). Remaining changes:
    - debian/rules:
      + Use --without-pcre2
    - Add revert-pcre2.patch:
      + Revert changes that require PCRE2 since it's not in main
        (see MIR #163666)
    - 0001-Add-the-style-context-provider-with-FALLBACK-priorit.patch:
      + Keep as it is required for the Ubuntu theming
  * Dropped change, apparently hasn't been needed for years:
    - Add 91_keep_fds.patch:
      + Keep file descriptors open on vte_fork_pty()

   [ Egmont Koblinger ]
   * Update revert-pcre2.patch to apply against vte2.91 0.51.90

vte2.91 (0.51.90-1) experimental; urgency=medium

  * New upstream development release
  * Drop obsolete Build-Depends on gperf
  * debian/libvte-2.91-0.symbols: Add new symbols

 -- Egmont Koblinger <email address hidden> Fri, 16 Feb 2018 13:48:13 -0500

Changed in vte2.91 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers