libvte9-udeb depends on libncurses5

[Colin Watson]

In the most recent version in jaunty, libvte9-udeb depends on libncurses5, due to being linked against libtermcap. This is a disallowed dependency and causes debian-installer to fail to build.

It looks like vte 0.19.4 requires some work in order to be able to build without ncurses for the udeb, although not a prohibitive amount.

[Chris Coulson (chrisccoulson)]

That'll be my fault then ;)

[Chris Coulson (chrisccoulson)]

Ah, ok, I think I can see what I did wrong with the optional-ncurses.patch. But it requires more work than that?

[Chris Coulson (chrisccoulson)]

If you haven't already done it by the time I get home this evening, I'll take a look at this.

[Colin Watson (cjwatson)]

Would you review lp:~kamion/vte/udeb-fixes? I think it does the job (at any rate a test-build no longer shows this dependency, but I haven't checked that the .debs still work, and I don't know vte well enough to feel comfortable uploading this myself).

The patches to src/ basically unpick some parts of the upstream patch that broke the ability to build without termcap.

[Chris Coulson (chrisccoulson)]

I had a quick look, and re-adding in the #ifdef in src/keymap.c was basically what I was going to propose too. The implementation looks the same as what it was in 0.17.4, so I think it's probably ok. However, it might be a good idea to get someone who knows vte a bit better to have a quick look at it (I might be wrong, but I think Kees Cook might be a good person to ask)

[Chris Coulson (chrisccoulson)]

Hi Colin, Kees had a quick look at this and seems happy with it:

(18:01:07) chrisccoulson: cool. upstream removed the ability to build it without ncurses in the new version, and i was going to ask if you could review a patch colin watson just did to make this to work again
(18:01:13) chrisccoulson: bug 321848
(18:01:14) ubottu: Launchpad bug 321848 in vte "libvte9-udeb depends on libncurses5" [Undecided,New] https://launchpad.net/bugs/321848
(18:01:40) chrisccoulson: it builds with the correct dependencies, but it needs a sanity check from someone who's slightly more familiar
(18:02:44) kees: sure, do you have a straight diff of the change somewhere?
(18:04:14) chrisccoulson: its in bzr, but I just posted the actual patch in debian/patches here: http://paste.ubuntu.com/110373/
(18:04:49) chrisccoulson: the configure.in change was already in the last version, but colin modified it as I made a mistake (which is why it ended up being linked against ncurses)
(18:05:06) chrisccoulson: the other source changes look very similar to what was already in the old version
(18:06:24) kees: chrisccoulson: that patch looks fine to me. Hopefully upstream will take it.
(18:06:47) chrisccoulson: it would be nice, but they already removed this functionality from the new version :(
(18:06:58) chrisccoulson: hence the new patch to add it back in again

[Colin Watson (cjwatson)]

OK, thanks, I've uploaded this and will send a merge request for the bzr branch.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vte - 1:0.19.4-0ubuntu2

---------------
vte (1:0.19.4-0ubuntu2) jaunty; urgency=low

  * 25_optional-ncurses.patch: If --without-ncurses is given, disable
    ncurses/termcap entirely (LP: #321848).
  * 90_autoreconf.patch: Update.

 -- Colin Watson <email address hidden> Tue, 27 Jan 2009 18:42:49 +0000