| 2010-09-26 15:31:53 |
Stephane Chazelas |
bug |
|
|
added bug |
| 2010-09-27 19:11:48 |
C de-Avillez |
vsftpd (Ubuntu): importance |
Undecided |
Low |
|
| 2010-09-27 19:11:48 |
C de-Avillez |
vsftpd (Ubuntu): status |
New |
Confirmed |
|
| 2010-09-27 19:12:48 |
C de-Avillez |
nominated for series |
|
Ubuntu Lucid |
|
| 2010-09-27 19:12:48 |
C de-Avillez |
bug task added |
|
vsftpd (Ubuntu Lucid) |
|
| 2010-09-27 19:12:48 |
C de-Avillez |
nominated for series |
|
Ubuntu Maverick |
|
| 2010-09-27 19:12:48 |
C de-Avillez |
bug task added |
|
vsftpd (Ubuntu Maverick) |
|
| 2010-12-08 15:01:42 |
Imre Gergely |
vsftpd (Ubuntu Lucid): status |
New |
Confirmed |
|
| 2010-12-08 15:02:12 |
Imre Gergely |
bug |
|
|
added subscriber Imre Gergely |
| 2011-02-25 19:27:39 |
Andres Rodriguez |
vsftpd (Ubuntu): assignee |
|
Andres Rodriguez (andreserl) |
|
| 2011-02-25 19:27:43 |
Andres Rodriguez |
vsftpd (Ubuntu): status |
Confirmed |
Triaged |
|
| 2011-02-25 19:27:46 |
Andres Rodriguez |
vsftpd (Ubuntu): status |
Triaged |
In Progress |
|
| 2011-02-25 20:37:17 |
Andres Rodriguez |
attachment added |
|
vsftpd.debdiff https://bugs.launchpad.net/ubuntu/+source/vsftpd/+bug/648202/+attachment/1871742/+files/vsftpd.debdiff |
|
| 2011-02-25 20:37:47 |
Andres Rodriguez |
vsftpd (Ubuntu): status |
In Progress |
Confirmed |
|
| 2011-02-25 20:37:50 |
Andres Rodriguez |
vsftpd (Ubuntu): importance |
Low |
Wishlist |
|
| 2011-02-25 20:37:53 |
Andres Rodriguez |
bug |
|
|
added subscriber Andres Rodriguez |
| 2011-02-25 20:37:55 |
Andres Rodriguez |
vsftpd (Ubuntu): assignee |
Andres Rodriguez (andreserl) |
|
|
| 2011-02-25 20:42:16 |
Andres Rodriguez |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2011-02-25 20:47:50 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): status |
Confirmed |
In Progress |
|
| 2011-02-25 20:47:54 |
Andres Rodriguez |
vsftpd (Ubuntu Maverick): status |
Confirmed |
In Progress |
|
| 2011-02-25 20:48:00 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): status |
In Progress |
Confirmed |
|
| 2011-02-25 20:48:02 |
Andres Rodriguez |
vsftpd (Ubuntu Maverick): status |
In Progress |
Confirmed |
|
| 2011-02-25 23:04:10 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): assignee |
|
Andres Rodriguez (andreserl) |
|
| 2011-02-25 23:04:15 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): status |
Confirmed |
In Progress |
|
| 2011-02-28 16:15:11 |
Launchpad Janitor |
vsftpd (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2011-02-28 16:24:47 |
Andres Rodriguez |
description |
Binary package hint: vsftpd
(lucid vsftpd 2.2.2-3ubuntu6)
because of a syntax error in /etc/init/vsftpd.con, vsftd is started (and respawns a lot as it fails to start) if there's no "listen=yes" in /etc/vsftpd.conf
/etc/init/vsftpd.conf has:
if [ -e "${CONFFILE}" ] && !egrep -iq "^ *listen(_ipv6)? *= *yes" "${CONFFILE}"
without space between ! and egrep. As a result !egrep returns with an error ("!egrep" command not found) and as a result, the script assumes the "listen = yes" line is in the file.
Moreover, if the /etc/vsftpd.conf file is not there, vsftpd is also started which I suspect was not intended.
Moreover egrep is not a POSIX command.
Would be better written as:
if ! grep -qEis -- '^[[:blank:]]*listen(_ipv6)?[[:blank:]]*=[[:blank:]]*yes' "$CONFFILE"; then... |
Binary package hint: vsftpd
(lucid vsftpd 2.2.2-3ubuntu6)
because of a syntax error in /etc/init/vsftpd.con, vsftd is started (and respawns a lot as it fails to start) if there's no "listen=yes" in /etc/vsftpd.conf
/etc/init/vsftpd.conf has:
if [ -e "${CONFFILE}" ] && !egrep -iq "^ *listen(_ipv6)? *= *yes" "${CONFFILE}"
without space between ! and egrep. As a result !egrep returns with an error ("!egrep" command not found) and as a result, the script assumes the "listen = yes" line is in the file.
Moreover, if the /etc/vsftpd.conf file is not there, vsftpd is also started which I suspect was not intended.
Moreover egrep is not a POSIX command.
Would be better written as:
if ! grep -qEis -- '^[[:blank:]]*listen(_ipv6)?[[:blank:]]*=[[:blank:]]*yes' "$CONFFILE"; then...
=======
SRU Justification
IMPACT: See above description to see the its impact.
REPRODUCE:
1. First edit the configure (/etc/vsftpd.conf) and comment the line "listen=yes".
2. Then start vsftpd: sudo service vsftpd start
3. Upstart will report that the service has been started (start/running), when it should have failed to start because the upstart job does the configuration check (stop/pre-start).
HOW FIXED: Add a blank space between ! and egrep as specified above. Also, instead of using 'exit 0' use stop within the upstart job.
PATCH: Attached. Uploaded to lucid-proposed for review there.
REGRESSION POTENTIAL: Minimal. I've tested this throughly and works as expected. (See C-de Avillez comment #2 on how this is supposed to work.
======= |
|
| 2011-02-28 16:51:03 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): status |
In Progress |
Confirmed |
|
| 2011-02-28 16:52:34 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): importance |
Undecided |
Low |
|
| 2011-02-28 16:52:39 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): importance |
Low |
Medium |
|
| 2011-02-28 16:52:45 |
Andres Rodriguez |
vsftpd (Ubuntu Maverick): importance |
Low |
Medium |
|
| 2011-02-28 16:52:49 |
Andres Rodriguez |
vsftpd (Ubuntu Lucid): assignee |
Andres Rodriguez (andreserl) |
|
|
| 2011-02-28 17:00:31 |
Andres Rodriguez |
attachment added |
|
vsftpd.debdiff https://bugs.launchpad.net/ubuntu/lucid/+source/vsftpd/+bug/648202/+attachment/1876953/+files/vsftpd.debdiff |
|
| 2011-02-28 17:09:30 |
Andres Rodriguez |
attachment added |
|
vsftpd.debdiff https://bugs.launchpad.net/ubuntu/lucid/+source/vsftpd/+bug/648202/+attachment/1876968/+files/vsftpd.debdiff |
|
| 2011-02-28 20:19:30 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/vsftpd |
|
| 2011-02-28 20:35:42 |
Launchpad Janitor |
branch linked |
|
lp:~andreserl/ubuntu/lucid/vsftpd/sru1 |
|
| 2011-02-28 20:47:59 |
Launchpad Janitor |
branch linked |
|
lp:~andreserl/ubuntu/maverick/vsftpd/sru1 |
|
| 2011-03-02 11:13:27 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/maverick/vsftpd |
|
| 2011-03-02 11:14:00 |
Martin Pitt |
vsftpd (Ubuntu Maverick): status |
Confirmed |
Fix Committed |
|
| 2011-03-02 11:14:18 |
Martin Pitt |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2011-03-02 11:14:36 |
Martin Pitt |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2011-03-02 11:18:38 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/lucid/vsftpd |
|
| 2011-03-04 17:33:17 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
| 2011-03-04 17:33:22 |
Martin Pitt |
tags |
|
verification-needed |
|
| 2011-03-04 18:19:33 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/maverick-proposed/vsftpd |
|
| 2011-03-15 15:58:43 |
Andres Rodriguez |
tags |
verification-needed |
|
|
| 2011-03-15 16:11:51 |
Andres Rodriguez |
tags |
|
verification-done |
|
| 2011-03-24 14:50:24 |
Launchpad Janitor |
vsftpd (Ubuntu Maverick): status |
Fix Committed |
Fix Released |
|
| 2011-04-13 22:36:24 |
Launchpad Janitor |
branch linked |
|
lp:~andreserl/ubuntu/lucid/vsftpd/sru1 |
|
| 2011-04-19 07:04:11 |
Martin Pitt |
vsftpd (Ubuntu Lucid): status |
Confirmed |
Fix Committed |
|
| 2011-04-19 07:04:14 |
Martin Pitt |
tags |
verification-done |
|
|
| 2011-04-19 07:04:16 |
Martin Pitt |
tags |
|
verification-needed |
|
| 2011-04-25 19:57:32 |
Andres Rodriguez |
tags |
verification-needed |
verification-done |
|
| 2011-04-26 07:04:05 |
Launchpad Janitor |
vsftpd (Ubuntu Lucid): status |
Fix Committed |
Fix Released |
|
| 2011-04-26 07:13:13 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/lucid-updates/vsftpd |
|
