Problems when linking other packages (i.e.: Asterisk with iLBC) with this library (libvpb0)

[malaiwah]

As reported here:
http://bugs.digium.com/view.php?id=14138

Summary:
 * libvpb0 is a dependency of the Asterisk package (Voicetronix API)
 * Digium removed the iLBC codec from their svn tree, but we can get it compiled using their contrib/scripts/get_ilbc_source.sh script.
 * If compiling the Asterisk package by hand, the window() function from VPB overlaps the window() function from the iLBC codec source code.

I would suggest either of these projects to rename the function to a better name that associates its functionnality to its corresponding project.
I uploaded a patch to Digium to rename that function to ilbc_window() when downloading and extracting the source code (from a RFC).

This bug could also affect other packages as well, I think this function name should be changed in the vpb-driver.
I'm posting this bug onto Launchpad because I'm using Ubuntu, but I will try to contact Voicetronix to make them aware of this issue and maybe patch their original source code.

window() function prototype from vpb-driver: http://vpb-driver.sourcearchive.com/documentation/4.2.32/wind_8h-source.html
window() function prototype from ilbc_codec: http://www.ietf.org/rfc/rfc3951.txt

[malaiwah (michel-belleau)]

I left an email to VoiceTronix about that issue (<email address hidden>, <email address hidden>, <email address hidden>) a few minutes ago, so they can have a look at it too.

My C skills are rusty, but I think that renaming the function to another name in the source code would be the correct way to deal with that overlap.

[malaiwah (michel-belleau)]

Just had a reply from Ron Lee at Voicetronix:

objet Re: [Voicetronix #61691] libvpb and its window() function

Hi Michel,

I don't really think that renaming this symbol is the correct fix, rather it should not be public at all, either in our code or in any iLBC implementation, or anyone else's code for that matter. A name this generic should never be getting exported. Since it isn't a part of our public interface, that should be easy to fix.

Thanks for the heads-up, I'll drop this symbol from the next release.

[malaiwah (michel-belleau)]

Bug has been confirmed by Voicetronix, packager should update version once it is released.