two important bug, gnome-session error,and x-terminal-emulator error

[elwin]

bug 1: vnc run x-terminal-emulator error
-----------------------------------------------
on ubuntu 16.04 or ubuntu 18.04,
sudo apt-get install vnc4server
then run vncserver

the ~/.vnc/xstartup file was created as follow:

$ cat ~/.vnc/xstartup
#!/bin/sh

# Uncomment the following two lines for normal desktop:
# unset SESSION_MANAGER
# exec /etc/X11/xinit/xinitrc

[ -x /etc/vnc/xstartup ] && exec /etc/vnc/xstartup
[ -r $HOME/.Xresources ] && xrdb $HOME/.Xresources
xsetroot -solid grey
vncconfig -iconic &
x-terminal-emulator -geometry 80x24+10+10 -ls -title "$VNCDESKTOP Desktop" &
x-window-manager &

when use vncviewer connect vnc service , only find vncconfig window, no x-terminal-emulator.

the error root cause was

/usr/bin/x-terminal-emulator this is a perl script, it add wrong cmdline parameter "--login" to gnome-terminal.

``````
if ($login == 1)
{
    @args = ('--login', @args);
}
exec('gnome-terminal',@args);

`````

when gnome-terminal run with parameter "--login", will complain
 "Failed to parse arguments: Unknown option --login\n" and exit. so we can't see it in vncclient.

please change the /usr/bin/x-terminal-emulator perl file to fix this bug.

bug2; vnc run gnome-session error
----------------------------------

on ubuntu 16.04 or ubuntu 18.04,
sudo apt-get install vnc4server
then run vncserver

change the ~/.vnc/xstartup file was created as follow:

$ cat ~/.vnc/xstartup
#!/bin/sh

# Uncomment the following two lines for normal desktop:
# unset SESSION_MANAGER
# exec /etc/X11/xinit/xinitrc

[ -x /etc/vnc/xstartup ] && exec /etc/vnc/xstartup
[ -r $HOME/.Xresources ] && xrdb $HOME/.Xresources
xsetroot -solid grey
vncconfig -iconic &

x-window-manager &
gnome-session &

then use vnc client connet the vncserver, we will not see gone-session desktop.

because the /usr/bin/gnome-session will check opengl hardware/software acceleration ,but the vnc4server can't supportopengl hardware/software acceleration. so the gonme-session fails.

the wrong message /usr/bin/gnome-session complain was

"software acceleration check failed: Child process exited with code 1"

"gnome-session-binary[9978]: CRITICAL: We failed, but the fail whale is dead. Sorry....\n"

please change vnc4server support opengl hardware/software acceleration as tightervnc.
or add --disable-acceleration-check cmdline parameter to /usr/bin/gnome-session for /usr/lib/gnome-session/gnome-session-binary . to fix this bug.

for more detail infomation please contact me via [e-mail].