vmbuilder script fails on deploy/cleanup

[Richard C]

Binary package hint: python-vm-builder

Originally attached to bug #562189

I believe this is a bug. There are two checks
for pre-existing VMs, and they differ:
/usr/lib/python2.7/dist-packages/VMBuilder/plugins/libvirt/__init__.py
line 54: if hostname in self.all_domains() and not
self.context.overwrite:
line 80: if hostname in self.all_domains() and not self.vm.overwrite:

Changing line 80 to match line 54 prevents this error. I believe this is an ok fix. Consider splitting this into a function, rather than copying and pasting code, if these are supposed to be identical lines.

Line 80 throws an error when run:
Traceback (most recent call last):
  File "/usr/bin/vmbuilder", line 24, in <module>
    cli.main()
  File "/usr/lib/python2.7/dist-packages/VMBuilder/contrib/cli.py", line 227,
in main
    hypervisor.finalise(destdir)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/hypervisor.py", line 78, in
finalise
    self.call_hooks('deploy', destdir)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/distro.py", line 67, in
call_hooks
    call_hooks(self, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/VMBuilder/util.py", line 158, in
call_hooks
    getattr(plugin, func, log_no_such_method)(*args, **kwargs)
  File
"/usr/lib/python2.7/dist-packages/VMBuilder/plugins/libvirt/__init__.py", line
80, in deploy
    if hostname in self.all_domains() and not self.vm.overwrite:
AttributeError: 'Libvirt' object has no attribute 'vm'

[Scott Moser (smoser)]

Simply looking reading the bug description and looking at code, the solution seems sane. It appears like the change to Libvirt:deploy should have been made at the same time the change to 'preflight_check' was [1].

--
[1] http://bazaar.launchpad.net/~vmbuilder-dev/vmbuilder/0.12/revision/451