blkid not used in fstab

Bug #556732 reported by EAB
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
vm-builder (Ubuntu)
Confirmed
Wishlist
Unassigned

Bug Description

vmbuilder uses blkid in /boot/grub/menu.lst
It should use it to in /etc/fstab

Now it's needed to rewrite (automated) /etc/fstab with UUID's to prevent issues when adding disks.

Revision history for this message
Loïc Minier (lool) wrote :

NB: UUID in fstab requires an initrd.

Revision history for this message
EAB (erwin-true) wrote :

Does it?
The UUID's are known from the beginning while the disks are partitioned.

Revision history for this message
Loïc Minier (lool) wrote :

You can't pass root= to the kernel with an UUID or a LABEL; only initrds understand this syntax (so far); the one in the fstab doesn't matter too much I think, but the one passed to the kernel does matter, so if your goal is to avoid hardcoding the device name, it might still be an issue on the kernel cmdline.

Revision history for this message
EAB (erwin-true) wrote :

Snippet from menu.list:
title Ubuntu 9.10, kernel 2.6.31-20-server
uuid 618c7d1f-ef8c-423b-9f32-e8731d15daf2
kernel /boot/vmlinuz-2.6.31-20-server root=UUID=618c7d1f-ef8c-423b-9f32-e8731d15daf2 ro quiet splash
initrd /boot/initrd.img-2.6.31-20-server

/etc/fstab (after I fixed it):
UUID=618c7d1f-ef8c-423b-9f32-e8731d15daf2 / xfs defaults 0 0
UUID=409917ac-9244-4ae1-a5f8-d54b3b1665c6 swap swap defaults 0 0

The goal is to prevent issues when adding disks. When a new disk is added and recognized before the current disk, the root and swap partitions are not there (on the new added disk). /dev/sda is the new disk and /dev/sdb1 is root and /dev/sdb2 is swap in this new situation.

UUIDs in fstab are used by default since 8.04.

I only asking to put this on a whislist.
plugins/ubuntu/dapper.py line 260 self.install_from_template('/etc/fstab', 'dapper_fstab', { 'parts' : disk.get_ordered_partitions(self.vm.disks), 'prefix' : self.disk_prefix })
And the template should use UUIDs.

Thierry Carrez (ttx)
Changed in vm-builder (Ubuntu):
importance: Undecided → Wishlist
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.