VMBuilder/vm.py crash on an alpha char in numeric constant

Bug #313575 reported by spiggott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VMBuilder
Fix Released
Undecided
Unassigned
vm-builder (Ubuntu)
Fix Released
Low
Loïc Minier

Bug Description

/usr/lib/python2.5/site-packages/VMBuilder/vm.py crashes on the line

mask = OxFFFF

where the initial character is a capital letter O rather than a zero. This caused the program to fail in Intrepid. Replacing that O with a zero corrected the problem.

The error is on line 281 in the file as distributed in Intrepid. The defect is in the upstream source, and is still present in the Jaunty source, at line 264 (without ubuntu patch).

Traceback:

2009-03-19 15:16:21,645 INFO Cleaning up
Traceback (most recent call last):
  File "/usr/bin/vmbuilder", line 29, in <module>
    VMBuilder.run()
  File "/usr/lib/python2.5/site-packages/VMBuilder/__init__.py", line 66, in run
    frontend.run()
  File "/usr/lib/python2.5/site-packages/VMBuilder/plugins/cli/__init__.py", line 67, in run
    vm.create()
  File "/usr/lib/python2.5/site-packages/VMBuilder/vm.py", line 434, in create
    self.preflight_check()
  File "/usr/lib/python2.5/site-packages/VMBuilder/vm.py", line 397, in preflight_check
    self.ip_defaults()
  File "/usr/lib/python2.5/site-packages/VMBuilder/vm.py", line 281, in ip_defaults
    mask = OxFFFF
NameError: global name 'OxFFFF' is not defined

Related branches

spiggott (spiggott)
description: updated
greenmoss (ktyubuntu)
description: updated
Revision history for this message
Chuck Short (zulcss) wrote :

Hi,

Can you show us the options that you used so we can reproduce this bug?

Regards
chuck

Changed in vm-builder (Ubuntu):
status: New → Incomplete
Revision history for this message
J. Bruce Fields (bfields-fieldses) wrote :

By trial and error I found a minimal commandline that would reproduce the problem for me was: "vmbuilder kvm ubuntu --ip=141.212.112.9"

Revision history for this message
Soren Hansen (soren) wrote :
Changed in vm-builder (Ubuntu):
importance: Undecided → Low
Changed in vmbuilder:
status: New → Fix Committed
milestone: none → 0.11.4
Chuck Short (zulcss)
Changed in vm-builder (Ubuntu):
status: Incomplete → Fix Committed
Loïc Minier (lool)
Changed in vm-builder (Ubuntu):
assignee: nobody → Loïc Minier (lool)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vm-builder - 0.11.3-0ubuntu3

---------------
vm-builder (0.11.3-0ubuntu3) lucid; urgency=low

  * New patch, ssk-key-type-error, add parentheses as operator priority caused
    a TypeError in the format string of the user chown call in the
    install_authorized_keys() function; LP: #436835.
  * Add rsync dependency; LP: #314833.
  * Wrap build-deps and deps to get cleaner diffs.
  * Use Priority: optional.
  * Use launchpad.net/vmbuilder instead of code.l.n in copyright.
  * Downgrade devscripts dep to a Recommends as I believe this is only needed
    for rmadison in a Xen specific codepath, and it's rather heavy to install
    devscripts on servers; this needs to be confirmed though.
  * Depend on grub (legacy) as this is currently a hard requirement;
    LP: #331595.
  * Depend on qemu-kvm | qemu-kvm-extras instead of kvm | qemu as these are
    transitional packages nowadays.
  * New patch, ip-mask-typo, fixes typo in IP mask handling; LP: #313575; from
    r355.
  * Build-dep on python-all, not python-all-dev.
  * Bump up Standards-Version to 3.8.3.
  * Change Vcs-Bzr to XS-Upstream-Vcs-Bzr as the packaging is not kept in Bzr.
  * Add watch file.
  * Remove leftover VMBuilder/vcsversion.py.debdiff.
  * Move changes from 0.10-0ubuntu2 to sleep a little to leave a chance to
    loop devices to settle down to a new patch, settle-down-disk.
 -- Loic Minier <email address hidden> Sun, 17 Jan 2010 21:21:38 +0100

Changed in vm-builder (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Chris Bainbridge (chris-bainbridge) wrote :

This bug still exists in karmic. You can use --mask 255.255.255.0 in the vm-builder command line as a workaround.

Soren Hansen (soren)
Changed in vmbuilder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers