vlc player crashes during SAP playlist loading

Bug #70664 reported by Peter Gubis on 2006-11-07
12
Affects Status Importance Assigned to Milestone
VLC media player
Fix Released
Unknown
vlc (Ubuntu)
Medium
Daniel T Chen

Bug Description

after starting vlc player with SAP playlist announces enabled player segfaults.

Peter Gubis (manaz) wrote :
Changed in vlc:
status: Unconfirmed → Confirmed
Peter Gubis (manaz) wrote :

Hello,

I already found a problem in vlc source tree and fixed it. Could somebody fix it also in distributions package? Problem is in uproper handling of buffer during sdp packet decompress. To solve the problem you need to do following:

File modules/services_discovery/sap.c, line 703:

        i_decompressed_size = Decompress( (uint8_t *)psz_sdp,
                   &p_decompressed_buffer, i_read - ( psz_sdp - (char *)p_buffer ) );
        if( i_decompressed_size > 0 )
        {
            psz_sdp = (char *)p_decompressed_buffer;
            realloc( p_decompressed_buffer, i_decompressed_size++ );
            psz_sdp[i_decompressed_size] = '\0';
        }

Update it for:

        i_decompressed_size = Decompress( (uint8_t *)psz_sdp,
                   &p_decompressed_buffer, i_read - ( psz_sdp - (char *)p_buffer ) );
        if( i_decompressed_size > 0 )
        {
            psz_sdp = (char *)p_decompressed_buffer;
            psz_sdp = realloc( p_decompressed_buffer, i_decompressed_size+1 );
            psz_sdp[i_decompressed_size] = '\0';
        }

Problem follows this line of code:

 realloc( p_decompressed_buffer, i_decompressed_size++ );
vs.
psz_sdp = realloc( p_decompressed_buffer, i_decompressed_size+1 );

Best regards,
Peter.

Daniel T Chen (crimsun) on 2006-11-19
Changed in vlc:
assignee: nobody → crimsun
importance: Undecided → Medium
status: Confirmed → In Progress
Derk-Jan Hartman (hartman) wrote :

This bug was fixed upstream. Please see the referenced upstream trac ticket.

Daniel T Chen (crimsun) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 15 Dec 2006 20:57:59 -0500
Source: vlc
Binary: wxvlc vlc-plugin-sdl vlc-plugin-ggi vlc-plugin-alsa vlc-plugin-glide vlc-plugin-esd mozilla-plugin-vlc vlc libvlc0 vlc-plugin-arts vlc-nox vlc-plugin-svgalib libvlc0-dev
Architecture: source
Version: 0.8.6.release-0ubuntu1
Distribution: feisty
Urgency: low
Maintainer: MOTU Media Team <email address hidden>
Changed-By: Daniel T Chen <email address hidden>
Description:
 libvlc0 - multimedia player and streamer library
 libvlc0-dev - development files for VLC
 mozilla-plugin-vlc - multimedia plugin for web browsers based on VLC
 vlc - multimedia player and streamer
 vlc-nox - multimedia player and streamer (without X support)
 vlc-plugin-alsa - dummy transitional package
 vlc-plugin-arts - aRts audio output plugin for VLC
 vlc-plugin-esd - Esound audio output plugin for VLC
 vlc-plugin-ggi - GGI video output plugin for VLC
 vlc-plugin-glide - Glide video output plugin for VLC
 vlc-plugin-sdl - SDL video and audio output plugin for VLC
 vlc-plugin-svgalib - SVGAlib video output plugin for VLC
 wxvlc - dummy transitional package
Changes:
 vlc (0.8.6.release-0ubuntu1) feisty; urgency=low
 .
   * New upstream release (0.8.6):
     - Autostart in mozilla plugin reenabled (Closes Ubuntu: #67402),
     - ffmpeg demux fixed (Closes Ubuntu: #69849),
     - Segfault with SAP playlist announcement loading fixed
       (Closes Ubuntu: #70664).
   * debian/patches/020_notify.diff: Rediff.
Files:
 f336f63f9a32b1dece29395f922cc814 2046 graphics optional vlc_0.8.6.release-0ubuntu1.dsc
 d79ef5c26945bfa3c750550054bd9feb 16866386 graphics optional vlc_0.8.6.release.orig.tar.gz
 df18075271533a295975cc564ee90593 33637 graphics optional vlc_0.8.6.release-0ubuntu1.diff.gz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFFg1dFe9GwFciKvaMRAg9zAKC+r0Uf8lbGuEPBz4hX3AHlaEm79ACfcid4
qSig6OBEYtgpylTNwlDBUH0=
=9vm0
-----END PGP SIGNATURE-----

Changed in vlc:
status: In Progress → Fix Committed
Daniel T Chen (crimsun) on 2006-12-16
Changed in vlc:
status: Fix Committed → Fix Released
Changed in vlc:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.