Activity log for bug #672304

Date Who What changed Old value New value Message
2010-11-07 21:48:48 Nicola Ferralis bug added bug
2010-11-07 21:49:10 Nicola Ferralis bug watch added http://trac.videolan.org/vlc/ticket/4312
2010-11-07 21:49:10 Nicola Ferralis bug task added vlc
2010-11-07 22:18:40 Nicola Ferralis vlc (Ubuntu): status New Invalid
2010-11-07 22:18:54 Nicola Ferralis vlc (Ubuntu): status Invalid New
2010-11-10 23:52:07 Bug Watch Updater vlc: status Unknown Confirmed
2010-11-17 22:30:34 Nicola Ferralis summary Image abnmormally stretched when streaming with transcode activated. Image abnmormally stretched when streaming with transcode activated (Integer overflow in aspect ratio calculation)
2010-11-17 22:30:40 Nicola Ferralis vlc (Ubuntu): status New Confirmed
2010-11-17 22:30:51 Nicola Ferralis vlc (Ubuntu): status Confirmed In Progress
2010-11-17 22:30:57 Nicola Ferralis vlc (Ubuntu): status In Progress Fix Committed
2010-11-17 22:31:02 Nicola Ferralis vlc (Ubuntu): status Fix Committed Confirmed
2010-11-17 23:14:21 Nicola Ferralis attachment added transcode_aspect_ratio.debdiff https://bugs.launchpad.net/vlc/+bug/672304/+attachment/1736633/+files/transcode_aspect_ratio.debdiff
2010-11-17 23:14:41 Nicola Ferralis attachment added transcode_aspect_ratio.diff https://bugs.launchpad.net/vlc/+bug/672304/+attachment/1736634/+files/transcode_aspect_ratio.diff
2010-11-17 23:18:09 Nicola Ferralis tags patch
2010-11-18 04:48:21 Nicola Ferralis bug watch added http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603888
2010-11-18 04:48:21 Nicola Ferralis bug task added vlc (Debian)
2010-11-18 13:02:09 Bug Watch Updater vlc (Debian): status Unknown New
2010-11-18 17:30:14 Brian Murray bug added subscriber Ubuntu Review Team
2010-11-18 23:30:11 Launchpad Janitor vlc (Ubuntu): status Confirmed Fix Released
2010-11-19 00:19:41 Launchpad Janitor branch linked lp:ubuntu/vlc
2010-11-19 01:56:58 Bug Watch Updater vlc: status Confirmed Fix Released
2010-11-19 06:53:01 Nicola Ferralis description Binary package hint: vlc Using VLC 1.1.4 on Ubuntu 10.10. When I try to stream my Desktop (and transcoding it with h264), the image I stream is always stretched laterally. This also happens when I stream from a webcam (v4l2): the image is stretched vertically. Note that if I select to stream without transcoding, the image, in either case, looks normal. Please keep in mind that this bug seems to be only reproducible with Ubuntu. In Windows everything works as expected. This is the generated output string used when transcoding is on: :sout=#transcode{vcodec=h264,vb=1500,scale=1,width=640,height=480,acodec=mp4a,ab=128,channels=2,samplerate=44100}:http{dst=192.168.1.5:8080/stream.flv} :no-sout-rtp-sap :no-sout-standard-sap :sout-keep BTW, I tested it with different webcams, resulting all in the same abnormal behaviour. Binary package hint: vlc Using VLC 1.1.4-1 on Ubuntu 10.10. When I try to stream and transcode from capturing with a webcam, the image in the stream is always stretched vertically. Note that if I select to stream without transcoding, the image, in either case, looks normal. Please keep in mind that this bug seems to be only reproducible with Ubuntu. In Windows everything works as expected. I tried several webcams, with similar results. As it is, streaming from a capture device like a webcam is completely unusable. The cause of the bug (a comprehensive description is given in the upstream report) is due to a interger overflow during transcoding. Basically, the aspect ratio for a 640x320 webcam is given in absolute terms, for example 276480000:276480000 which is equivalent to 1:1, but when multiplied by 640 the result is > 32 bits. The attached patch essentially prevents the overflow by reducing the value of the aspect ratio within 32 bit and by assigning a working value for the aspect ratio of the image after decoding. TEST CASE to reproduce: 0. Make sure you have a webcam attached. 1. Launch vlc 2. press CTRL+C for capture from the webcam using v4l2 3. press ALT+S for streaming 4. select stream to a file (but http will do also) 5. Important: make sure you select a transcoding option. Anyone is good, other than OGG (where this bug seem not to apply). 6. Start the stream and wait a few minutes, before turning the stream OFF. Expected: the file (or http stream) should have an image with the correct aspect ratio. Actual: the video is deformed (in my case vertically elongated. The patch has been extensively tested on test builds on VLC 1.1.4-1ubuntu1 in maverick. No collateral effects are expected.
2010-11-19 06:53:16 Nicola Ferralis description Binary package hint: vlc Using VLC 1.1.4-1 on Ubuntu 10.10. When I try to stream and transcode from capturing with a webcam, the image in the stream is always stretched vertically. Note that if I select to stream without transcoding, the image, in either case, looks normal. Please keep in mind that this bug seems to be only reproducible with Ubuntu. In Windows everything works as expected. I tried several webcams, with similar results. As it is, streaming from a capture device like a webcam is completely unusable. The cause of the bug (a comprehensive description is given in the upstream report) is due to a interger overflow during transcoding. Basically, the aspect ratio for a 640x320 webcam is given in absolute terms, for example 276480000:276480000 which is equivalent to 1:1, but when multiplied by 640 the result is > 32 bits. The attached patch essentially prevents the overflow by reducing the value of the aspect ratio within 32 bit and by assigning a working value for the aspect ratio of the image after decoding. TEST CASE to reproduce: 0. Make sure you have a webcam attached. 1. Launch vlc 2. press CTRL+C for capture from the webcam using v4l2 3. press ALT+S for streaming 4. select stream to a file (but http will do also) 5. Important: make sure you select a transcoding option. Anyone is good, other than OGG (where this bug seem not to apply). 6. Start the stream and wait a few minutes, before turning the stream OFF. Expected: the file (or http stream) should have an image with the correct aspect ratio. Actual: the video is deformed (in my case vertically elongated. The patch has been extensively tested on test builds on VLC 1.1.4-1ubuntu1 in maverick. No collateral effects are expected. Binary package hint: vlc Using VLC 1.1.4-1 on Ubuntu 10.10. When I try to stream and transcode from capturing with a webcam, the image in the stream is always stretched vertically. Note that if I select to stream without transcoding, the image, in either case, looks normal. Please keep in mind that this bug seems to be only reproducible with Ubuntu. In Windows everything works as expected. I tried several webcams, with similar results. As it is, streaming from a capture device like a webcam is completely unusable. The cause of the bug (a comprehensive description is given in the upstream report) is due to a integer overflow during transcoding. Basically, the aspect ratio for a 640x320 webcam is given in absolute terms, for example 276480000:276480000 which is equivalent to 1:1, but when multiplied by 640 the result is > 32 bits. The attached patch essentially prevents the overflow by reducing the value of the aspect ratio within 32 bit and by assigning a working value for the aspect ratio of the image after decoding. TEST CASE to reproduce: 0. Make sure you have a webcam attached. 1. Launch vlc 2. press CTRL+C for capture from the webcam using v4l2 3. press ALT+S for streaming 4. select stream to a file (but http will do also) 5. Important: make sure you select a transcoding option. Anyone is good, other than OGG (where this bug seem not to apply). 6. Start the stream and wait a few minutes, before turning the stream OFF. Expected: the file (or http stream) should have an image with the correct aspect ratio. Actual: the video is deformed (in my case vertically elongated. The patch has been extensively tested on test builds on VLC 1.1.4-1ubuntu1 in maverick. No collateral effects are expected.
2010-11-19 06:53:57 Nicola Ferralis attachment added transcode_aspect_ratio_maverick.diff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1737923/+files/transcode_aspect_ratio_maverick.diff
2010-11-19 06:54:26 Nicola Ferralis attachment added transcode_aspect_ratio_maverick.debdiff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1737924/+files/transcode_aspect_ratio_maverick.debdiff
2010-11-19 07:05:06 Nicola Ferralis bug added subscriber Ubuntu Stable Release Updates Team
2010-11-19 07:06:02 Nicola Ferralis bug added subscriber Ubuntu Sponsors Team
2010-11-19 07:49:33 Micah Gersten nominated for series Ubuntu Maverick
2010-11-19 07:49:33 Micah Gersten bug task added vlc (Ubuntu Maverick)
2010-11-19 07:50:59 Micah Gersten vlc (Ubuntu Maverick): importance Undecided Medium
2010-11-19 07:50:59 Micah Gersten vlc (Ubuntu Maverick): status New Incomplete
2010-11-19 07:50:59 Micah Gersten vlc (Ubuntu Maverick): assignee Nicola Ferralis (feranick)
2010-11-19 07:51:56 Micah Gersten removed subscriber Ubuntu Sponsors Team
2010-11-19 09:10:02 Nicola Ferralis attachment removed transcode_aspect_ratio_maverick.debdiff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1737924/+files/transcode_aspect_ratio_maverick.debdiff
2010-11-19 09:10:25 Nicola Ferralis attachment removed transcode_aspect_ratio_maverick.diff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1737923/+files/transcode_aspect_ratio_maverick.diff
2010-11-19 09:15:31 Nicola Ferralis attachment added transcode_aspect_ratio_maverick.debdiff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1738027/+files/transcode_aspect_ratio_maverick.debdiff
2010-11-19 09:15:59 Nicola Ferralis attachment added transcode_aspect_ratio_maverick.diff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1738029/+files/transcode_aspect_ratio_maverick.diff
2010-11-19 09:17:56 Nicola Ferralis vlc (Ubuntu Maverick): status Incomplete New
2010-11-19 09:18:00 Nicola Ferralis vlc (Ubuntu Maverick): assignee Nicola Ferralis (feranick)
2010-11-19 09:18:25 Nicola Ferralis bug added subscriber Ubuntu Sponsors Team
2010-11-19 09:38:05 Nicola Ferralis attachment added transcode_aspect_ratio_maverick_2.debdiff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1738037/+files/transcode_aspect_ratio_maverick_2.debdiff
2010-11-19 09:38:33 Nicola Ferralis attachment added transcode_aspect_ratio_maverick_2.diff https://bugs.launchpad.net/ubuntu/+source/vlc/+bug/672304/+attachment/1738038/+files/transcode_aspect_ratio_maverick_2.diff
2010-11-19 16:56:52 Micah Gersten vlc (Ubuntu Maverick): status New In Progress
2010-11-19 16:56:52 Micah Gersten vlc (Ubuntu Maverick): assignee Micah Gersten (micahg)
2010-11-19 17:12:07 Micah Gersten removed subscriber Ubuntu Sponsors Team
2010-11-19 19:43:46 Micah Gersten vlc (Ubuntu Maverick): assignee Micah Gersten (micahg)
2010-11-22 09:14:29 Martin Pitt vlc (Ubuntu Maverick): status In Progress Fix Committed
2010-11-22 09:14:35 Martin Pitt bug added subscriber SRU Verification
2010-11-22 09:14:38 Martin Pitt tags patch patch verification-needed
2010-11-23 09:19:22 Martin Pitt tags patch verification-needed patch verification-done
2010-11-24 00:28:41 Launchpad Janitor branch linked lp:ubuntu/maverick-proposed/vlc
2010-11-24 09:41:31 Launchpad Janitor branch linked lp:debian/experimental/vlc
2010-11-24 14:33:08 Bug Watch Updater vlc (Debian): status New Fix Released
2010-11-29 11:28:05 Launchpad Janitor vlc (Ubuntu Maverick): status Fix Committed Fix Released
2011-09-19 21:38:33 Ubuntu Foundations Team Bug Bot tags patch verification-done patch testcase verification-done