vlc fails to build against xulrunner-1.9.2

[Reinhard Tartler]

Binary package hint: vlc

I've uploaded a testbuild and it failed to build with this output:

make[3]: Entering directory `/build/buildd/vlc-1.0.5/projects/mozilla'
/bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -DSYS_LINUX `top_srcdir="../.." top_builddir="../.." ../../vlc-config --cxxflags mozilla` -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -MT libvlcplugin_la-vlcshell.lo -MD -MP -MF .deps/libvlcplugin_la-vlcshell.Tpo -c -o libvlcplugin_la-vlcshell.lo `test -f 'vlcshell.cpp' || echo './'`vlcshell.cpp
/bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -DSYS_LINUX `top_srcdir="../.." top_builddir="../.." ../../vlc-config --cxxflags mozilla` -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -MT libvlcplugin_la-vlcplugin.lo -MD -MP -MF .deps/libvlcplugin_la-vlcplugin.Tpo -c -o libvlcplugin_la-vlcplugin.lo `test -f 'vlcplugin.cpp' || echo './'`vlcplugin.cpp
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -DSYS_LINUX -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DHAVE_RELEASE -DXP_UNIX -DOJI -DMOZ_X11 -DSYS_LINUX -fshort-wchar -I/usr/include/xulrunner-1.9.2.2 -I/usr/include/xulrunner-1.9.2.2/nspr -I/usr/include/nspr -O2 -ffast-math -funroll-loops -mtune=pentium2 -fomit-frame-pointer -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -MT libvlcplugin_la-vlcplugin.lo -MD -MP -MF .deps/libvlcplugin_la-vlcplugin.Tpo -c vlcplugin.cpp -fPIC -DPIC -o .libs/libvlcplugin_la-vlcplugin.o
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -DSYS_LINUX -D_FILE_OFFSET_BITS=64 -D__USE_UNIX98 -D_LARGEFILE64_SOURCE -D_REENTRANT -D_THREAD_SAFE -DHAVE_RELEASE -DXP_UNIX -DOJI -DMOZ_X11 -DSYS_LINUX -fshort-wchar -I/usr/include/xulrunner-1.9.2.2 -I/usr/include/xulrunner-1.9.2.2/nspr -I/usr/include/nspr -O2 -ffast-math -funroll-loops -mtune=pentium2 -fomit-frame-pointer -DDATA_PATH=\"/usr/share/vlc\" -g -O2 -MT libvlcplugin_la-vlcshell.lo -MD -MP -MF .deps/libvlcplugin_la-vlcshell.Tpo -c vlcshell.cpp -fPIC -DPIC -o .libs/libvlcplugin_la-vlcshell.o
In file included from vlcplugin.cpp:35:
vlcplugin.h:85: error: 'uint16' has not been declared
vlcplugin.h:138: error: 'uint16' does not name a type
vlcplugin.cpp:43: error: 'uint16' has not been declared
vlcplugin.cpp: In constructor 'VlcPlugin::VlcPlugin(NPP_t*, int)':
vlcplugin.cpp:44: error: class 'VlcPlugin' does not have any field named 'i_npmode'
vlcplugin.cpp: In member function 'NPError VlcPlugin::init(int, char* const*, char* const*)':
vlcplugin.cpp:230: error: 'struct NPString' has no member named 'utf8characters'
vlcplugin.cpp:231: error: 'struct NPString' has no member named 'utf8length'
vlcplugin.cpp:239: error: 'struct _NPString' has no member named 'utf8length'
vlcplugin.cpp:239: error: 'malloc' was not declared in this scope
In file included from vlcshell.cpp:44:
vlcplugin.h:85: error: 'uint16' has not been declared
vlcplugin.cpp:242: error: 'struct _NPString' has no member named 'utf8characters'
vlcplugin.cpp:242: error: 'struct _NPString' has no member named 'utf8length'
vlcplugin.cpp:243: error: 'struct _NPString' has no member named 'utf8length'
vlcplugin.h:138: error: 'uint16' does not name a type
In file included from vlcshell.cpp:45:
vlcshell.h:30: error: 'jref' does not name a type
vlcshell.h:33: error: 'uint16' has not been declared
vlcshell.h:33: error: 'int16' has not been declared
vlcshell.h:43: error: 'uint16' has not been declared
vlcshell.h:47: error: 'int32' does not name a type
vlcshell.h:48: error: 'int32' does not name a type
vlcplugin.cpp: In destructor 'virtual VlcPlugin::~VlcPlugin()':
vlcplugin.cpp:267: error: 'free' was not declared in this scope
vlcshell.cpp:268: error: 'jref' does not name a type
vlcshell.cpp:278: error: 'uint16' has not been declared
vlcshell.cpp:278: error: 'int16' has not been declared
vlcshell.cpp: In function 'NPError NPP_SetWindow(NPP_t*, NPWindow*)':
vlcshell.cpp:534: warning: 'void libvlc_video_set_parent(libvlc_instance_t*, libvlc_drawable_t, libvlc_exception_t*)' is deprecated (declared at ../../include/vlc/deprecated.h:85)
vlcshell.cpp:534: warning: 'void libvlc_video_set_parent(libvlc_instance_t*, libvlc_drawable_t, libvlc_exception_t*)' is deprecated (declared at ../../include/vlc/deprecated.h:85)
vlcshell.cpp:558: warning: 'void libvlc_video_set_parent(libvlc_instance_t*, libvlc_drawable_t, libvlc_exception_t*)' is deprecated (declared at ../../include/vlc/deprecated.h:85)
vlcshell.cpp:558: warning: 'void libvlc_video_set_parent(libvlc_instance_t*, libvlc_drawable_t, libvlc_exception_t*)' is deprecated (declared at ../../include/vlc/deprecated.h:85)
vlcshell.cpp: At global scope:
vlcshell.cpp:582: error: 'uint16' has not been declared
vlcshell.cpp:611: error: 'int32' does not name a type
vlcshell.cpp:617: error: 'int32' does not name a type
vlcplugin.cpp: In member function 'char* VlcPlugin::getAbsoluteURL(const char*)':
vlcplugin.cpp:473: error: 'malloc' was not declared in this scope
vlcplugin.cpp:518: error: 'free' was not declared in this scope
vlcplugin.cpp: In member function 'void VlcPlugin::showToolbar()':
vlcplugin.cpp:616: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:623: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:632: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:640: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:648: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:656: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:664: warning: deprecated conversion from string constant to 'char*'
vlcplugin.cpp:671: warning: deprecated conversion from string constant to 'char*'
make[3]: *** [libvlcplugin_la-vlcshell.lo] Error 1
make[3]: *** Waiting for unfinished jobs....

full buildlog at http://launchpadlibrarian.net/43469510/buildlog_ubuntu-lucid-i386.vlc_1.0.5-2ubuntu1+ppa1_FAILEDTOBUILD.txt.gz

[Reinhard Tartler (siretart)]

as discussed on irc:

08:06 <micahg> siretart: will you be looking into the vlc build failure, bjsnider gave me a patch earlier which I was going to try over the weekend to port it to xul192
08:09 <siretart> micahg: I just noticed the build failure, but am currently very short on time
08:09 <siretart> micahg: if you could just fix it, that would be really great!
08:09 <micahg> siretart: ok, so I'll take it then
08:09 <siretart> thanks

[Micah Gersten (micahg)]

Moving back to High as this does have security issues and could need to be patched in a hurry.

[Micah Gersten (micahg)]

Sorry, I meant this package has a tendency for security issues, not that there are currently any out there.

[Micah Gersten (micahg)]

This should be the upstream commits on vlc 1.1.0 rebased when necessary for vlc 1.0.5 related to xulrunner-1.9.2 migration.

[Micah Gersten (micahg)]

Test build here:
https://launchpad.net/~mozillateam/+archive/ffox35/+sourcepub/1075029/+listing-archive-extra

[Brandon Holtsclaw (imbrandon)]

I Sponsored this upload per pitti:

01:51 < micahg> pitti: could I trouble you for an FFe to fix the vlc FTBFS against xulrunner-1.9.2 (bug 558981)
01:51 < ubottu> Launchpad bug 558981 in vlc "vlc fails to build against xulrunner-1.9.2" [High,Confirmed]
                https://launchpad.net/bugs/558981
01:53 < pitti> micahg: this isn't an FFE, just a bug fix, so please go ahead

[Launchpad Janitor (janitor)]

This bug was fixed in the package vlc - 1.0.5-2ubuntu2

---------------
vlc (1.0.5-2ubuntu2) lucid; urgency=low

  * Add patches to fix FTBFS with xulruner-1.9.2 from upstream (LP: #558981)
    - add debian/patches/519-Typedef-changes-from-xulrunner-1.9.1.patch
    - add debian/patches/520-Don-t-hardcode-OJI-define-deprecated-xith-libxul-1.9.patch
    - add debian/patches/521-Untracked-API-change-utf8-to-UTF8.patch
    - add debian/patches/522-Mozilla-do-not-hard-code-autoconf-file-descriptors.patch
    - add debian/patches/523-Require-xul-1.9.2-explicitly.patch
    - add debian/patches/524-Mozilla-More-fixes-for-XulRunner-1.9.2.patch
    - add debian/patches/525-Mozilla-more-fixes.patch
    - add debian/patches/526-Mozilla-More-final-Win32-compile-fixes-for-XulRunner.patch
  * Add patch to drop OJI support as xulrunner-1.9.2 on Linux doesn't support it
    - add debian/patches/600-drop-OJI-xul-192.patch
 -- Micah Gersten <email address hidden> Tue, 13 Apr 2010 10:09:58 -0500