please drop virtualbox-guest-dkms virtualbox-guest-source

Bug #1933248 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned
virtualbox (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned
virtualbox-hwe (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Invalid
Undecided
Unassigned

Bug Description

[Impact]

 * virtualbox guest modules have graduated into the upstream vanilla kernel, since at least v5.4 / Ubuntu 20.04

 * These guest modules are no longer needed in dkms or source form, as they are always available from all kernel flavours, including when the packages are backported to Ubuntu 20.04.

 * Thus we should stop shipping them, and instead rely on the upstream ones.

[Test Plan]

 * Boot virtualbox images
 * Check that guest-modules based integration still works.

[Where problems could occur]

 * There might be differences between the linux kernel provided modules, guest userspace & host userspace tooling. If there are any differences, we would have to resolve the issues as needed to maintain backwards & forwards compatibility.

[Other Info]

 * virtualbox guest modules fail to build from source with recent kernels.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Ack thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package virtualbox-hwe - 6.1.22-dfsg-3ubuntu1.21.10.1

---------------
virtualbox-hwe (6.1.22-dfsg-3ubuntu1.21.10.1) impish; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (6.1.22-dfsg-3) unstable; urgency=medium

  [ Dimitri John Ledkov ]
  * Drop virtualbox guest modules dkms and sources, as in Ubuntu and Debian,
    all kernel flavours provide those from the upstream kernel since at least
    focal 20.04 LTS.
    Thus these are not needed anymore. LP: #1933248

 -- Gianfranco Costamagna <email address hidden> Mon, 19 Jul 2021 09:32:02 +0200

Changed in virtualbox-hwe (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package virtualbox - 6.1.22-dfsg-3

---------------
virtualbox (6.1.22-dfsg-3) unstable; urgency=medium

  [ Dimitri John Ledkov ]
  * Drop virtualbox guest modules dkms and sources, as in Ubuntu and Debian,
    all kernel flavours provide those from the upstream kernel since at least
    focal 20.04 LTS.
    Thus these are not needed anymore. LP: #1933248

 -- Gianfranco Costamagna <email address hidden> Mon, 19 Jul 2021 09:28:22 +0200

Changed in virtualbox (Ubuntu):
status: New → Fix Released
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

This change impacts the build of focal/linux as we use the dkms package for building updated modules.

Changed in linux (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Focal):
status: New → Confirmed
Changed in virtualbox (Ubuntu Focal):
status: New → Invalid
Changed in virtualbox-hwe (Ubuntu Focal):
status: New → Invalid
Changed in linux (Ubuntu Focal):
status: Confirmed → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I was not expecting for focal/linux to change. This change was expected to be done in impish/linux only.

How can I figure out why this was done in focal/linux?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

linux (5.4.0-87.98) focal; urgency=medium

  * please drop virtualbox-guest-dkms virtualbox-guest-source (LP: #1933248)
    - [Config] Disable virtualbox dkms build

Disabled do_dkms_vbox, because src:virtualbox got srued into Focal which no longer provides virtualbox-guest-dkms

I fear/wonder if this will cause regressions for virtualbox, in case previous v5.4 kernel had newer/better/different vbox guest modules versus what will be available now.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

   reading old modules...
      MISS: vboxguest (ignored)
      MISS: vboxsf (ignored)

In the current kerenl. So it appears that building with a dkms module got dropped, and yet the guest modules from upstream code have not been built either.

And i am able to reproduce https://bugs.launchpad.net/cloud-images/+bug/1939580

tags: added: verification-failed-focal
removed: verification-needed-focal
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

./fs/vboxsf is not available in v5.4 kernel.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

$ git describe 0fd1695766
v5.5-rc6-150-g0fd1695766

0fd1695766 fs: Add VirtualBox guest shared folder (vboxsf) support

tags: added: block-proposed-focal
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
Changed in linux (Ubuntu Focal):
status: Fix Committed → Triaged
Changed in linux (Ubuntu Focal):
status: Triaged → Fix Committed
Revision history for this message
Kelsey Skunberg (kelsey-skunberg) wrote :

Removing tags `block-proposed-focal verification-failed-focal`. Commit in Focal was reverted.

tags: removed: block-proposed-focal verification-failed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (34.1 KiB)

This bug was fixed in the package linux - 5.4.0-88.99

---------------
linux (5.4.0-88.99) focal; urgency=medium

  * focal/linux: 5.4.0-88.99 -proposed tracker (LP: #1944747)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2021.09.06)

  * please drop virtualbox-guest-dkms virtualbox-guest-source (LP: #1933248)
    - Revert "UBUNTU: [Config] Disable virtualbox dkms build"

linux (5.4.0-87.98) focal; urgency=medium

  * please drop virtualbox-guest-dkms virtualbox-guest-source (LP: #1933248)
    - [Config] Disable virtualbox dkms build

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2021.09.06)

  * LRMv5: switch primary version handling to kernel-versions data set
    (LP: #1928921)
    - [Packaging] switch to kernel-versions

  * disable “CONFIG_HISI_DMA” config for ubuntu version (LP: #1936771)
    - Disable CONFIG_HISI_DMA
    - [Config] Record hisi_dma no longer built for arm64

  * memory leaking when removing a profile (LP: #1939915)
    - apparmor: Fix memory leak of profile proxy

  * CryptoExpress EP11 cards are going offline (LP: #1939618)
    - s390/zcrypt: Support for CCA protected key block version 2
    - s390: Replace zero-length array with flexible-array member
    - s390/zcrypt: Use scnprintf() for avoiding potential buffer overflow
    - s390/zcrypt: replace snprintf/sprintf with scnprintf
    - s390/ap: Remove ap device suspend and resume callbacks
    - s390/zcrypt: use fallthrough;
    - s390/zcrypt: use kvmalloc instead of kmalloc for 256k alloc
    - s390/ap: remove power management code from ap bus and drivers
    - s390/ap: introduce new ap function ap_get_qdev()
    - s390/zcrypt: use kzalloc
    - s390/zcrypt: fix smatch warnings
    - s390/zcrypt: code beautification and struct field renames
    - s390/zcrypt: split ioctl function into smaller code units
    - s390/ap: rename and clarify ap state machine related stuff
    - s390/zcrypt: provide cex4 cca sysfs attributes for cex3
    - s390/ap: rework crypto config info and default domain code
    - s390/zcrypt: simplify cca_findcard2 loop code
    - s390/zcrypt: remove set_fs() invocation in zcrypt device driver
    - s390/ap: remove unnecessary spin_lock_init()
    - s390/zcrypt: Support for CCA APKA master keys
    - s390/zcrypt: introduce msg tracking in zcrypt functions
    - s390/ap: split ap queue state machine state from device state
    - s390/ap: add error response code field for ap queue devices
    - s390/ap: add card/queue deconfig state
    - s390/sclp: Add support for SCLP AP adapter config/deconfig
    - s390/ap: Support AP card SCLP config and deconfig operations
    - s390/ap/zcrypt: revisit ap and zcrypt error handling
    - s390/zcrypt: move ap_msg param one level up the call chain
    - s390/zcrypt: Introduce Failure Injection feature
    - s390/zcrypt: fix wrong format specifications
    - s390/ap: fix ap devices reference counting
    - s390/zcrypt: return EIO when msg retry limit reached
    - s390/zcrypt: fix zcard and zqueue hot-unplug memleak
    - s390/ap: Fix hanging ioctl caused by wrong msg counter

  * memfd from ubuntu_kernel_s...

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-kvm/5.4.0-1048.50 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-5.4/5.4.0-89.100~18.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Confirmed that linux-hwe-5.4/5.4.0-89.100~18.04.1 kernel in -proposed built the vbox_* modules from virtualbox-guest-dkms_6.1.22-dfsg-2~ubuntu1.20.04.1_all.deb, which restored the behavior as expected.

tags: added: verification-done-bionic
removed: verification-needed-bionic
Revision history for this message
Tim Gardner (timg-tpi) wrote :

do_dkms_vbox is not set in Ubuntu-aws-5.4.0-1058.61 debian.aws. Tagging verification-done-focal

tags: added: verification-done-focal
removed: verification-needed-focal
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers