virtualbox 5.2.16-dfsg-3build1 ADT test failure with linux 4.18.0-5.6

[Seth Forshee]

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/amd64/v/virtualbox/20180816_133408_b1337@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/i386/v/virtualbox/20180816_134629_b1337@/log.gz

[Gianfranco Costamagna (costamagnagianfranco)]

I don't see any failure in the log.

[Seth Forshee (sforshee)]

I don't know why there are two make.log files attached, but the second one definitely has errors.

/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c: In function ‘sf_init_inode’:
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:165:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_atime, &info->AccessTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:166:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_ctime, &info->ChangeTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:167:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_mtime, &info->ModificationTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c: In function ‘sf_setattr’:
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:377:54: error: passing argument 2 of ‘sf_timespec_from_ftime’ from incompatible pointer type [-Werror=incompatible-pointer-types]
             sf_timespec_from_ftime(&info.AccessTime, &iattr->ia_atime);
                                                      ^~~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:63:69: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_timespec_from_ftime(RTTIMESPEC *ts, struct timespec *tv)
                                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:379:60: error: passing argument 2 of ‘sf_timespec_from_ftime’ from incompatible pointer type [-Werror=incompatible-pointer-types]
             sf_timespec_from_ftime(&info.ModificationTime, &iattr->ia_mtime);
                                                            ^~~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.16/build/vboxsf/utils.c:63:69: note: expected ‘struct timespec *’ but argument is of type ‘struc...

[Seth Forshee (sforshee)]

Indeed, looking at the artifacts revelas that the vbox-guest dkms builds failed for amd64 and i386.

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/amd64/v/virtualbox/20180816_133408_b1337@/artifacts.tar.gz
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/i386/v/virtualbox/20180816_134629_b1337@/artifacts.tar.gz

[Gianfranco Costamagna (costamagnagianfranco)]

Can you please try vbox from my ppa?
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+packages

5.2.18 is already out since some days!

[Seth Forshee (sforshee)]

Sorry, I guess I missed the last comment. Seems to still be failing with 5.2.18-dfsg-1 from cosmic-release though.

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/amd64/v/virtualbox/20180824_183905_b1337@/log.gz
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic-canonical-kernel-team-unstable/cosmic/amd64/v/virtualbox/20180824_183905_b1337@/artifacts.tar.gz

/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c: In function ‘sf_init_inode’:
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:165:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_atime, &info->AccessTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:166:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_ctime, &info->ChangeTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:167:28: error: passing argument 1 of ‘sf_ftime_from_timespec’ from incompatible pointer type [-Werror=incompatible-pointer-types]
     sf_ftime_from_timespec(&inode->i_mtime, &info->ModificationTime);
                            ^~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:53:53: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_ftime_from_timespec(struct timespec *tv, RTTIMESPEC *ts)
                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c: In function ‘sf_setattr’:
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:377:54: error: passing argument 2 of ‘sf_timespec_from_ftime’ from incompatible pointer type [-Werror=incompatible-pointer-types]
             sf_timespec_from_ftime(&info.AccessTime, &iattr->ia_atime);
                                                      ^~~~~~~~~~~~~~~~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:63:69: note: expected ‘struct timespec *’ but argument is of type ‘struct timespec64 *’
 static void sf_timespec_from_ftime(RTTIMESPEC *ts, struct timespec *tv)
                                                    ~~~~~~~~~~~~~~~~~^~
/var/lib/dkms/virtualbox-guest/5.2.18/build/vboxsf/utils.c:379:60: error: passing argument 2 of ‘sf_timespec_from_ftime’ from incompatible pointer type [...

[Gianfranco Costamagna (costamagnagianfranco)]

can you please try the one on my ppa?
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+sourcepub/9341040/+listing-archive-extra

[Seth Forshee (sforshee)]

All the kernel modules contained in the virtualbox-guest-dkms from the ppa built fine with 4.18. Thanks!

[Gianfranco Costamagna (costamagnagianfranco)]

lets upload in the archive!

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox - 5.2.18-dfsg-2

---------------
virtualbox (5.2.18-dfsg-2) unstable; urgency=medium

  * debian/patches/kernel-4.18.patch:
    - Fix build with kernel 4.18 (LP: #1787441)

 -- Gianfranco Costamagna <email address hidden> Fri, 17 Aug 2018 17:02:22 +0200

[Łukasz Zemczak (sil2100)]

Hello Seth, or anyone else affected,

Accepted virtualbox into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox/5.2.18-dfsg-2~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Seth, or anyone else affected,

Accepted virtualbox-hwe into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox-hwe/5.2.18-dfsg-3~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Thadeu Lima de Souza Cascardo (cascardo)]

(bionic-amd64)root@calabresa:/home/cascardo/ubuntu/oss4# apt-cache policy virtualbox-dkms
virtualbox-dkms:
  Installed: 5.2.18-dfsg-2~ubuntu18.04.1
  Candidate: 5.2.18-dfsg-2~ubuntu18.04.1
  Version table:
 *** 5.2.18-dfsg-2~ubuntu18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/multiverse amd64 Packages
        100 /var/lib/dpkg/status
     5.2.10-dfsg-6ubuntu18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/multiverse amd64 Packages
     5.2.10-dfsg-6 500
        500 http://archive.ubuntu.com/ubuntu bionic/multiverse amd64 Packages
(bionic-amd64)root@calabresa:/home/cascardo/ubuntu/oss4# ls /lib/modules/4.18.0-11-generic/updates/dkms/vbox*ko
/lib/modules/4.18.0-11-generic/updates/dkms/vboxdrv.ko /lib/modules/4.18.0-11-generic/updates/dkms/vboxnetflt.ko
/lib/modules/4.18.0-11-generic/updates/dkms/vboxnetadp.ko /lib/modules/4.18.0-11-generic/updates/dkms/vboxpci.ko
(bionic-amd64)root@calabresa:/home/cascardo/ubuntu/oss4#

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for virtualbox has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox - 5.2.18-dfsg-2~ubuntu18.04.1

---------------
virtualbox (5.2.18-dfsg-2~ubuntu18.04.1) bionic; urgency=medium

  * SRU the latest cosmic package for bionic (LP: #1796543)

virtualbox (5.2.18-dfsg-2) unstable; urgency=medium

  * debian/patches/kernel-4.18.patch:
    - Fix build with kernel 4.18 (LP: #1787441)

virtualbox (5.2.18-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.18-dfsg
  * Patch refresh
  * Bump std-version to 4.2.0.1, no changes required

virtualbox (5.2.16-dfsg-3) unstable; urgency=medium

  * from: Kevin Puetz:
    - patch to avoid virtualbox guest utils run if no virtual machines are detected.

virtualbox (5.2.16-dfsg-2) unstable; urgency=medium

  * Allow new gcc8 to build

virtualbox (5.2.16-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.16-dfsg, patch refresh
  * Drop now upstreamed patches: {fix-build,plt-upstream-fix,videorec}.patch
  * Bump std-version to 4.1.5, no changes required
  * Drop now-useless --enable-system-libopus switch

virtualbox (5.2.14-dfsg-7) unstable; urgency=medium

  * Add again libopus hack in rules file, this might be dropped
    in next upstream release

virtualbox (5.2.14-dfsg-6) unstable; urgency=medium

  [ Jan Nordoholz ]
  * Refresh patch to make it really work.

virtualbox (5.2.14-dfsg-5) unstable; urgency=medium

  * Reupload with upstream patch + some minor modifications to fix the issue
    again. (Closes: #902897)

virtualbox (5.2.14-dfsg-4) unstable; urgency=medium

  * Update with new upstream accepted patch.

virtualbox (5.2.14-dfsg-3) unstable; urgency=low

  [ Gianfranco Costamagna ]
  * Tweak python patch to make it compatible with Python3.7
  * Tweak previous changelog entry

  [ Will Thompson ]
  * guest-utils.service: add ConditionVirtualization=oracle

virtualbox (5.2.14-dfsg-2) unstable; urgency=low

  * Try to fix issue with new binutils (Closes: #902897)
    - thanks Jan Christoph Nordholz for the great help and fix!

virtualbox (5.2.14-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.14-dfsg
  * Drop kernel and acpica patches

virtualbox (5.2.12-dfsg-3) unstable; urgency=medium

  * debian/patches/fixes_for_4.17.patch
    from opensuse: fix build with kernel 4.17 (LP: #1776671)

virtualbox (5.2.12-dfsg-2) unstable; urgency=medium

  * Ignore new acpica-unix syntax, and sed the new aml syntax to the old
    aml working paradigm. A real fix might require:
    - a revert of acpica-unix code
    - a fallback code or switch in acpica-unix
    - changing vbox filenames to some correct C syntax
    For now, better rename the resulting structure to the old way, taking the
    approach from FreeBSD patch. (See bug: #899318)

virtualbox (5.2.12-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.12-dfsg
  * Patch refresh, drop upstream patches:
    GL-fixes.patch, vm-restore.patch, 71985.patch

virtualbox (5.2.10-dfsg-7) unstable; urgency=medium

  * debian/patches/71985.patch: add compatibility with upstream
    kernel 4.16 patch (Closes: #897928)
    thanks James McCoy for the bug report!

 -- Gianfranco Costamagna <email address hidden> Wed, 10 Oct 2018 15:27:01 +0200