| 2019-07-05 21:09:33 |
Connor Kuehl |
bug |
|
|
added bug |
| 2019-07-05 21:09:44 |
Connor Kuehl |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-07-05 21:09:44 |
Connor Kuehl |
bug task added |
|
virtualbox-hwe (Ubuntu Bionic) |
|
| 2019-07-05 21:09:48 |
Connor Kuehl |
virtualbox-hwe (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-07-05 21:09:50 |
Connor Kuehl |
virtualbox-hwe (Ubuntu Bionic): importance |
Undecided |
Medium |
|
| 2019-07-05 21:09:52 |
Connor Kuehl |
virtualbox-hwe (Ubuntu Bionic): assignee |
|
Connor Kuehl (connork) |
|
| 2019-07-08 02:03:09 |
Daniel van Vugt |
summary |
virtualbox-guest-dkms-hwe 5.2.18-dfsg-3~ubuntu18.04.3 fails to build on 5.0 based kernels |
virtualbox-guest-dkms-hwe 5.2.18-dfsg-3~ubuntu18.04.3 fails to build on 5.0 based kernels [In function ‘VBoxGuest_RTR0MemUserIsValidAddr’: error: macro "access_ok" passed 3 arguments, but takes just 2] |
|
| 2019-07-10 19:54:46 |
Connor Kuehl |
attachment added |
|
virtualbox-hwe_5.2.18-dfsg-3~ubuntu18.04.4.debdiff https://bugs.launchpad.net/ubuntu/+source/virtualbox-hwe/+bug/1835576/+attachment/5276162/+files/virtualbox-hwe_5.2.18-dfsg-3~ubuntu18.04.4.debdiff |
|
| 2019-07-10 19:55:22 |
Connor Kuehl |
description |
The Bionic HWE Edge kernels run on 5.0. Some compilation errors are expected due to the API changes between 4.15 and 5.0. One can see one such error here when trying to install the package on the HWE edge kernel in Bionic: https://paste.ubuntu.com/p/Bf4KQwjfgX/ |
[Impact]
* virtualbox-guest-dkms-hwe fails to build on 5.0 kernels. This affects Bionic because the Bionic HWE Edge kernels are based on 5.0. virtualbox-guest-dkms-hwe cannot be installed successfully since the DKMS module can't be compiled due to API changes introduced between Linux 4.15 and 5.0.
[Test Case]
* Install the HWE Edge kernel on Bionic:
- `sudo apt install linux-generic-hwe-18.04-edge`
* Reboot into the new kernel (you should be on a 5.0 kernel now)
* Try installing `virtualbox-guest-dkms-hwe` (`sudo apt install virtualbox-guest-dkms-hwe`)
- Expected result: package installs successfully, module can be viewed with `sudo dkms status`
- Actual result: Installation fails due to compilation errors when building the DKMS module.
[Testing]
These steps were performed in an amd64 virtual machine installed from a Bionic cloud image.
* Create a .deb with the .debdiff attached to comment #1
- Uncomment the `deb-src` lines in /etc/apt/sources.list
- `sudo apt build-dep virtualbox-hwe`
- `pull-lp-source virtualbox-hwe bionic`
- `cd virtualbox-hwe` (it will be a longer, but similar name to that)
- `patch -p1 < path/to/patch.debdiff`
- `quilt push -a`
- `debuild -b -us -uc` (note: this build can take some time)
* Install `dkms`
- `sudo apt install dkms`
== On the stock 4.15 Ubuntu kernel ==
* Install the .deb you prepared in the first step.
- `sudo dpkg --install path-to-file.deb`
- Confirm that it installs successfully (as you are running the 4.15 Ubuntu kernel)
* Install the 5.0 edge kernel
- `sudo apt install linux-generic-hwe-18.04-edge`
* As part of the installation of the new kernel, the active virtualbox DKMS module should be rebuilt. If it is not, remove uninstall the package `sudo apt remove virtualbox-guest-dkms-hwe`, reboot into the new 5.0 kernel, and perform the install step on your .deb again and confirm it installs correctly without compilation failures.
[Regression Potential]
These changes are conditionally compiled depending on the kernel version. The only exception to this is the addition of an inlined function for operating on timespec64. That is conditionally compiled based on whether the kernel has timespec64, not necessarily just on the kernel version.
However, there are a large number of changes and to keep it manageable, some backporting was required as there were a couple of patches that were based on previous revisions that had undergone large code cleanups (no logic changes, just refactorings and updating certain error paths). These backports were limited to surgically updating the call sites with the new API compatibility wrappers introduced by the patch or a small update to the Makefile so a header file can be located once again. I believe these changes are logically equivalent to what they were before, but this time, compileable since they use the new interfaces/wrappers added by the upstream developers.
Original bug description follows:
-----------------------------------
The Bionic HWE Edge kernels run on 5.0. Some compilation errors are expected due to the API changes between 4.15 and 5.0. One can see one such error here when trying to install the package on the HWE edge kernel in Bionic: https://paste.ubuntu.com/p/Bf4KQwjfgX/ |
|
| 2019-07-10 19:55:49 |
Connor Kuehl |
virtualbox-hwe (Ubuntu): status |
New |
Invalid |
|
| 2019-07-13 20:18:28 |
Gianfranco Costamagna |
virtualbox-hwe (Ubuntu): status |
Invalid |
Fix Released |
|
| 2019-07-13 20:18:37 |
Gianfranco Costamagna |
bug task added |
|
virtualbox (Ubuntu) |
|
| 2019-07-13 20:18:50 |
Gianfranco Costamagna |
bug task added |
|
virtualbox-ext-pack (Ubuntu) |
|
| 2019-07-13 20:19:03 |
Gianfranco Costamagna |
bug task added |
|
virtualbox-guest-additions-iso (Ubuntu) |
|
| 2019-07-13 20:20:38 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2019-07-13 20:20:48 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2019-07-14 16:56:26 |
Larry Reid |
bug |
|
|
added subscriber Larry Reid |
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox (Ubuntu): status |
New |
Confirmed |
|
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox-ext-pack (Ubuntu): status |
New |
Confirmed |
|
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox-guest-additions-iso (Ubuntu): status |
New |
Confirmed |
|
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox-ext-pack (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2019-07-14 16:58:57 |
Launchpad Janitor |
virtualbox-guest-additions-iso (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2019-07-25 15:44:47 |
Łukasz Zemczak |
virtualbox (Ubuntu Bionic): status |
Confirmed |
Fix Committed |
|
| 2019-07-25 15:44:49 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-07-25 15:44:51 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2019-07-25 15:44:53 |
Łukasz Zemczak |
tags |
patch |
patch verification-needed verification-needed-bionic |
|
| 2019-07-25 15:58:51 |
Łukasz Zemczak |
virtualbox-hwe (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-07-25 16:01:21 |
Łukasz Zemczak |
virtualbox-ext-pack (Ubuntu Bionic): status |
Confirmed |
Fix Committed |
|
| 2019-07-25 16:02:25 |
Łukasz Zemczak |
virtualbox-guest-additions-iso (Ubuntu Bionic): status |
Confirmed |
Fix Committed |
|
| 2019-07-25 16:03:52 |
Łukasz Zemczak |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2019-07-27 04:37:44 |
Mathew Hodson |
virtualbox (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2019-07-27 04:38:38 |
Mathew Hodson |
virtualbox-ext-pack (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2019-07-27 04:38:43 |
Mathew Hodson |
virtualbox-guest-additions-iso (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2019-07-29 06:44:55 |
Gianfranco Costamagna |
tags |
patch verification-needed verification-needed-bionic |
patch verification-done verification-done-bionic |
|
| 2019-08-01 07:27:23 |
Rafael Jesus Alcantara Perez |
bug |
|
|
added subscriber Rafael Jesus Alcantara Perez |
| 2019-08-02 11:29:12 |
PATRIK HEDSTRÖM |
bug |
|
|
added subscriber PATRIK HEDSTRÖM |
| 2019-08-03 20:32:37 |
Launchpad Janitor |
virtualbox (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2574 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2656 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2657 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2678 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2679 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2680 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2690 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2696 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2703 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2721 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2722 |
|
| 2019-08-03 20:32:37 |
Launchpad Janitor |
cve linked |
|
2019-2723 |
|
| 2019-08-03 20:32:57 |
Andy Whitcroft |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-08-03 20:33:08 |
Launchpad Janitor |
virtualbox-ext-pack (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-08-03 20:33:13 |
Launchpad Janitor |
virtualbox-guest-additions-iso (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-08-03 20:33:03 |
Launchpad Janitor |
virtualbox-hwe (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
