[SRU] virtualbox-dkms 5.2.10-dfsg-6ubuntu18.04.1: virtualbox kernel module failed to build [error: implicit declaration of function ‘pci_get_bus_and_slot’]

[Abel Losada Esperante]

[Impact]
* As usual, new hwe screwed up vbox.
  new java, new binutils, new graphic drivers, new kernel

[Test Case]
* Install bionic, install hwe and hwe-edge, check if everything is good again

[ autopkgtests ]
* this package has a really huge autopkgtest suite performed by upstream on each release, and this is the reason for me using the new release as-is instead of patching old versions.

[Regression Potential]
* This is part of virtualbox on Debian and Ubuntu since cosmic

Job for virtualbox.service failed because the control process exited with error code.
See "systemctl status virtualbox.service" and "journalctl -xe" for details.
invoke-rc.d: initscript virtualbox, action "restart" failed.
● virtualbox.service - LSB: VirtualBox Linux kernel module
   Loaded: loaded (/etc/init.d/virtualbox; generated)
   Active: failed (Result: exit-code) since Sun 2018-10-07 11:02:54 CEST; 14ms ago
     Docs: man:systemd-sysv-generator(8)
  Process: 4481 ExecStart=/etc/init.d/virtualbox start (code=exited, status=1/FAILURE)

oct 07 11:02:54 bionichell systemd[1]: Starting LSB: VirtualBox Linux kernel module...
oct 07 11:02:54 bionichell virtualbox[4481]: * Loading VirtualBox kernel modules...
oct 07 11:02:54 bionichell virtualbox[4481]: * No suitable module for running kernel found
oct 07 11:02:54 bionichell virtualbox[4481]: ...fail!
oct 07 11:02:54 bionichell systemd[1]: virtualbox.service: Control process exited, code=exited status=1
oct 07 11:02:54 bionichell systemd[1]: virtualbox.service: Failed with result 'exit-code'.
oct 07 11:02:54 bionichell systemd[1]: Failed to start LSB: VirtualBox Linux kernel module.

ProblemType: Package
DistroRelease: Ubuntu 18.04
Package: virtualbox-dkms 5.2.10-dfsg-6ubuntu18.04.1
ProcVersionSignature: Ubuntu 4.18.0-8.9~18.04.1-generic 4.18.7
Uname: Linux 4.18.0-8-generic x86_64
NonfreeKernelModules: wl
ApportVersion: 2.20.9-0ubuntu7.4
Architecture: amd64
DKMSKernelVersion: 4.18.0-8-generic
Date: Sun Oct 7 11:02:23 2018
DuplicateSignature: dkms:virtualbox-dkms:5.2.10-dfsg-6ubuntu18.04.1:/var/lib/dkms/virtualbox/5.2.10/build/vboxpci/linux/VBoxPci-linux.c:92:40: error: implicit declaration of function ‘pci_get_bus_and_slot’; did you mean ‘pci_get_domain_bus_and_slot’? [-Werror=implicit-function-declaration]
InstallationDate: Installed on 2018-10-06 (0 days ago)
InstallationMedia: Ubuntu 18.04.1 LTS "Bionic Beaver" - Release amd64 (20180725)
PackageArchitecture: all
PackageVersion: 5.2.10-dfsg-6ubuntu18.04.1
Python3Details: /usr/bin/python3.6, Python 3.6.6, python3-minimal, 3.6.5-3ubuntu1
PythonDetails: /usr/bin/python2.7, Python 2.7.15rc1, python-minimal, 2.7.15~rc1-1
RelatedPackageVersions:
 dpkg 1.19.0.5ubuntu2
 apt 1.6.5
SourcePackage: virtualbox
Title: virtualbox-dkms 5.2.10-dfsg-6ubuntu18.04.1: virtualbox kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)

[Gianfranco Costamagna (costamagnagianfranco)]

this fixes the kernel issues, as well as the new java9-10-11 incompatibilities, CVE fixes and new binutils fixes, and should go in bionic together with the proposed kernel, to avoid people complains.

I could copy-paste the very same template as the previous SRU microreleases, in this case the delta is not even that huge (lots of merged patches)

[Gianfranco Costamagna (costamagnagianfranco)]

Abel, can you please test packages from my ppa?
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+delete-packages

thanks

[Łukasz Zemczak (sil2100)]

Hello Abel, or anyone else affected,

Accepted virtualbox into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox/5.2.18-dfsg-2~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Abel, or anyone else affected,

Accepted virtualbox-hwe into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox-hwe/5.2.18-dfsg-3~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Abel, or anyone else affected,

Accepted virtualbox-ext-pack into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox-ext-pack/5.2.18-1~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello Abel, or anyone else affected,

Accepted virtualbox-guest-additions-iso into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/virtualbox-guest-additions-iso/5.2.18-1~ubuntu18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Gianfranco Costamagna (costamagnagianfranco)]

the packages seems to be correctly installed and runnable..
Get:14 http://archive.ubuntu.com/ubuntu bionic-proposed/multiverse amd64 virtualbox amd64 5.2.18-dfsg-2~ubuntu18.04.1 [17.0 MB]
Get:15 http://archive.ubuntu.com/ubuntu bionic-proposed/multiverse amd64 virtualbox-ext-pack all 5.2.18-1~ubuntu18.04.1 [10.2 kB]

Abel, can you please do some testing on top of mine?
thanks!

[Gianfranco Costamagna (costamagnagianfranco)]

Also the guest-additions-iso are correctly installed and placed in the right place.

[Gianfranco Costamagna (costamagnagianfranco)]

It works correctly, I can even start a VM inside the bionic-VM I created to test, with kernel 4.18 from hwe-edge

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for virtualbox has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox-hwe - 5.2.18-dfsg-3~ubuntu18.04.1

---------------
virtualbox-hwe (5.2.18-dfsg-3~ubuntu18.04.1) bionic; urgency=medium

  * Build only the guest-* packages with hwe stack
    - SRU the latest cosmic package for bionic (LP: #1796543)
    - use 16.04 hwe stack

virtualbox (5.2.18-dfsg-2) unstable; urgency=medium

  * debian/patches/kernel-4.18.patch:
    - Fix build with kernel 4.18 (LP: #1787441)

virtualbox-hwe (5.2.18-dfsg-3ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.18-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.18-dfsg
  * Patch refresh
  * Bump std-version to 4.2.0.1, no changes required

virtualbox-hwe (5.2.16-dfsg-3ubuntu18.10.4) cosmic; urgency=medium

  * Track new xorg-lts modules (18.04)

virtualbox-hwe (5.2.16-dfsg-3ubuntu18.10.3) cosmic; urgency=high

  * No change rebuild against new qt/xorg.

virtualbox-hwe (5.2.16-dfsg-3ubuntu18.10.2) cosmic; urgency=high

  * No change rebuild against older qt/xorg abi.

virtualbox-hwe (5.2.16-dfsg-3ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.16-dfsg-3) unstable; urgency=medium

  * from: Kevin Puetz:
    - patch to avoid virtualbox guest utils run if no virtual machines are detected.

virtualbox-hwe (5.2.16-dfsg-2ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.16-dfsg-2) unstable; urgency=medium

  * Allow new gcc8 to build

virtualbox (5.2.16-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.16-dfsg, patch refresh
  * Drop now upstreamed patches: {fix-build,plt-upstream-fix,videorec}.patch
  * Bump std-version to 4.1.5, no changes required
  * Drop now-useless --enable-system-libopus switch

virtualbox-hwe (5.2.14-dfsg-7ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.14-dfsg-7) unstable; urgency=medium

  * Add again libopus hack in rules file, this might be dropped
    in next upstream release

virtualbox-hwe (5.2.14-dfsg-6ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.14-dfsg-6) unstable; urgency=medium

  [ Jan Nordoholz ]
  * Refresh patch to make it really work.

virtualbox-hwe (5.2.14-dfsg-5ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.14-dfsg-5) unstable; urgency=medium

  * Reupload with upstream patch + some minor modifications to fix the issue
    again. (Closes: #902897)

virtualbox-hwe (5.2.14-dfsg-4ubuntu18.10.1) cosmic; urgency=medium

  * Build only the guest-* packages with hwe stack

virtualbox (5.2.14-dfsg-4) unstable; urgency=medium

  * Update with new upstream accepted patch.

virtualbox (5.2.14-dfsg-3) unstable; urgency=low

  [ Gianfranco Costamagna ]
  * Tweak python patch to make it compatible with Python3.7
  * Tweak previous changelog entry

  [ Will Thompson ]
  * guest-utils.service: add ConditionVirtualization=oracle

virtualbox (5.2.14-dfsg-2) unstable; urgency=low

  * Try to fix issue with new binutils (Closes: #902897)
    -...

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox-ext-pack - 5.2.18-1~ubuntu18.04.1

---------------
virtualbox-ext-pack (5.2.18-1~ubuntu18.04.1) bionic; urgency=medium

  * SRU the latest cosmic package for bionic (LP: #1796543)

virtualbox-ext-pack (5.2.18-1) unstable; urgency=medium

  * New upstream release, update postinst.

virtualbox-ext-pack (5.2.16-1) unstable; urgency=medium

  * New upstream release, update postinst.
  * Bump std-version to 4.1.5, no changes required

virtualbox-ext-pack (5.2.14-1) unstable; urgency=medium

  * New upstream release, update postinst.

virtualbox-ext-pack (5.2.12-2) unstable; urgency=medium

  * Use directly /usr/bin/wget to avoid firejail issues (Closes: #898409)

virtualbox-ext-pack (5.2.12-1) unstable; urgency=medium

  * New upstream release, update postinst.

virtualbox-ext-pack (5.2.10-4) unstable; urgency=high

  * Fix hash due to upstream change. (Closes: #897052, LP: #1767533,
    LP: #1767402)

 -- Gianfranco Costamagna <email address hidden> Wed, 10 Oct 2018 15:22:28 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox-guest-additions-iso - 5.2.18-1~ubuntu18.04.1

---------------
virtualbox-guest-additions-iso (5.2.18-1~ubuntu18.04.1) bionic; urgency=medium

  * SRU the latest cosmic package for bionic (LP: #1796543)

virtualbox-guest-additions-iso (5.2.18-1) unstable; urgency=medium

  * New upstream version 5.2.18
  * Bump std-version to 4.2.0.1, no changes required

virtualbox-guest-additions-iso (5.2.16-1) unstable; urgency=medium

  * New upstream version 5.2.16
  * Bump std-version to 4.1.5, no changes required

virtualbox-guest-additions-iso (5.2.14-1) unstable; urgency=medium

  * Add LFS support
  * Add gitattributes file
  * New upstream version 5.2.14

virtualbox-guest-additions-iso (5.2.12-1) unstable; urgency=medium

  * New upstream version 5.2.12

virtualbox-guest-additions-iso (5.2.11-122181-1) unstable; urgency=high

  * New upstream version 5.2.11-122181

 -- Gianfranco Costamagna <email address hidden> Wed, 10 Oct 2018 15:24:28 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package virtualbox - 5.2.18-dfsg-2~ubuntu18.04.1

---------------
virtualbox (5.2.18-dfsg-2~ubuntu18.04.1) bionic; urgency=medium

  * SRU the latest cosmic package for bionic (LP: #1796543)

virtualbox (5.2.18-dfsg-2) unstable; urgency=medium

  * debian/patches/kernel-4.18.patch:
    - Fix build with kernel 4.18 (LP: #1787441)

virtualbox (5.2.18-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.18-dfsg
  * Patch refresh
  * Bump std-version to 4.2.0.1, no changes required

virtualbox (5.2.16-dfsg-3) unstable; urgency=medium

  * from: Kevin Puetz:
    - patch to avoid virtualbox guest utils run if no virtual machines are detected.

virtualbox (5.2.16-dfsg-2) unstable; urgency=medium

  * Allow new gcc8 to build

virtualbox (5.2.16-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.16-dfsg, patch refresh
  * Drop now upstreamed patches: {fix-build,plt-upstream-fix,videorec}.patch
  * Bump std-version to 4.1.5, no changes required
  * Drop now-useless --enable-system-libopus switch

virtualbox (5.2.14-dfsg-7) unstable; urgency=medium

  * Add again libopus hack in rules file, this might be dropped
    in next upstream release

virtualbox (5.2.14-dfsg-6) unstable; urgency=medium

  [ Jan Nordoholz ]
  * Refresh patch to make it really work.

virtualbox (5.2.14-dfsg-5) unstable; urgency=medium

  * Reupload with upstream patch + some minor modifications to fix the issue
    again. (Closes: #902897)

virtualbox (5.2.14-dfsg-4) unstable; urgency=medium

  * Update with new upstream accepted patch.

virtualbox (5.2.14-dfsg-3) unstable; urgency=low

  [ Gianfranco Costamagna ]
  * Tweak python patch to make it compatible with Python3.7
  * Tweak previous changelog entry

  [ Will Thompson ]
  * guest-utils.service: add ConditionVirtualization=oracle

virtualbox (5.2.14-dfsg-2) unstable; urgency=low

  * Try to fix issue with new binutils (Closes: #902897)
    - thanks Jan Christoph Nordholz for the great help and fix!

virtualbox (5.2.14-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.14-dfsg
  * Drop kernel and acpica patches

virtualbox (5.2.12-dfsg-3) unstable; urgency=medium

  * debian/patches/fixes_for_4.17.patch
    from opensuse: fix build with kernel 4.17 (LP: #1776671)

virtualbox (5.2.12-dfsg-2) unstable; urgency=medium

  * Ignore new acpica-unix syntax, and sed the new aml syntax to the old
    aml working paradigm. A real fix might require:
    - a revert of acpica-unix code
    - a fallback code or switch in acpica-unix
    - changing vbox filenames to some correct C syntax
    For now, better rename the resulting structure to the old way, taking the
    approach from FreeBSD patch. (See bug: #899318)

virtualbox (5.2.12-dfsg-1) unstable; urgency=medium

  * New upstream version 5.2.12-dfsg
  * Patch refresh, drop upstream patches:
    GL-fixes.patch, vm-restore.patch, 71985.patch

virtualbox (5.2.10-dfsg-7) unstable; urgency=medium

  * debian/patches/71985.patch: add compatibility with upstream
    kernel 4.16 patch (Closes: #897928)
    thanks James McCoy for the bug report!

 -- Gianfranco Costamagna <email address hidden> Wed, 10 Oct 2018 15:27:01 +0200