virt-manager fails if target system uses tcsh as root shell

[Hadmut Danisch]

Binary package hint: virt-manager

Hi,

virt-manager fails if the target system (where kvm runs) has the root shell set to /bin/tcsh

Unfortunately, there is a patch in

./debian/patches/autodetect-nc-params.patch

which replaces the nc call to check whether the nc version on the target system requires a particular option or not (to provide compatibilty to fedora).

The syntax fails if the target system uses a tcsh as the root shell.

Isn't compatiblity to ubuntu system more important than to fedora?

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: virt-manager 0.8.2-2ubuntu8
ProcVersionSignature: Ubuntu 2.6.32-22.36-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic x86_64
Architecture: amd64
Date: Tue Jul 13 22:26:58 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100427.1)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/tcsh
SourcePackage: virt-manager

[Alvin (alvind)]

Not only the root shell. If you try to connect with username@host, virt-manager also fails to connect.

[Marc Deslauriers (mdeslaur)]

Upstream commits:

http://hg.fedorahosted.org/hg/virt-manager/rev/f09702cfdb03
http://hg.fedorahosted.org/hg/virt-manager/rev/907ee61e5558

I'll prepare an SRU for lucid. libvirt may need to get changed also.

[Hadmut Danisch (hadmut)]

Yup, I tried to change the code in console.py (and remove the .pyc), but it does not make a difference. It still takes the same if/else command from

/usr/lib/libvirt.so.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package virt-manager - 0.8.4-3ubuntu5

---------------
virt-manager (0.8.4-3ubuntu5) maverick; urgency=low

  * debian/patches/fix-nc-with-zsh.patch: Fix connecting to a remote server
    when using zsh or tcsh. (LP: #605172)
 -- Marc Deslauriers <email address hidden> Tue, 13 Jul 2010 16:59:47 -0400

[Marc Deslauriers (mdeslaur)]

The virt-manager upload to maverick didn't actually fix it for tcsh.

[Marc (marc-redhat-bugs-1)]

The shellcode that detects nc options in src/virtManager/console.py now works for zsh, but still doesn't work when the remote shell is tcsh.

[Marc (marc-redhat-bugs-1)]

s/shellcode/shell script/

[Andy (andy-xillean)]

will this be fixed in lucid?

[Cole (cole-redhat-bugs)]

I think this is fixed now upstream, please let me know if that commit doesn't work for you, since this stuff is obviously pretty hairy:

http://hg.fedorahosted.org/hg/virt-manager/rev/16fcbf77e47e

[Dave Walker (davewalker)]

@Marc, Would you be able to provide an update with the status of this bug please? :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package virt-manager - 0.8.4-3ubuntu6

---------------
virt-manager (0.8.4-3ubuntu6) maverick; urgency=low

  * debian/patches/fix-nc-with-zsh.patch: Add a new upstream commit to
    really fix compatibility with tcsh. (LP: #605172)
 -- Marc Deslauriers <email address hidden> Wed, 25 Aug 2010 12:22:38 -0400

[Marc (marc-redhat-bugs-1)]

Works great, thanks Cole!

[Launchpad Janitor (janitor)]

This bug was fixed in the package libvirt - 0.8.3-1ubuntu8

---------------
libvirt (0.8.3-1ubuntu8) maverick; urgency=low

  * debian/patches/9009-autodetect-nc-params.patch: updated to fix
    connecting to a remote server when using zsh or tcsh. (LP: #605172)
 -- Marc Deslauriers <email address hidden> Wed, 25 Aug 2010 12:41:25 -0400

[Rolf Leggewie (r0lf)]

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".