Delete confirmation dialog buttons don't follow HIG

Bug #251074 reported by Richard Laager on 2008-07-23
4
Affects Status Importance Assigned to Milestone
virt-manager
Fix Released
Low
virt-manager (Ubuntu)
Wishlist
Unassigned

Bug Description

The buttons in the delete confirmation dialogs are "Yes" and "No". They should be "Delete" and "Cancel", as per the GNOME HIG: http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en

Description of problem:
It would be nice if virt-manager also removed or at least offered
to remove the diskfile when deleting a vm, so that old stale vm diskfiles
are not left lying around.

Created attachment 289121
patch for deleting img files when deleting machine (optional choice)

This is not very pleasant UI - you get shown 2 separate dialog boxes when
deleting, and the deleting of disk images is all-or-nothing. The latter doesn't
work when a VM has 2 disk images, one private, the other shared across several
VMs (eg for CluterSuite quorum partitions); Similarly if the guest has an ISO
image attached for virtual CDROM you don't want to delete that. This really
needs just a single confirmation dialog box for deleting a VM, and in that
dialog a list of all disk images which checkboxes to select which should be
deleted. It should list the disk size, and whether its readonly/shared.

Created attachment 289131
sry. typo in previous patch :)

Daniel: hm, ok. I can try do it when I will have a time.

Based on the date this bug was created, it appears to have been reported
during the development of Fedora 8. In order to refocus our efforts as
a project we are changing the version of this bug to '8'.

If this bug still exists in rawhide, please change the version back to
rawhide.
(If you're unable to change the bug's version, add a comment to the bug
and someone will change it for you.)

Thanks for your help and we apologize for the interruption.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

(Haven't tried yet on rawhide yet BTW since I can't install guests there yet.)

The disk-files still don't get deleted when deleting a virtual machine. There is
no question to do so, neither is there an option.

Changed in virt-manager:
importance: Undecided → Wishlist

This message is a reminder that Fedora 8 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 8. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '8'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 8's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 8 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora please change the 'version' of this
bug to the applicable version. If you are unable to change the version,
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

As mentioned above, we need some intelligent UI to get this right. We _still_ don't have this upstream though, but it is at the top of my list. Moving to F10 since it is still applicable there.

A simple start would just be to popup a dialog asking if you want to delete the disk image too locally.

(In reply to comment #10)
> A simple start would just be to popup a dialog asking if you want to delete the
> disk image too locally.

Jens, I don't think that it is good idea to have this simple version of dialog. You could have many "disk images" in your virtual machine and not everytime you want to delete all images. So you have to have list with checkboxes (or something similar).

Dan Bass (dbass) on 2008-12-09
description: updated
Richard Laager (rlaager) on 2008-12-09
description: updated
Dan Bass (dbass) on 2008-12-11
Changed in virt-manager:
importance: Undecided → Unknown
status: New → Unknown
Changed in virt-manager:
status: Unknown → Confirmed
Richard Laager (rlaager) wrote :

The wording has been fixed upstream (by committing a patch from me), but the button fixing is pending another change.

Changed in virt-manager:
status: New → Confirmed
Richard Laager (rlaager) on 2009-01-25
Changed in virt-manager:
status: Confirmed → Unknown
description: updated
description: updated
Changed in virt-manager:
status: Unknown → Confirmed

Upstream now has a robust 'Delete VM' dialog which allows removing storage, providing enough info for the user to make a reasonable decision about what to remove. Moving to POST.

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/f8ad3d826039

The pending new virt-manager version will probably end up in F10, but likely not for a good while (maybe F11 release time frame.)

Changed in virt-manager:
status: Confirmed → Unknown

I think it's too late to be backporting a major virt-manager version to F10, so moving this bug F11 (where it is fixed) and closing as CURRENTRELEASE.

Changed in virt-manager:
status: Unknown → Fix Released
Marc Deslauriers (mdeslaur) wrote :

This is fixed in recent virt-manager versions, such as the one currently in Lucid. Closing this bug.

Changed in virt-manager (Ubuntu):
status: Confirmed → Fix Released
Changed in virt-manager:
importance: Unknown → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.