[FFE] merge virt-manger >3.2 for Jammy once released

Bug #1961027 reported by Christian Ehrhardt 
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
virt-manager (Ubuntu)
Fix Released
Critical
Unassigned

Bug Description

[Rationale]

virt-manager 3.2 is out for more than a year now and upstream git includes many fixes.
That was brought up upstream in [1] already and the estimation is somewhere around our feature freeze [2]. But we also need time to do this in Debian and test it and so on, therefore to be transparent and prepared I wanted to file an FFe bug right away.

There was no release by upstream in time before Feature Freeze.
But now there is [3] v4.0.0 since last week.

In addition many of the changes in there are also needed for bug 1959976 [4]

And finally today's virt-manager (3.2) in jammy would be an FTBFS without some fixes that are in 4.0 (due to the much newer libvirt version we have) - just another motivation to move to the new version.

[Proposed upload]

Since the release last week Debian packaged 4.0 (thanks).
I have test built this for jammy in a PPA [5].

The full diff out of that is available there [6].

No Delta needed - once the FFe is approved I'd sync the package.

[Tests]

The package has self tests on its own at build and autopkgtest.
On that PPA [5] I was then also running the autopkgtests which passed on all architectures [7-11] on autopkgtest infrastructure.

There are not too many reverse dependencies that we could break, actually just cockpit-machines and image-factory (for virtinst).
- The options used in image-factory (just one call to virt-install) all are still present.
- The calls from cockpit-machines do proper feature checking (app.jsx) to only use what is present and it seems to be ready for the new version.
The tests it has are integration tests not run at build/autopkgtest time so I have no results of them available atm. I have installed cockpit on jammy and run a guest install with the new virt-inst. I saw cockpit spawning

4 0 32881 32860 20 0 303116 90172 poll_s Sl ? 0:01 \_ /usr/bin/python3 /usr/bin/virt-install --connect qemu:///system --quiet --name test --os-variant ubuntu20.04 --memory 2048 --wait -1 --noautoconsole --disk size=8,format=qcow2 --graphics vnc,listen=127.0.0.1 --graphics spice,listen=127.0.0.1 --install os=ubuntu20.04 --unattended profile=jeos,admin-password-file=/tmp/cockpit-machines-756m3w3a-admin-password,user-login=ubuntu,user-password-file=/tmp/cockpit-machines-iuri0r6_-user-password

That successfully created a guest
root@j:~# virsh list --all
 Id Name State
----------------------
 1 test running

I selected an unattended install which seemed to work fine with the new virt-manager. I attached a screenshot of that [14]

Upgrade log of virt-inst can be found at [12]
Install log of virt-manager can be found at [13]

[References]

[1]: https://listman.redhat.com/archives/virt-tools-list/2022-January/msg00016.html
[2]: https://listman.redhat.com/archives/virt-tools-list/2022-January/msg00017.html
[3]: https://github.com/virt-manager/virt-manager/releases/tag/v4.0.0
[4]: https://bugs.launchpad.net/ubuntu/+source/virt-manager/+bug/1959976
[5]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4802/+packages
[6]: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4802/+files/virt-manager_1%3A3.2.0-3.1_1%3A4.0.0-1ubuntu1~jammyppa2.diff.gz
[7]: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4802/jammy/amd64/v/virt-manager/20220310_090145_cd4f0@/log.gz
[8]: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4802/jammy/arm64/v/virt-manager/20220310_090149_9209e@/log.gz
[9]: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4802/jammy/armhf/v/virt-manager/20220310_085939_9209e@/log.gz
[10]: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4802/jammy/ppc64el/v/virt-manager/20220310_090213_a7fb9@/log.gz
[11]: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-ci-train-ppa-service-4802/jammy/s390x/v/virt-manager/20220310_085546_00842@/log.gz
[12]: https://paste.ubuntu.com/p/2S2jmJrxQf/
[13]: https://paste.ubuntu.com/p/xfGFwWG4gs/
[14]: https://bugs.launchpad.net/ubuntu/+source/virt-manager/+bug/1961027/+attachment/5567651/+files/virt-inst-4.0-from-cockpit-jammy.png

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Can we pre-acknowledge that way to go, or do you (ubuntu-release) need/want to wait until there is a new release and I can provide that usual requested PPA build, full Diff and install log?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI related to bug 1959976 (asking for features that are in git but not released yet).

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

FYI - I pinged upstream again asking for an updated ETA on the new release, see [1]

[1]: https://listman.redhat.com/archives/virt-tools-list/2022-February/msg00020.html

Frank Heimes (fheimes)
tags: added: jammy
tags: added: server-todo
tags: added: needs-merge
removed: server-todo
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

hm, let's see when 3.3.0 comes out. Is there a planned ETA for the new virt-manager release? Since I think the timing and also the magnitude of the update. 3.2.0 seemed to be relatively small, but 3.1.0 had a bit more included. Let's keep this FFe open for now and try getting a bit more information.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

https://github.com/virt-manager/virt-manager/releases/tag/v4.0.0 was released (in our sprint week).
It would be time to package and test this to then show the release Team exactly what the FFe would be about.

P.S. this is also required for bug 1959976

tags: added: server-todo
Changed in virt-manager (Ubuntu):
importance: Undecided → Critical
description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
description: updated
description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I have updated this case and I think it is now ready for (re)evaluation for an FFe approval by the release team.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks for gathering all the needed information Christian! I don't see any breaking changes in the changelog, which is good - the additional rationale also makes sense. Ok, let's do this. Please sync and make sure it migrates!

Changed in virt-manager (Ubuntu):
status: New → Triaged
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thank you syncing now and checking migration over the next few days.

Changed in virt-manager (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This bug was fixed in the package virt-manager - 1:4.0.0-1

---------------
virt-manager (1:4.0.0-1) unstable; urgency=medium

  * New upstream version 4.0.0:
    - should properly support AyatanaAppIndicator3 (Closes: #990819)
  * Update standards version to 4.6.0, no changes needed.
  * Drop all the patches, fixed or backported from upstream
  * Update build/runtime dependencies according to upstream:
    - add python3-setuptools B-D
    - replace genisoimage with xorriso (Closes: #982235)
    - bump python3-gi to 3.31.3
  * Remove extra exec bits from .py files in /usr/share/virt-manager
  * Remove the forced C locale during tests, the issue was fixed upstream

 -- Pino Toscano <email address hidden> Tue, 08 Mar 2022 07:44:37 +0100

Changed in virt-manager (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

https://launchpad.net/ubuntu/+source/virt-manager/1:4.0.0-1 started to build -> Fix-Comitted.

I'll mark this closed when it really migrates (as well as bug 1959976).

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Migrated to Jammy release

Changed in virt-manager (Ubuntu):
status: Fix Committed → Fix Released
Bryce Harrington (bryce)
Changed in virt-manager (Ubuntu):
milestone: none → jammy-updates
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.