munin plugin suppresses numbers from VM names

[Bernie Innocenti]

Binary package hint: virt-goodies

The valid regex should be [A-Za-z0-9_] (with numbers included).

Also, the entire canonicalize() function could be replaced with just one
line:

  tr/A-Za-z0-9/_/c

or even

  s/[^A-Za-z0-9]/_/g

Perl's eclecticism :-)

[Soren Hansen (soren)]

On Mon, Mar 08, 2010 at 02:02:14PM -0000, Bernie Innocenti wrote:
> The valid regex should be [A-Za-z0-9_] (with numbers included).

Not exactly. According to

   http://munin-monitoring.org/wiki/notes_on_datasource_names

these two should do it:

s/^[^A-Za-z_]/_/
s/[^A-Za-z0-9_]/_/g

> Also, the entire canonicalize() function could be replaced with just one
> line:
>
> tr/A-Za-z0-9/_/c
>
> or even
>
> s/[^A-Za-z0-9]/_/g
>
>
> Perl's eclecticism :-)

Well, yeah, except this is Python :)

--
Soren Hansen
Ubuntu Developer
http://www.ubuntu.com/

[Launchpad Janitor (janitor)]

This bug was fixed in the package virt-goodies - 0.4

---------------
virt-goodies (0.4) lucid; urgency=low

  * Properly unquote strings when vmx file uses DOS linefeeds. (LP: #246841)
    Thanks to Tor Hveem for the patch.
  * Make canonicalise in libvirt-munin act according to munin's
    documentation. (LP: #534397)
 -- Soren Hansen <email address hidden> Mon, 08 Mar 2010 20:49:34 +0100

[Bernie Innocenti (codewiz)]

On Mon, 2010-03-08 at 19:53 +0000, Soren Hansen wrote:
> > Perl's eclecticism :-)
>
> Well, yeah, except this is Python :)

Oh, my... I must have been SO drunk to confuse Perl with Python.
But, wait: one could reach a similar level of conciseness even in
Python:

  re.sub(r"[^A-Za-z0-9]", "_", foo)

--
   // Bernie Innocenti - http://codewiz.org/
 \X/ Sugar Labs - http://sugarlabs.org/

[Soren Hansen (soren)]

On Wed, Mar 10, 2010 at 03:32:13AM -0000, Bernie Innocenti wrote:
> one could reach a similar level of conciseness even in Python:
>
> re.sub(r"[^A-Za-z0-9]", "_", foo)

No. The first character cannot be a numeral as per

   http://munin-monitoring.org/wiki/notes_on_datasource_names

--
Soren Hansen
Ubuntu Developer
http://www.ubuntu.com/

[Bernie Innocenti (codewiz)]

On Wed, 2010-03-10 at 10:09 +0000, Soren Hansen wrote:
> On Wed, Mar 10, 2010 at 03:32:13AM -0000, Bernie Innocenti wrote:
> > one could reach a similar level of conciseness even in Python:
> >
> > re.sub(r"[^A-Za-z0-9]", "_", foo)
>
> No. The first character cannot be a numeral as per
>
> http://munin-monitoring.org/wiki/notes_on_datasource_names

Oh, right. Then... hmmm... we could use two alternate patterns:

 re.sub(r"^[^A-Za-z]|[^A-Za-z0-9]", "_", foo)

--
   // Bernie Innocenti - http://codewiz.org/
 \X/ Sugar Labs - http://sugarlabs.org/