Share My Desktop crashes Vino due to a buggy Ubuntu patch

Bug #997699 reported by Will Thompson on 2012-05-10
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vino (Ubuntu)
High
Unassigned
Precise
High
Unassigned

Bug Description

Right-clicking a contact in Empathy causes Vino to emit a warning about the "use-dbus-listener" property not existing, a few criticals from tp-glib, and then crash.

This appears to be due to the following hunk of debian/patches/12_app-indicators-only.patch:

Index: b/server/vino-tube-servers-manager.c
===================================================================
--- a/server/vino-tube-servers-manager.c
+++ b/server/vino-tube-servers-manager.c
@@ -196,6 +196,9 @@ handle_channels_cb (TpSimpleHandler *han
·
   server = g_object_new (VINO_TYPE_TUBE_SERVER,
       "display-status-icon", 0,
+ #ifdef VINO_ENABLE_APP_INDICATOR
+ "use-dbus-listener", 0,
+ #endif /* VINO_ENABLE_APP_INDICATOR */
       "prompt-enabled", 0,
       "view-only", 0,
       "network-interface", network_interface,

This essentially reverts this year-old upstream fix http://git.gnome.org/browse/vino/commit/?id=1410f8c if Vino is built with support for app indicators, which of course it is. The undefined property causes GLib to stop processing the property list, which means the VinoTubeServer's "tube" property is NULL (explaining the warnings from telepathy-glib when VinoTubeServer tries to use its tube). I haven't confirmed beyond doubt that this is also what causes the subsequent crash—I was debugging the issue on someone else's machine—but it seems extremely likely.

The fix should simply be to drop that hunk of the patch. (This crash cannot be remotely triggered or anything nasty like that.)

Changed in vino (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vino - 3.4.1-0ubuntu2

---------------
vino (3.4.1-0ubuntu2) quantal; urgency=low

  * debian/patches/12_app-indicators-only.patch
    - Removed non-existing property which was only set if using
      the appindicator (LP: #997699)
  * debian/control.in
    - use latest standards version
 -- Ken VanDine <email address hidden> Thu, 10 May 2012 14:43:03 -0700

Changed in vino (Ubuntu):
status: New → Fix Released
Changed in vino (Ubuntu Precise):
assignee: nobody → Ken VanDine (ken-vandine)
status: New → Confirmed
Changed in vino (Ubuntu):
assignee: Ken VanDine (ken-vandine) → nobody
Changed in vino (Ubuntu Precise):
importance: Undecided → High
status: Confirmed → In Progress
Changed in vino (Ubuntu Precise):
assignee: Ken VanDine (ken-vandine) → nobody

Hello Will, or anyone else affected,

Accepted vino into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in vino (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Will Thompson (wjt) wrote :

The package in precise-proposed fixes this specific crash—thanks!

https://bugzilla.gnome.org/show_bug.cgi?id=651960 means Share My Desktop is still broken out of the box. That bug is fixed in vino 3.5 but the patches were not applied to 3.4 because they add a translatable string to the --help output. Without those patches, users must open Desktop Sharing preferences and tick [×] Allow other users to view your desktop (plus at least one of the first two Security options to avoid being a gaping vulnerability on untrusted networks); otherwise, Share My Desktop silently fails.

So backporting those patches would be nice to have but I understand that it's more work :)

Sebastien Bacher (seb128) wrote :

Will, we might want to consider backporting those but that's a different issue and we should track it in a different ticket, can you open a new bug about it?

tags: added: verification-done
removed: verification-needed
Will Thompson (wjt) wrote :

Ah, Guillaume pointed out that there already is such a ticket: https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/966556

Chris Halse Rogers (raof) wrote :

Hello Will, or anyone else affected,

Accepted vino into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Will Thompson (wjt) wrote :

Hi Chris,

Is there a new package in precise-proposed? How does it differ from the precise-proposed package which I verified on Monday?

Sebastien Bacher (seb128) wrote :

Will: yes there is one, see https://launchpad.net/ubuntu/+source/vino/3.4.2-0ubuntu1

the new update is on top of the one you tested monday and fixes the other issue you mentioned as well

Will Thompson (wjt) wrote :

Marvellous: it now works out of the box. Thank you!

Sebastien Bacher (seb128) wrote :

Thanks for testing, can you comment on the second bug as well if you verified the fix?

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vino - 3.4.2-0ubuntu1

---------------
vino (3.4.2-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - upstream translation updates
  * debian/patches/00_server_share_tube.patch
    - Backport a fix from 3.5 series that fixes a regression introduced when
      Vino switched to GSettings as it started exiting right away when
      desktop sharing was disabled. This fixes desktop sharing from
      empathy and any other telepathy clients (LP: #966556)
  * debian/patches/12_app-indicators-only.patch
    - refreshed

vino (3.4.1-0ubuntu1.1) precise-proposed; urgency=low

  * debian/patches/12_app-indicators-only.patch
    - Removed non-existing property which was only set if using
      the appindicator (LP: #997699)
 -- Ken VanDine <email address hidden> Tue, 15 May 2012 16:44:57 -0400

Changed in vino (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.