make.vim fails to recognize valid makeIdent with dashes during assignment

Bug #889553 reported by cub
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vim (Ubuntu)
New
Undecided
Unassigned

Bug Description

1. Create a Makefile with a variable that has dashes:
foo-bar=baz
$(foo-bar):

2. Observe that syntax highlighting fails for assignment, but $(foo-bar) is highlighted correctly.
3. Apply the attached patch; restart vim; observe that the bug is fixed (root cause: the \w pattern excludes dashes).

The bug definitely exists in 10.04 and 11.10. I'm guessing it's universal. If you need exact packages:

2:7.2.330-1ubuntu3 (ubuntu 10.04, amd64)
2:7.3.154+hg~74503f6ee649-2ubuntu3 (ubuntu 11.10, i386)

Tags: patch
Revision history for this message
cub (cub1975-deactivatedaccount) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patch for vim 7.2 (ubuntu 10.04)" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Will Gray (graywh) wrote :

Well, the GNU make manual says "variable names containing characters other than letters, numbers, and underscores should be avoided, as they may be given special meanings in the future, and with some shells they cannot be passed through the environment to a sub-make".

Revision history for this message
Will Gray (graywh) wrote :

Also, you should contact the script maintainer about this. In the meantime, you can add those new syn-match lines to ~/.vim/after/syntax/make.vim to take advantage of them without modifying the system-wide syntax/make.vim.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.