vdeterm does not restore terminal when it returns in error

Bug #804647 reported by AlainKnaff on 2011-07-02
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vde2 (Debian)
Fix Released
Unknown
vde2 (Ubuntu)
Medium
Unassigned
Declined for Natty by Logan Rosen
Declined for Oneiric by Logan Rosen
Declined for Quantal by Logan Rosen
Lucid
Undecided
Unassigned
Precise
Undecided
Unassigned

Bug Description

=============================================================
Impact: vdeterm failure corrupts terminal
Development fix: restore terminal on failure
Stable fix: same as development fix
Test case: run 'vdeterm', then try 'ls'. Terminal should act as normal when vde has been patched.
Regression potential: this fix has been applied since quantal to the same version, so there should be no risk of regression
=============================================================

When vdeterm fails at start (such as happens when specifying the wrong vde socket), then it does not restore the terminal.

The terminal is thus left in noecho mode.

# lsb_release -rd
Description: Ubuntu 10.04.2 LTS
Release: 10.04

# apt-cache policy vde2
vde2:
  Installed: 2.2.3-3
  Candidate: 2.2.3-3
  Version table:
 *** 2.2.3-3 0
        500 http://fr.archive.ubuntu.com/ubuntu/ lucid/universe Packages
        100 /var/lib/dpkg/status

What do I expect:
on error, vdeterm should restore the terminal into the state where it found it in

What happens instead:
the terminal is left with noecho (... and possibly other settings wrong as well...)

Serge Hallyn (serge-hallyn) wrote :

Thanks for reporting this bug. Still the case on quantal, marking confirmed.

Changed in vde2 (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Serge Hallyn (serge-hallyn) wrote :

Proposed patch to fix this in quantal.

tags: added: patch
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vde2 - 2.3.2-4ubuntu1

---------------
vde2 (2.3.2-4ubuntu1) quantal; urgency=low

  * vdeterm: don't improperly reset the terminal when exiting too
    early (LP: #804647)
 -- Serge Hallyn <email address hidden> Tue, 24 Jul 2012 17:26:09 -0500

Changed in vde2 (Ubuntu):
status: Triaged → Fix Released
Changed in vde2 (Debian):
status: Unknown → New
Logan Rosen (logan) wrote :

Serge, please make the bug description fit the SRU Bug Template [1] so that we can push a fix out to Lucid and Precise.

[1] https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Changed in vde2 (Ubuntu Lucid):
status: New → Incomplete
Changed in vde2 (Ubuntu Precise):
status: New → Incomplete
Changed in vde2 (Ubuntu Lucid):
assignee: nobody → Serge Hallyn (serge-hallyn)
Changed in vde2 (Ubuntu Precise):
assignee: nobody → Serge Hallyn (serge-hallyn)
Serge Hallyn (serge-hallyn) wrote :

(I trust you have or will upload the new package to precise-proposed, let me know if not)

description: updated
Changed in vde2 (Ubuntu Lucid):
assignee: Serge Hallyn (serge-hallyn) → nobody
Changed in vde2 (Ubuntu Precise):
assignee: Serge Hallyn (serge-hallyn) → nobody
Changed in vde2 (Ubuntu Lucid):
status: Incomplete → New
Changed in vde2 (Ubuntu Precise):
status: Incomplete → Confirmed
Changed in vde2 (Ubuntu Lucid):
status: New → Confirmed

Hello AlainKnaff, or anyone else affected,

Accepted vde2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/vde2/2.2.3-3ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in vde2 (Ubuntu Precise):
status: Confirmed → Fix Committed
tags: added: verification-needed
Changed in vde2 (Debian):
status: New → Fix Released

The fix for this bug has been awaiting testing feedback in the -proposed repository for precise for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate

I have tested the fix in -proposed for precise.

Package version: 2.2.3-3ubuntu1

Fix confirmed.

Logan Rosen (logan) on 2014-12-28
tags: added: verification-done
removed: verification-needed
tags: removed: removal-candidate

Hello AlainKnaff, or anyone else affected,

Accepted vde2 into lucid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vde2/2.2.3-3ubuntu1~10.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in vde2 (Ubuntu Lucid):
status: Confirmed → Fix Committed
tags: removed: verification-done
tags: added: verification-needed
tags: added: verification-done-precise verification-needed-lucid
removed: verification-needed
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in vde2 (Ubuntu Lucid):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.