buffer overruns in pidfile handling

[Seth Arnold]

static void save_pidfile()
{
        if(pidfile[0] != '/')
                strncat(pidfile_path, pidfile, PATH_MAX - strlen(pidfile_path));
        else
                strcpy(pidfile_path, pidfile);

If programs with this definition are executed with -p <more than PATH_MAX chars>, the pidfile_path heap array is overflowed and undefined behavior, including potential security problems, can result.

This code is duplicated in the following files:

src/vde_autolink.c
src/vde_pcapplug.c
src/vde_plug2tap.c
src/wirefilter.c
src/kvde_switch/consmgmt.c
src/slirpvde/slirpvde.c
src/vde_switch/consmgmt.c

[Seth Arnold (seth-arnold)]

https://sourceforge.net/tracker/?func=detail&aid=3603893&group_id=95403&atid=611248